Skip to content

TR1 fires on bounded phrases ending in a discourse word (go there, work now) #609

Closed

Description

@MohammedAlkindi

d623587 (#541) made a broad trigger word keep TR1 when the next word is one of there, here, now, then. That whitelist also catches bounded verb-plus-complement phrases.

says go there     capture 'go there'     -> TR1 "activates on 'go'"
says work now     capture 'work now'     -> TR1 "activates on 'work'"
says hello world  capture 'hello world'  -> []

go there and work now are the same shape as hello world, which #541 deliberately keeps negative. Those four words are ambiguous between discourse filler and verb complement, and a flat set-membership test cannot separate the readings.

New with that commit. On eceb39f none of these fired, because nothing retained a trailing word at all.

One more measurement, since it bounds how much of the original false negative the change closes: retention is whitelist-only. Across the same 25 words in _OVERLY_BROAD_SINGLE_WORDS, a trailing world retains TR1 in 0 of 25.

Measured on d623587 through _analyze_triggers, CPython 3.14.7.

Activity

  1. rng1995 commented on Sep 23, 2026

    @rng1995
    Collaborator

    Implementation is in progress in PR #614, which preserves bounded multiword trigger phrases instead of reducing them to a broad single-word TR1 trigger. The PR is open and has not merged; keeping this issue open pending review and verification.

  2. rng1995 commented on Oct 4, 2026

    @rng1995
    Collaborator

    Resolution update: PR #614 has merged, preserving bounded trigger phrases such as “go there” and “work now” rather than treating their discourse suffix as broad activation. Focused trigger regressions pass on current main. This supersedes the earlier pending status; this issue was automatically closed by the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions