Repository navigation
Commit b93da63
committed
fix(cli): count post-suppression findings in recursive multi-skill report
The recursive summary table and combined JSON report computed finding_count
from filtered_findings, but the report node returns filtered_findings as the
full pre-partition set (kept plus baseline-suppressed) and lists the suppressed
subset separately under suppressed_findings; it never reduces filtered_findings
to active-only. Counting len(filtered_findings) therefore reported
pre-suppression totals, so a baselined sub-skill showed score 0 but a non-zero
finding_count, disagreeing with the per-skill report body and risk score.
Add _result_finding_count(), which returns len(filtered_findings) -
len(suppressed_findings) when filtered_findings is a list (partition_findings
guarantees kept + suppressed == filtered_findings, so this is the active count),
and falls back to the raw findings length only when filtered_findings is absent
or not a list, without subtracting there since raw findings are not the
population that produced suppressed_findings. Use it at both the summary table
and the combined JSON report. Add a regression test covering a fully suppressed
sub-skill (active 0) and a partially suppressed one (active 1), plus a unit test
exercising each branch of the helper.
Refs #201
Signed-off-by: Werner Kasselman <[email protected]>1 parent 065d8fd commit b93da63
2 files changed
Lines changed: 127 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
361 | 361 | | |
362 | 362 | | |
363 | 363 | | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
364 | 388 | | |
365 | 389 | | |
366 | 390 | | |
| |||
415 | 439 | | |
416 | 440 | | |
417 | 441 | | |
418 | | - | |
419 | | - | |
| 442 | + | |
420 | 443 | | |
421 | 444 | | |
422 | 445 | | |
| |||
438 | 461 | | |
439 | 462 | | |
440 | 463 | | |
441 | | - | |
442 | | - | |
443 | | - | |
| 464 | + | |
444 | 465 | | |
445 | 466 | | |
446 | 467 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
253 | 253 | | |
254 | 254 | | |
255 | 255 | | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
0 commit comments