Skip to content

Commit 9c73b08

Browse files
committed
fix: preserve TP4 finding metadata
Assisted-by: Codex (GPT-5) Signed-off-by: Efe Gökdemir <[email protected]>
1 parent dc324e7 commit 9c73b08

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

‎src/skillspector/nodes/analyzers/mcp_tool_poisoning.py‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,16 +1126,21 @@ def _tp4_finding(
11261126
actual = result.actual_behavior_summary[:1024]
11271127
mismatched = [str(item)[:256] for item in result.mismatched_capabilities[:16]]
11281128
mismatched_text = ", ".join(mismatched)[:2048] if mismatched else "unspecified"
1129+
message = (
1130+
f"Description-behavior mismatch: declared purpose is '{declared}' "
1131+
f"but code also performs: {mismatched_text}."
1132+
)[:4096]
1133+
from skillspector.nodes.analyzers.pattern_defaults import get_pattern_name
1134+
11291135
return Finding(
11301136
rule_id="TP4",
1131-
message=(
1132-
f"Description-behavior mismatch: declared purpose is '{declared}' "
1133-
f"but code also performs: {mismatched_text}."
1134-
)[:4096],
1137+
message=message,
11351138
severity="HIGH" if result.confidence >= 0.7 else "MEDIUM",
11361139
confidence=result.confidence,
11371140
file="SKILL.md",
11381141
category=_CATEGORY,
1142+
pattern=get_pattern_name("TP4"),
1143+
finding=message,
11391144
tags=list(_FRAMEWORK_TAGS),
11401145
explanation=(result.explanation[:4096] or f"Declared: {declared}. Actual: {actual}."),
11411146
remediation=(

‎tests/test_mcp_tool_poisoning.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,6 +1086,8 @@ def test_mismatch_detected(self, monkeypatch: pytest.MonkeyPatch):
10861086
tp4 = [f for f in result["findings"] if f.rule_id == "TP4"]
10871087
assert len(tp4) >= 1
10881088
assert tp4[0].severity in {"HIGH", "MEDIUM"}
1089+
assert tp4[0].pattern == "Description-Behavior Mismatch"
1090+
assert tp4[0].finding == tp4[0].message
10891091

10901092
def test_no_mismatch_clean(self, monkeypatch: pytest.MonkeyPatch):
10911093
_mock_tp4_structured_llm(monkeypatch, [{"is_mismatch": False}])

0 commit comments

Comments
 (0)