Skip to content

Commit 5dd64ef

Browse files
committed
fix: preserve authoritative dependency findings
Signed-off-by: Narendran Raghavan <[email protected]>
1 parent 3036466 commit 5dd64ef

1 file changed

Lines changed: 13 additions & 6 deletions

File tree

‎src/skillspector/nodes/meta_analyzer.py‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,9 @@ def _fallback_filtered(findings: list[Finding]) -> list[Finding]:
250250
"""Preserve deterministic findings and add defaults in --no-llm mode."""
251251
result: list[Finding] = []
252252
for f in findings:
253+
if f.rule_id in _AUTHORITATIVE_DETERMINISTIC_RULES:
254+
result.append(f)
255+
continue
253256
result.append(
254257
replace(
255258
f,
@@ -274,12 +277,16 @@ def _passthrough_with_defaults(findings: list[Finding]) -> list[Finding]:
274277
should fail-closed — showing more findings is safer than silently dropping.
275278
"""
276279
return [
277-
replace(
278-
f,
279-
remediation=f.remediation or get_remediation(f.rule_id),
280-
code_snippet=f.code_snippet or f.context,
281-
evidence=dict(f.evidence),
282-
occurrences=list(f.occurrences),
280+
(
281+
f
282+
if f.rule_id in _AUTHORITATIVE_DETERMINISTIC_RULES
283+
else replace(
284+
f,
285+
remediation=f.remediation or get_remediation(f.rule_id),
286+
code_snippet=f.code_snippet or f.context,
287+
evidence=dict(f.evidence),
288+
occurrences=list(f.occurrences),
289+
)
283290
)
284291
for f in findings
285292
]

0 commit comments

Comments
 (0)