Repository navigation
Commit 51da126
committed
fix(analyzers): scope the AR2 warning-mandate exemption to its own span
Addresses yashrajp22's review on #461, three related gaps in the
negated-warning-mandate exemption:
- the exemption was applied to every finding sharing a sentence-level
clause (_CLAUSE_BOUNDARY_PATTERN only splits on . ; ! ?), so an
unrelated earlier live-suppression finding got zeroed by a real
mandate later in the same sentence. Now requires the mandate match to
contain the finding's own span.
- the 'V1 or V2 <object>' shared-object allowance accepted a
conjunction ('and') as the object, letting a genuinely separate
clause through. Conjunctions and 'to' are now excluded from that slot.
- 'never fail to X' and 'do not hesitate to X' flip the surface
negation ('always X', 'go ahead and X'), so a following 'without
warnings' is a real suppression and must not be exempted.1 parent 990ce15 commit 51da126
2 files changed
Lines changed: 83 additions & 6 deletions
File tree
- src/skillspector/nodes/analyzers
- tests/nodes/analyzers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
200 | 204 | | |
201 | | - | |
| 205 | + | |
202 | 206 | | |
203 | 207 | | |
204 | 208 | | |
| |||
396 | 400 | | |
397 | 401 | | |
398 | 402 | | |
399 | | - | |
400 | | - | |
401 | | - | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
402 | 417 | | |
403 | 418 | | |
404 | 419 | | |
| |||
445 | 460 | | |
446 | 461 | | |
447 | 462 | | |
448 | | - | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
449 | 466 | | |
450 | 467 | | |
451 | 468 | | |
| |||
456 | 473 | | |
457 | 474 | | |
458 | 475 | | |
459 | | - | |
| 476 | + | |
460 | 477 | | |
461 | 478 | | |
462 | 479 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
440 | 500 | | |
441 | 501 | | |
442 | 502 | | |
| |||
0 commit comments