Repository navigation
Commit 3eb3cd9
fix(tm3): skip umask-masked modes and report permissive umask values
The TM3 "Unsafe Defaults" permission pattern
`(?:mode|permission|umask)\s*=\s*(?:0?o?777|0?o?666)` reported
`mode = 0o666 & ~umask`, which is the umask-respecting default (#644,
item B6). It also read umask values backwards: `umask = 0o777`, the
most restrictive value, was reported, while `umask 000` and
`os.umask(0)`, which make new files world-writable, were not.
- mode/permission: a 777/666 mode followed only by `& ~<name>umask` (or
`& ~<name>.umask(...)`) up to the end of the expression is skipped.
Bits added after the mask (`& ~umask | 0o777`) and masks that are not
the umask (`& ~0`) are still reported.
- umask assignment or shell command: report a value whose last octal
digit leaves the world-write bit unmasked (0, 000, 0000, 004).
- umask(...) call: report a zero or leading-0 octal argument with the
same rule, except when the result is assigned (`old = os.umask(0)`),
which is how Python reads the current umask before restoring it.
Signed-off-by: Ilai Goldschmidt <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 025c65e commit 3eb3cd9
2 files changed
Lines changed: 116 additions & 2 deletions
File tree
- src/skillspector/nodes/analyzers
- tests/unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
355 | 355 | | |
356 | 356 | | |
357 | 357 | | |
358 | | - | |
359 | | - | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
360 | 372 | | |
361 | 373 | | |
362 | 374 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1790 | 1790 | | |
1791 | 1791 | | |
1792 | 1792 | | |
| 1793 | + | |
| 1794 | + | |
| 1795 | + | |
| 1796 | + | |
| 1797 | + | |
| 1798 | + | |
| 1799 | + | |
| 1800 | + | |
| 1801 | + | |
| 1802 | + | |
| 1803 | + | |
| 1804 | + | |
| 1805 | + | |
| 1806 | + | |
| 1807 | + | |
| 1808 | + | |
| 1809 | + | |
| 1810 | + | |
| 1811 | + | |
| 1812 | + | |
| 1813 | + | |
| 1814 | + | |
| 1815 | + | |
| 1816 | + | |
| 1817 | + | |
| 1818 | + | |
| 1819 | + | |
| 1820 | + | |
| 1821 | + | |
| 1822 | + | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
| 1830 | + | |
| 1831 | + | |
| 1832 | + | |
| 1833 | + | |
| 1834 | + | |
| 1835 | + | |
| 1836 | + | |
| 1837 | + | |
| 1838 | + | |
| 1839 | + | |
| 1840 | + | |
| 1841 | + | |
| 1842 | + | |
| 1843 | + | |
| 1844 | + | |
| 1845 | + | |
| 1846 | + | |
| 1847 | + | |
| 1848 | + | |
| 1849 | + | |
| 1850 | + | |
| 1851 | + | |
| 1852 | + | |
| 1853 | + | |
| 1854 | + | |
| 1855 | + | |
| 1856 | + | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
| 1869 | + | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
| 1885 | + | |
| 1886 | + | |
| 1887 | + | |
| 1888 | + | |
| 1889 | + | |
| 1890 | + | |
| 1891 | + | |
| 1892 | + | |
| 1893 | + | |
| 1894 | + | |
1793 | 1895 | | |
1794 | 1896 | | |
1795 | 1897 | | |
| |||
0 commit comments