Repository navigation
fix(judge): treat an "unavailable" schema option as a schema rejection - #219
Merged
chrisknvidia merged 1 commit intoOct 21, 2026
Merged
Conversation
MaxFreedomPollard
requested review from
chrisknvidia,
mosheabr,
rmalani-nv and
rng1995
as code owners
October 20, 2026 22:20
DeepSeek answers response_format json_schema with HTTP 400 and "This response_format type is unavailable now". The judge already drops the schema and retries when a provider rejects it, but the matcher only knew "unsupported", "not supported" and friends, so every Tier 3 judge call failed instead. Add "unavailable" as a rejection reason in the host client and the Harbor template, and let the after-option pattern accept the word "type" between the option and the verb. Fixes #207. Signed-off-by: Max Freedom Pollard <[email protected]>
MaxFreedomPollard
force-pushed
the
judge-unavailable-schema-option
branch
from
October 20, 2026 22:21
0922127 to
f70ea60
Compare
Collaborator
|
Looks good! |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #207.
DeepSeek answers
response_format: json_schemawith HTTP 400 and "This response_format type is unavailable now". The judge already drops the schema and retries when a provider rejects it, but the matcher only knew "unsupported", "not supported" and friends, so every Tier 3 judge call failed instead.unavailableis now a rejection reason in the host client and the Harbor template, and the after-option pattern allows the wordtypebetween the option and the verb, which is how DeepSeek phrases it.Verification
make lintmake testmake buildmake teston this branch: 13,563 passed. The 100 failures I see locally are the same 100 on unpatched main (the live Seatbelt and Docker suites, which my sandboxed machine can't run, and anhttpx2SDK mismatch), so they are environmental rather than from this change.Release Impact
CHANGELOG.md