Repository navigation
chore(sdk/go): deprecate the in-tree Go SDK and drop its CI gate - #5245
Merged
Merged
Conversation
The Go SDK moved to github.com/ai-openshell/sdk-go (NVIDIA#5031). Mark the old module deprecated so pkg.go.dev and go get point users there, and replace the README with a moved notice and migration steps. Drop the go job from Branch Checks and go:ci from the ci aggregate, so proto changes no longer need regenerated Go bindings in this repository. Add a Go SDK Freeze job that fails when a PR adds or changes files under sdk/go. Deletions (the removal PR) and the README and go.mod notices are allowed. The directory itself is removed in a follow-up once the final deprecated sdk/go tag exists. Signed-off-by: Roland Huß <[email protected]>
rhuss
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 4, 2026 10:43
elezar
approved these changes
Nov 4, 2026
elezar
left a comment
elezar
left a comment
Member
There was a problem hiding this comment.
Approving. The deprecation, CI-gate removal and freeze job look right, and the freeze is enforced through the OpenShell / Branch Checks gate on PRs. All comments are non-blocking.
Not anchored: the CodeQL Go matrix entry (codeql.yml, codeql-config.yml) and sdk-go-tag.yml still reference sdk/go. Deferring them to the removal PR is fine; please note that in the PR description or on #5031 so it isn't lost.
Member
|
/ok-to-test 6250fa2 |
SDAChess
added
area:build
github-actions
Bot
requested review from
TaylorMutch,
matthewgrossman and
purp
November 4, 2026 11:11
elezar
enabled auto-merge
November 4, 2026 12:45
This was referenced Nov 4, 2026
7 tasks done
feloy
added a commit
to feloy/OpenShell
that referenced
this pull request
Nov 9, 2026
Drop the six Go SDK updates from this branch after the SDK moved to ai-openshell/sdk-go. Restore the generated protobuf bindings, profile types, converters, and tests together to keep the snapshot consistent. The Go SDK CI gate was removed in NVIDIA#5245 and replaced with a freeze check that rejects additions or modifications under sdk/go. Support for the new provider profile fields belongs in the standalone SDK repository. Validation: mise run go:test passed, including race detection and compatibility tests. Verified sdk/go matches the branch merge base and git diff --check passes. Signed-off-by: Philippe Martin <[email protected]>
6 of 8 tasks
computedocean
pushed a commit
to computedocean/OpenShell
that referenced
this pull request
Nov 11, 2026
…-go (NVIDIA#5461) * chore(sdk/go)!: remove the Go SDK, now at github.com/ai-openshell/sdk-go The Go SDK moved to github.com/ai-openshell/sdk-go (NVIDIA#5031), and the final sdk/go tag carries the deprecation notice. Remove what is left of it from this repository: - sdk/go/, tasks/go.toml, and the Go toolchain and tools in mise.toml and mise.lock (nothing else here is written in Go) - the Go entry, setup, and build steps in CodeQL, and sdk/go in the CodeQL config - sdk-go-tag.yml and the tag-sdk-go job in release-publish.yml, including its needs entry and the expected-publisher check - the Go SDK Freeze job in Branch Checks, which has nothing left to guard docs/sdk/go.mdx now shows the new module path, pins the SDK version to the gateway's, and keeps the migration steps from the old module that were reviewed on NVIDIA#5245. README, CONTRIBUTING, AGENTS, TESTING, CI.md, buf.yaml, and the Windows skill drop or redirect their sdk/go references. Existing sdk/go/vX.Y.Z tags stay, so builds that use the old module path keep working. BREAKING CHANGE: github.com/NVIDIA/OpenShell/sdk/go is no longer developed in this repository; use github.com/ai-openshell/sdk-go. Signed-off-by: Roland Huß <[email protected]> * ci: drop the go-sdk compatibility surface With sdk/go removed, the compatibility review has no Go SDK left to review. Remove go-sdk from the required surfaces in the review prompt and in the report validator, which rejects reviews that don't cover exactly the listed surfaces, and drop Go from the CI.md descriptions of the compatibility review, CodeQL, and the release publishers. Signed-off-by: Roland Huß <[email protected]> --------- Signed-off-by: Roland Huß <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Go SDK moved to ai-openshell/sdk-go. This marks the in-tree module deprecated, drops its CI gate so proto changes no longer need regenerated Go bindings, and fails PRs that add or change files under
sdk/go/while the directory still exists.Related Issue
Closes #5241 (part of #5031)
Changes
sdk/go/go.mod:// Deprecated: this module moved to github.com/ai-openshell/sdk-go.From the nextsdk/go/vX.Y.Ztag on,go getand pkg.go.dev show it.sdk/go/README.md: replaced with a moved notice and the import rewrite for consumers.gojob (mise run go:ci);tasks/ci.toml: removedgo:cifrom theciaggregate.tasks/go.tomlstays until the directory is removed.Go SDK Freezejob. It fails when a PR adds or modifies files undersdk/go/, with a message pointing to sdk-go. Deleted files and the two notice files above are allowed, so the removal PR passes. It runs on mirror pushes only; merge queue runs skip it.AGENTS.md: the Go SDK section now points to sdk-go and the freeze.sdk/gopath (codeql.yml,codeql-config.yml),sdk-go-tag.yml, and thetag-sdk-gojob inrelease-publish.yml(itsneedslist and expected-jobs check included). CodeQL keeps buildingsdk/gountil then, and the tag job creates the final deprecatedsdk/go/vX.Y.Z.Release Notes
The Go SDK is now developed in ai-openshell/sdk-go with module path
github.com/ai-openshell/sdk-go. Thegithub.com/NVIDIA/OpenShell/sdk/gomodule is deprecated.Testing
actionlintandzizmor --min-severity mediumpass onbranch-checks.ymlmise run markdown:lintpassesgo mod edit -jsonandgo list -mparsesdk/go/go.modwith the deprecation commentsdk/goedit (fail), deletingsdk/go/(pass), and refactor(sdk)!: unify wait_ready and make it succeed only on Ready #5226's head (fail onsandbox_client.goand its test)Checklist