Repository navigation
Conversation
Signed-off-by: Shiju <[email protected]>
|
Label |
|
Drafted by Codex; checked by @HarryMoss. Thanks @shiju-nv. This looks like a useful way to address the startup timing confusion @rhuss described in #5160. I checked b3d63c4 locally. Both connection-span tests passed, covering authenticated waits, parent relationships, cached reuse and cancellation. One small integration point: main’s #5280 now disallows raw TcpStream::connect calls. The new test file adds two at lines 109 and 142. Could those use openshell_core::net::connect_tcp_nodelay_best_effort to satisfy the current Clippy rule? I haven’t captured a fresh Kubernetes startup trace, so that E2E acceptance criterion remains unverified by this review. |
Summary
Startup traces currently charge backend connection and authentication waits to policy discovery. Add a
boundary.connectchild span so operators can see that wait separately.Related Issue
Closes #5160.
Changes
Release Notes
Testing
cargo test --locked -p openshell-sandbox-backend --lib connection_span_ -- --nocapture: both new tests passed in a fresh test build using real TLS/RPC transport fixtures.cargo clippy --locked -p openshell-sandbox-backend --all-targets -- -D warnings: passed on the final candidate.cargo fmt -p openshell-sandbox-backend -- --checkandgit diff --check: passed.Checklist