Repository navigation
chore(deps): drop unused regorus yaml feature - #4882
Conversation
Nothing uses Rego YAML builtins. Removes regorus's serde_yaml dependency. Signed-off-by: Eric Curtin <[email protected]>
|
@TaylorMutch this is what's left on #2018 besides kube. @SDAChess PTAL, and |
|
@matthewgrossman @mrunalp PTAL when you get a chance, and |
|
@drew @matthewgrossman PTAL when you get a chance, and |
|
The remaining kube-client YAML dependency cleanup is tracked in #2019, which has been reopened after being closed by the stale bot. This PR completes the regorus feature cleanup in #2018; the direct |
|
/ok to test 52e60ee |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. policy — No explicit risk acceptance foundCustom Rego rules loaded with --policy-rules previously supported YAML builtins such as yaml.unmarshal and yaml.marshal, but removing Regorus's yaml feature disables them.
Review details
Advisory review; publication gates are unchanged. |
TaylorMutch
left a comment
TaylorMutch
left a comment
There was a problem hiding this comment.
Acknowledged and accepted: removing Regorus's yaml feature also removes yaml.marshal, yaml.unmarshal, and yaml.is_valid support from custom Rego policies loaded through --policy-rules. The feature was originally enabled for native YAML data loading, which OpenShell now handles separately; the shipped rules do not use these builtins, and we found no integration/E2E coverage or documentation promising their support. We accept this compatibility risk. If an affected use case is reported, the removal can be reverted or the feature restored.
Checks are green for this revision. The remaining kube-client YAML dependency cleanup is tracked in reopened #2019.
Summary
Drop the unused regorus
yamlfeature. It was removed in #2021 and came back with #3163.Related Issue
Closes #2018
Changes
yamlfrom regorus features inopenshell-supervisor-network.serde_yamledge. kube-client still pulls it, which the issue leaves to a kube upgrade.Release Notes
Testing
Ran
cargo test -p openshell-supervisor-network --lib,cargo check -p openshell-supervisor -p openshell-prover --tests --locked.Checklist