Repository navigation
test(podman): install util-linux-script in the e2e guest - #4423
politerealism wants to merge 1 commit into
Conversation
|
Label |
|
/ok-to-test e2bd2a0 |
The e2e tests that attach a PTY to sandbox create spawn the script command through openshell_tty_cmd, which the Fedora guest does not provide, so four sandbox_lifecycle tests failed to spawn it. Install util-linux-script before the archive runs and stop excluding sandbox_lifecycle. With the package installed all 19 sandbox_lifecycle tests passed in the rootless guest. Contributes to NVIDIA#3712. Signed-off-by: politerealism <[email protected]>
e2bd2a0 to
4fd8865
Compare
|
This pull request has had no activity for 14 days and is now marked stale. |
|
The tests that needed Holding this open until #5442 merges. If it merges as written, this PR is obsolete and can be closed. The paths here also moved to |
Summary
Install
util-linux-scriptin the rootless tmachine guest before thee2e-podmanarchive runs, and stop excludingsandbox_lifecycle. Four of its tests attach a PTY toopenshell sandbox createthroughopenshell_tty_cmd, which spawnsscript; the Fedora guest does not provide it, so those tests failed to start.Related Issue
Contributes to #3712
Changes
tests/ansible/playbooks/drivers/podman/e2e.yaml: add a task that installsutil-linux-script(the Fedora package that providesscript) before the archive tests run.tests/artifacts.nix: removesandbox_lifecycleand its comment frompodmanE2eFollowUpBinaries.The package comes from the distro repository when the playbook runs, the same way setup already downloads other tools. Moving it into the guest image build would be a possible follow-up if we want no network use after setup.
Testing
spawn openshell sandbox create: No such file or directory:canonical_main_exit_zero_completes_persistent_sandbox,canonical_main_nonzero_exit_preserves_status,sandbox_create_with_no_keep_cleans_up_after_tty_command,sandbox_create_with_no_keep_preserves_failure_then_cleans_up. With the package installed (run 38246241655) all 19sandbox_lifecycletests passed in the rootless Fedora guest.ansible-playbook --syntax-checkon the playbook andnix-instantiate --parse tests/artifacts.nixsucceed.test:e2elabel and a re-run are needed to run thee2e-podmanarchive.e2e-podmanarchive runs rootless only).Checklist