Repository navigation
fix(sandbox): resolve host-gateway aliases from proxy /etc/hosts #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
zanetworker
wants to merge
3
commits into
NVIDIA:main
from
zanetworker:2478-fix-ssrf-host-gateway-dns/az
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(sandbox): make proxy hosts fallback async and unit-testable
- Convert resolve_from_proxy_hosts to async with tokio::fs, matching the resolve_from_sandbox_hosts I/O pattern - Extract path-parameterized resolve_from_hosts_file helper so the file-reading path is unit-testable with a temp hosts file - Log read failures at debug level instead of silently falling through to DNS - Drop redundant lowercase allocation at the alias guard call site - Replace parser-only duplicate tests with temp-file tests covering alias resolution, missing alias, and unreadable file Signed-off-by: Adel Zaalouk <[email protected]>
- Loading branch information
commit 91efad63ee07b820ac4b511ae60f15db7c3d84aa
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the linter failures I think you can remove both these lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the import is needed — it's used by
resolve_from_proxy_hosts(line 2846) andresolve_from_hosts_file(line 2856), both behind the same#[cfg(any(target_os = "linux", test))]guard.The linter failure is the inverse: lines 9900 and 10036 used fully-qualified
std::path::Path::new(...)while the import already exists, triggeringunnecessary_qualification. Fixed by dropping thestd::path::prefix on those two call sites.