Repository navigation
fix(proxy): retry with backoff on transient accept errors instead of exiting #2369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8d0099f
fix(proxy): retry with backoff on transient accept errors instead of …
politerealism 629fd7d
fix(proxy): address review feedback on accept retry backoff
politerealism abfe555
fix(proxy): classify accept errors and exit on terminal failures
politerealism 39705af
fix(proxy): use nested or-patterns to satisfy clippy lint
politerealism ddae69b
fix(proxy): expand transient error allowlist and fix clippy/test issues
politerealism e8b4aab
fix(proxy): add remaining Linux accept(2) transient errnos and make t…
politerealism f13c454
fix(proxy): panic instead of silent skip when EMFILE is not triggered
politerealism File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(proxy): classify accept errors and exit on terminal failures
Three-way error classification for the accept loop: transient errors (EMFILE, ECONNABORTED) retry with backoff, terminal errors (EBADF, EINVAL, ENOTSOCK) exit immediately, and unknown errors exit after 5 consecutive failures. Adds unit tests for the classifier and error handler, plus a subprocess-isolated integration test that validates EMFILE recovery by lowering RLIMIT_NOFILE. Signed-off-by: Quinn Burdine <[email protected]> Signed-off-by: politerealism <[email protected]>
- Loading branch information
commit abfe555af0e45201a1d52e57643622aae401ceb8
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.