Skip to content

bug: gh repo clone fails with default github provider — POST git-upload-pack denied #1769

New issue
New issue
Closed
Bug
#2317
Closed
bug: gh repo clone fails with default github provider — POST git-upload-pack denied#1769
Bug
#2317
Labels
retired:area:providersRetired; do not apply. See #5151 for item-specific migration to the current taxonomy.retired:topic:l7Retired; do not apply. See #5151 for item-specific migration to the current taxonomy.test:e2eRequires end-to-end coverage

Description

@zakkak
zakkak
opened on Jun 5, 2026

Agent Diagnostic

Loaded skill: openshell-cli. Investigated the default GitHub provider profile at providers/github.yaml and the access preset expansion in crates/openshell-sandbox/src/l7/mod.rs.

Finding: The github.com:443 endpoint in the default GitHub provider uses access: read-only, which expands to allow only GET, HEAD, OPTIONS. Git's smart HTTP protocol requires POST to */git-upload-pack for clone and fetch operations. This POST is denied by the L7 proxy, causing gh repo clone and git clone https://... to fail.

Root cause confirmed by reading expand_access_presets() at l7/mod.rs:1066-1142 — read-only for REST protocol generates rules for GET/HEAD/OPTIONS only.

Description

Actual behavior: gh repo clone <repo> inside a sandbox with the default GitHub provider fails. The sandbox logs show a deny for POST github.com:443/.../git-upload-pack.

Expected behavior: Clone and fetch should succeed with the default GitHub provider since these are read-only Git operations.

Reproduction Steps

  1. openshell sandbox create -- claude (or any agent with a GitHub provider)
  2. Inside the sandbox: gh repo clone NVIDIA/OpenShell
  3. Observe the clone fails
  4. openshell logs <sandbox> --tail --source sandbox shows POST denied on github.com:443

Environment

  • Any compute driver (Docker, K8s, VM)
  • Default GitHub provider profile (providers/github.yaml)

Fix

Replace the access: read-only preset on the github.com endpoint with explicit L7 rules that add POST **/git-upload-pack alongside the standard read-only methods. This allows clone/fetch while keeping push (git-receive-pack) blocked.

Activity

  1. github-actions
    added
    state:triage-neededOpened without agent diagnostics and needs triage
    on Jun 5, 2026

  2. TaylorMutch commented on Jul 13, 2026

    @TaylorMutch
    TaylorMutch
    on Jul 13, 2026
    Collaborator

    📋 triage-agent

    Triage Assessment

    Classification: bug-confirmed

    Summary

    The built-in GitHub provider promises clone/fetch access but its current L7 policy necessarily denies Git smart HTTP's upload-pack POST. The defect remains on current main; no duplicate or open fix PR was found.

    Investigation

    providers/github.yaml configures the Git transport endpoint with REST access: read-only. The L7 preset expands that to GET, HEAD, and OPTIONS only, while a clone/fetch performs GET on info/refs followed by POST to /<owner>/<repo>.git/git-upload-pack. The second request is therefore denied as reported. The global REST preset is behaving correctly; the mismatch is in this provider-specific policy.

    Recommendation

    Replace only the github.com endpoint's preset with explicit rules that retain GET/HEAD/OPTIONS and narrowly allow POST to the tested git-upload-pack path shape. Keep git-receive-pack and unrelated POST requests denied so push/write remains opt-in. Add policy-decision tests and a GitHub-provider-only clone/fetch E2E test so broader overlapping profiles cannot mask regressions.

  3. TaylorMutch
    added
    retired:area:providersRetired; do not apply. See #5151 for item-specific migration to the current taxonomy.
    retired:topic:l7Retired; do not apply. See #5151 for item-specific migration to the current taxonomy.
    test:e2eRequires end-to-end coverage
    and removed
    state:triage-neededOpened without agent diagnostics and needs triage
    on Jul 13, 2026
  4. TaylorMutch
    added the
    Bug
    issue type on Jul 13, 2026
  5. russellb
    added 3 commits that reference this issue on Jul 17, 2026

    test(providers): strengthen git-transport regression and add clone e2e

    afb0205

    test(providers): isolate providers_v2 mutation in clone e2e

    dc397b8

    test(providers): serialize providers_v2 mutation with a suite-wide guard

    b1d100b
  6. johntmyers
    closed this as completedin #2317on Jul 20, 2026
  7. pull
    added a commit that references this issue on Jul 20, 2026

    fix(providers): allow git clone/fetch via default GitHub provider (NV…

    9377e0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    retired:area:providersRetired; do not apply. See #5151 for item-specific migration to the current taxonomy.retired:topic:l7Retired; do not apply. See #5151 for item-specific migration to the current taxonomy.test:e2eRequires end-to-end coverage

    Type

    Bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions