Skip to content

Commit fa76272

Browse files
committed
test(podman): run the e2e binaries that pass in the tmachine guest
Remove ten binaries from podmanE2eFollowUpBinaries so the rootless tmachine e2e-podman archive runs them: credential_gating, forward_proxy_graphql_l7, forward_proxy_jsonrpc_l7, forward_proxy_l7_bypass, host_gateway_alias, landlock, no_proxy, podman_oci_identity, provider_refresh_handles, and websocket_conformance. All ten passed in two consecutive probe runs. Update the exclusion comments and TESTING.md to match what the remaining entries still need. Contributes to #3712. Signed-off-by: politerealism <[email protected]>
1 parent ca18712 commit fa76272

2 files changed

Lines changed: 10 additions & 22 deletions

File tree

‎TESTING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,8 @@ Rust feature and preloads its Python workload image into the rootless Podman
305305
store. The separate `driver-podman` testsuite compares OpenShell and direct
306306
Podman user-namespace mappings for the default, `auto`, `keep-id`, and private
307307
profiles. The E2E archive excludes binaries that still depend on wrapper-owned
308-
gateway controls, host fixtures, missing guest tools, or nondeterministic relay
309-
setup. The `driver-podman` suite replaces the removed `podman_userns` E2E
308+
gateway controls, SPIFFE fixtures, the caller driver-config setting, or other
309+
guest setup. The `driver-podman` suite replaces the removed `podman_userns` E2E
310310
binary. `tests/artifacts.nix` keeps the follow-up exclusions explicit and uses
311311
the same filter for the generated inventory, so excluded binaries cannot appear
312312
as false passes or silently re-enter the archive.

‎tests/artifacts.nix‎

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -96,32 +96,21 @@ let
9696
output = "artifacts/test-archives/${muslToolchain.target}/provider-refresh-keycloak-tests.tar";
9797
};
9898

99-
# Follow-up: migrate these wrapper-coupled tests once tmachine provides their
100-
# managed-gateway controls, SPIFFE fixtures, caller driver-config setting,
101-
# guest tools, and matching workload-image identity behavior. The corporate
102-
# proxy and gateway-start binaries currently self-skip without wrapper-owned
103-
# gateway metadata, so exclude them rather than report false passes.
99+
# Follow-up: binaries that do not yet run in the rootless tmachine guest. They
100+
# need wrapper-owned managed-gateway controls (restart, configuration), SPIFFE
101+
# fixtures, the caller driver-config setting, or guest tools. The corporate
102+
# proxy and gateway-start binaries self-skip without wrapper-owned gateway
103+
# metadata, so exclude them rather than report false passes.
104104
podmanE2eFollowUpBinaries = [
105-
"credential_gating"
106105
"driver_config_volume"
107-
"forward_proxy_graphql_l7"
108-
"forward_proxy_jsonrpc_l7"
109-
"forward_proxy_l7_bypass"
110-
"host_gateway_alias"
111-
"landlock"
112106
"local_driver_token_restart"
113-
# Standalone tmachine runs can time out while opening the localhost relay.
114-
# Follow up on making the relay setup deterministic before restoring it.
115-
"no_proxy"
116107
"podman_corporate_proxy"
117108
"podman_gateway_start"
118-
"podman_oci_identity"
119109
"provider_auto_create"
120-
# The provider-refresh feature suite covers revoked Keycloak grants. This
121-
# binary instead covers stable workload handles across repeated rotations
122-
# and explicit refresh reconfiguration in a long-running sandbox.
123-
"provider_refresh_handles"
124110
"provider_token_exchange"
111+
# One test times out reaching support-container IPs from the sandbox in the
112+
# rootless guest; the other tests in the binary pass. Nextest archive
113+
# filters cannot select individual tests, so keep the complete binary here.
125114
"proxy_egress_pipeline"
126115
# Conformance covers stop/start workspace preservation and deletion while
127116
# stopped. The remaining canonical-main, TTY, attachment replay, and
@@ -130,7 +119,6 @@ let
130119
"sandbox_lifecycle"
131120
# Needs a prebuilt musl DNS probe in guest artifact mode; tracked in #3009.
132121
"transparent_tcp"
133-
"websocket_conformance"
134122
"workspace_lifecycle"
135123
];
136124
podmanE2eArchiveFilter =

0 commit comments

Comments
 (0)