Skip to content

Commit e8c7242

Browse files
committed
Merge remote-tracking branch 'upstream/main' into policy-compatibility-bug
Signed-off-by: Artem Lytvyn <[email protected]>
2 parents dcc6f7f + 592df3e commit e8c7242

741 files changed

Lines changed: 105324 additions & 28656 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/build-from-issue/SKILL.md‎

Lines changed: 29 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
name: build-from-issue
33
description: Given a GitHub issue number, plan and implement the work described in the issue. Supports direct user requests and unattended queue processing through the `agent:*` workflow labels. Includes tests, documentation updates, and PR creation. Trigger keywords - build from issue, implement issue, work on issue, build issue, start issue.
4+
metadata:
5+
internal: true
46
---
57

68
# Build From Issue
@@ -25,7 +27,9 @@ A direct request authorizes only what it says. A request to review or plan does
2527

2628
The two request labels remain human-only queue controls. Under **no circumstances** should this skill or any agent apply them, ask to apply them, or suggest automating their application.
2729

28-
Do not refuse a direct user request merely because its request label is absent. If direct work begins on an issue that was not already in the label-driven workflow, do not introduce `agent:in-progress` or `agent:pr-opened` solely for that invocation. If a matching request label is present, preserve the existing label transitions so unattended agents can track the workflow.
30+
In direct mode, issue lifecycle and `agent:*` workflow labels are advisory rather than gates. Inspect the labels and warn the user about each expected label that is missing or any lifecycle label that indicates the normal workflow is incomplete, then continue with the requested phase. Do not ask the user to fix the labels first. A direct request does not change the issue's disposition or make the labels accurate; it only authorizes the requested work.
31+
32+
If direct work begins on an issue that was not already in the label-driven workflow, do not introduce `agent:in-progress` or `agent:pr-opened` solely for that invocation. If a matching request label is present, preserve the existing label transitions so unattended agents can track the workflow.
2933

3034
## Agent Comment Markers
3135

@@ -59,11 +63,11 @@ Fetch issue + comments
5963
├─ topic:security present?
6064
│ → Route to review-security-issue or fix-security-issue; STOP
6165
│
62-
├─ Triage incomplete, awaiting information, or awaiting human disposition?
63-
│ → Report the blocking state and STOP
66+
├─ Direct mode + expected lifecycle or agent-workflow labels missing/incomplete?
67+
│ → Warn which labels are missing or incomplete; continue with the requested phase
6468
│
65-
├─ state:accepted and roadmap association both absent?
66-
│ → Human has not accepted the issue; STOP
69+
├─ Queue mode + triage incomplete, awaiting information, or awaiting human disposition?
70+
│ → Report the blocking state and STOP
6771
│
6872
├─ No plan comment and no direct planning request and agent:plan-requested absent?
6973
│ → No request for agent planning; STOP
@@ -109,13 +113,15 @@ If the issue is closed, report that and stop.
109113

110114
If `topic:security` is present, stop. General build agents must not plan or implement security issues. Route planning/review to `review-security-issue` and authorized remediation to `fix-security-issue`.
111115

112-
Stop before planning in any of these states:
116+
In queue mode, stop before planning on `state:triage-needed` or `state:needs-info`, and stop on `state:validated` without roadmap placement. Require `state:accepted` or roadmap placement before queue work proceeds. If no plan exists, require `agent:plan-requested`; require `agent:implementation-requested` before queue-mode implementation.
117+
118+
In direct mode, inspect the same expected workflow state but do not stop because a lifecycle or agent-workflow label is absent or incomplete. Before continuing, warn the user with the specific discrepancy, for example:
119+
120+
> "Issue #42 is missing `state:accepted` or roadmap placement and `agent:implementation-requested`. Those labels are expected in the queued workflow, but your direct request authorizes implementation, so I am continuing without changing them."
113121
114-
- `state:triage-needed`: the issue has not been assessed; use `triage-issue`.
115-
- `state:needs-info`: triage is waiting for evidence from the reporter.
116-
- `state:validated` without roadmap placement: triage is complete, but a human has not yet decided whether OpenShell should invest in the work.
122+
If `state:triage-needed`, `state:needs-info`, or `state:validated` is present, name that state in the warning and explain what it normally means. Continue unless the issue lacks information that is actually necessary to perform the requested work; in that case, report the concrete missing information rather than treating the label itself as the blocker.
117123

118-
Next, require a human acceptance signal: either `state:accepted` or placement on the roadmap. The label records acceptance without requiring scheduling; roadmap placement records acceptance and sequencing. If no plan exists, require either a direct user request for planning or the human-applied `agent:plan-requested` label before generating one. Never add or remove `state:accepted`, either human request label, or the `roadmap` label.
124+
Never add or remove `state:accepted`, either human request label, or the `roadmap` label.
119125

120126
## Step 2: Fetch and Classify Comments
121127

@@ -140,7 +146,7 @@ Using the state machine above, determine what to do based on:
140146
1. Whether a plan comment exists
141147
2. Whether there are human comments newer than the last agent comment (plan or conversation)
142148
3. Whether this is direct mode and which phase the user requested
143-
4. Which disposition, roadmap, and agent-workflow labels are present (`state:accepted`, `agent:plan-requested`, `agent:plan-ready`, `agent:implementation-requested`, `agent:in-progress`, `agent:pr-opened`, and the `roadmap` label)
149+
4. Which lifecycle and agent-workflow labels are present (`state:*`, `agent:plan-requested`, `agent:plan-ready`, `agent:implementation-requested`, `agent:in-progress`, and `agent:pr-opened`) and which discrepancies require a direct-mode warning
144150

145151
Follow the appropriate branch below.
146152

@@ -681,7 +687,7 @@ If the `agent:in-progress` label is present, the skill was previously started bu
681687
User says: "Plan issue #42"
682688

683689
1. Fetch issue #42 — title: "Add pagination to dataset list endpoint"
684-
2. Confirm `state:accepted` with no blocking triage state; the user's direct request authorizes planning even if `agent:plan-requested` is absent
690+
2. Notice that `state:accepted` and `agent:plan-requested` are absent; warn that the issue does not match the queued workflow, then continue because the user directly requested planning
685691
3. Fetch comments — no `🏗️ build-plan` marker found
686692
4. Pass issue to `principal-engineer-reviewer` for analysis
687693
5. Reviewer produces a plan: feat type, Medium complexity, 3 implementation steps, unit + integration tests needed
@@ -713,7 +719,7 @@ User says: "Check issue #42"
713719

714720
User says: "Build issue #42"
715721

716-
1. Fetch issue #42 — `state:accepted` is present; the user's direct request authorizes implementation
722+
1. Fetch issue #42 — `state:accepted` is present but `agent:implementation-requested` is absent; warn about the missing queue label and continue because the user directly requested implementation
717723
2. Plan exists (Revision 2), complexity: Medium, confidence: High
718724
3. No conflicting branches or PRs
719725
4. Create branch `feat/42-add-pagination/jmyers`
@@ -727,6 +733,15 @@ User says: "Build issue #42"
727733
12. No agent-workflow label transition is needed
728734
13. Report PR URL and workflow run status to user
729735

736+
### Run directly on an issue outside the workflow state machine
737+
738+
User says: "Build issue #42"
739+
740+
1. Fetch issue #42 — it has `state:triage-needed`; neither `state:accepted` nor `agent:implementation-requested` is present
741+
2. Warn that triage and acceptance are incomplete and name the missing implementation request label
742+
3. Continue through planning and implementation because the user directly requested the work
743+
4. Do not add, remove, or reinterpret lifecycle or agent-workflow labels
744+
730745
### Run on issue with existing PR
731746

732747
User says: "Build issue #42"
@@ -739,7 +754,7 @@ User says: "Build issue #42"
739754

740755
User says: "Build issue #99"
741756

742-
1. Fetch issue #99 — `state:accepted` is present; the user's direct request authorizes implementation
757+
1. Fetch issue #99 — warn about any missing expected workflow labels, then continue because the user directly requested implementation
743758
2. Plan exists: complexity High, confidence Low, has open questions
744759
3. Warn user: "Issue #99 is rated High complexity / Low confidence. Proceeding but flagging for your awareness."
745760
4. Continue with build

‎.agents/skills/build-openshell-mxc-windows/SKILL.md‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
name: build-openshell-mxc-windows
33
description: Maintain and validate OpenShell's build-only Windows MSVC lane for x64 and ARM64. Use when working on Windows compilation, `windows:*` mise tasks, unsupported Windows compute-driver contracts, or Windows build reports. This skill does not implement Docker, Kubernetes, Podman, VM, MXC driver, policy translation, MSI, service, or supervisor runtime support on Windows.
4+
metadata:
5+
internal: true
46
---
57

68
# Build OpenShell-MXC for Windows
@@ -231,7 +233,7 @@ crypto dependency builds.
231233
| `windows:build:arm64` | Release-builds `openshell-gateway.exe` and `openshell.exe` for ARM64. |
232234
| `windows:test:x64` | Runs native x64 workspace tests with `--no-fail-fast`, excluding unsupported Windows packages as top-level workspace targets. |
233235
| `windows:test:arm64` | Runs native ARM64 workspace tests with `--no-fail-fast` and the same package exclusions. Rejects non-ARM64 hosts. |
234-
| `windows:test:unsupported:x64` | Re-runs focused `openshell-server` tests for unsupported Windows driver behavior. |
236+
| `windows:test:unsupported:x64` | Re-runs focused `openshell-gateway` tests for unsupported Windows driver behavior. |
235237
| `windows:test:unsupported:arm64` | Re-runs the same focused contracts natively on ARM64. Rejects non-ARM64 hosts. |
236238
| `windows:artifacts` | Reports size and SHA256 for release artifacts that exist. |
237239
| `windows:ci` | Runs the full ordered x64-host Windows CI lane, plus ARM64 check/build when not skipped. |
@@ -248,10 +250,10 @@ Windows must continue to reject unsupported compute drivers clearly.
248250

249251
| Driver | Windows build behavior | Runtime behavior |
250252
|---|---|---|
251-
| Docker | Driver crate excluded; server config contract retained. | Gateway construction returns unsupported. |
252-
| Kubernetes | Driver crate excluded; server config contract retained. | Gateway construction returns unsupported. |
253-
| Podman | Driver crate excluded; server config contract retained. | Gateway construction returns unsupported. |
254-
| VM | Driver crate excluded from workspace validation. | Gateway construction returns unsupported. |
253+
| Docker | Driver crate excluded; gateway registration stub retained. | Gateway construction returns unsupported. |
254+
| Kubernetes | Driver crate excluded; gateway registration stub retained. | Gateway construction returns unsupported. |
255+
| Podman | Driver crate excluded; gateway registration stub retained. | Gateway construction returns unsupported. |
256+
| VM | Driver crate excluded; gateway registration stub retained. | Gateway construction returns unsupported. |
255257

256258
The focused contract tasks for either native architecture run:
257259

‎.agents/skills/build-openshell-mxc-windows/reference.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Windows is a build target only. These runtimes remain unsupported:
8585

8686
Rules:
8787

88-
- Keep config/library stubs where the gateway needs them.
88+
- Keep registration stubs in the gateway composition crate where the gateway needs them.
8989
- Return clear unsupported errors at runtime.
9090
- Do not build standalone Windows driver binaries.
9191
- Do not add Docker Desktop, WSL, Hyper-V, Podman machine, Podman Desktop, or
@@ -180,7 +180,7 @@ blocked dependency.
180180
### Focused tests report many filtered-out tests
181181

182182
This is expected for `windows:test:unsupported:x64`. Cargo runs one named test
183-
and filters the other `openshell-server` tests. Report these as filtered, not
183+
and filters the other `openshell-gateway` tests. Report these as filtered, not
184184
ignored.
185185

186186
## Reporting Counts

‎.agents/skills/create-github-issue/SKILL.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
name: create-github-issue
33
description: Create GitHub issues using the gh CLI. Use when the user wants to create a new issue, report a bug, request a feature, or create a task in GitHub. Trigger keywords - create issue, new issue, file bug, report bug, feature request, github issue.
4+
metadata:
5+
internal: true
46
---
57

68
# Create GitHub Issue
@@ -123,7 +125,7 @@ EOF
123125

124126
GitHub built-in issue types (`Bug`, `Feature`, `Task`) should come from the matching issue template when possible, or be set manually afterward. Do not try to emulate them through labels.
125127

126-
Creating an issue does not accept it or queue agent work. Agents never apply `state:accepted`, the `roadmap` label, add issues to the roadmap project, or apply `agent:plan-requested` or `agent:implementation-requested`. Community issues proceed through `triage-issue`; a human accepts technically validated work with `state:accepted` or roadmap placement. The request labels queue work for unattended agents; a user may instead direct an agent to a specific issue.
128+
Creating an issue does not accept it or queue agent work. Agents never apply `state:accepted`, the `roadmap` label, add issues to the roadmap project, or apply `agent:plan-requested` or `agent:implementation-requested`. Community issues proceed through `triage-issue`; a human accepts technically validated work with `state:accepted` or roadmap placement. The request labels queue work for unattended agents. A user may instead direct an agent to a specific issue; the agent warns about missing expected workflow labels and continues with the requested phase without changing them.
127129

128130
## Useful Options
129131

‎.agents/skills/create-github-pr/SKILL.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
name: create-github-pr
33
description: Create GitHub pull requests using the gh CLI. Use when the user wants to create a new PR, submit code for review, or open a pull request. Trigger keywords - create PR, pull request, new PR, submit for review, code review.
4+
metadata:
5+
internal: true
46
---
57

68
# Create GitHub Pull Request

‎.agents/skills/create-rfc/SKILL.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
name: create-rfc
33
description: Create OpenShell RFC proposals in rfc/ from a design request. Use when the user asks to write, draft, start, create, or update an RFC, Request for Comments, architecture proposal, API proposal, process proposal, or cross-cutting design proposal that should follow the OpenShell RFC process and template.
4+
metadata:
5+
internal: true
46
---
57

68
# Create RFC

‎.agents/skills/create-spike/SKILL.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
name: create-spike
33
description: Investigate a plain-language problem description by deeply exploring the codebase, then create a structured GitHub issue with technical findings. Prequel to build-from-issue — maps vague ideas to concrete, buildable issues. Trigger keywords - spike, investigate, explore, research issue, technical investigation, create spike, new spike, feasibility, codebase exploration.
4+
metadata:
5+
internal: true
46
---
57

68
# Create Spike
@@ -211,7 +213,7 @@ gh issue create \
211213
- <what tests exist for the affected area today, what patterns should be followed, any test infrastructure gaps>
212214
213215
---
214-
*Created by spike investigation. `state:validated` means the issue is ready for human disposition; `state:needs-info` means specific evidence is still required. A human applies `state:accepted` or places the issue on the roadmap if OpenShell should pursue the work. To queue unattended agent planning, a human applies `agent:plan-requested`; a direct request to an agent does not require that label.*
216+
*Created by spike investigation. `state:validated` means the issue is ready for human disposition; `state:needs-info` means specific evidence is still required. A human applies `state:accepted` or places the issue on the roadmap if OpenShell should pursue the work. To queue unattended agent planning, a human applies `agent:plan-requested`; on a direct request, the agent warns about missing expected workflow labels and continues without changing them.*
215217
EOF
216218
)"
217219
```
@@ -235,7 +237,7 @@ After creating the issue, report:
235237

236238
For `state:validated`:
237239

238-
> Review the issue and decide whether OpenShell should pursue it. If yes, apply `state:accepted`, associate it with a roadmap item, or do both. Either action records acceptance; roadmap placement additionally records sequencing. The work may remain human-owned. Apply `agent:plan-requested` to queue planning for an unattended agent, or directly ask an agent to use `build-from-issue`. If no, close it as not planned and record the rationale.
240+
> Review the issue and decide whether OpenShell should pursue it. If yes, apply `state:accepted`, associate it with a roadmap item, or do both. Either action records acceptance; roadmap placement additionally records sequencing. The work may remain human-owned. Apply `agent:plan-requested` to queue planning for an unattended agent, or directly ask an agent to use `build-from-issue`; on a direct request, the agent warns about missing expected workflow labels and continues without changing them. If no, close it as not planned and record the rationale.
239241
240242
For `state:needs-info`:
241243

‎.agents/skills/fix-security-issue/SKILL.md‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
name: fix-security-issue
33
description: Implement a fix for a reviewed security issue. Takes a directly requested issue number or scans for issues labeled `topic:security` and `agent:implementation-requested`. Reads the security review from the issue comments and implements the remediation plan. Trigger keywords - fix security issue, remediate security, implement security fix, patch vulnerability.
4+
metadata:
5+
internal: true
46
---
57

68
# Fix Security Issue
@@ -11,7 +13,7 @@ Implement a code fix for a security issue that has already been reviewed by the
1113

1214
- The `gh` CLI must be authenticated (`gh auth status`)
1315
- You must be in a git repository with a GitHub remote
14-
- The issue must have `topic:security`. In unattended scan mode it must also have `agent:implementation-requested`; a direct user request to fix a specific issue does not require that label.
16+
- The issue must have `topic:security`. In unattended scan mode it must also have `agent:implementation-requested`; for a direct user request, warn if that workflow label is missing and continue without changing it.
1517
- The issue must have a prior security review comment (posted by `review-security-issue`) with a **Legitimate concern** determination and a remediation plan
1618

1719
## Agent Comment Marker
@@ -30,7 +32,7 @@ The user may provide an issue number directly, or ask the agent to find issues t
3032

3133
### If an issue number is provided
3234

33-
Strip any leading `#` and proceed to Step 2 with that issue ID. The user's explicit fix request authorizes implementation; do not refuse solely because `agent:implementation-requested` is absent.
35+
Strip any leading `#` and proceed to Step 2 with that issue ID. The user's explicit fix request authorizes implementation. If `agent:implementation-requested` is absent, warn that the expected workflow label is missing and continue without changing it.
3436

3537
### If no issue number is provided
3638

@@ -61,7 +63,7 @@ Check the issue's `labels` array from the response above:
6163

6264
If `topic:security` is missing, report that this skill only handles security issues and stop. If queue mode selected an issue without `agent:implementation-requested`, report that it is not ready for unattended pickup and stop.
6365

64-
Never apply `agent:implementation-requested` yourself. Its absence does not block a direct user request to fix a specific issue.
66+
Never apply `agent:implementation-requested` yourself. In direct mode, warn about its absence and continue; the missing label does not block the user's request to fix the specific issue.
6567

6668
### Validate the security review
6769

@@ -307,7 +309,8 @@ User says: "Fix security issue #55"
307309
1. Fetch issue #55 metadata
308310
2. Labels are `["topic:security"]` -- missing `agent:implementation-requested`
309311
3. Confirm that a legitimate security review and remediation plan exist
310-
4. Proceed because the user's direct request authorizes implementation
312+
4. Warn that `agent:implementation-requested` is missing from the expected workflow state
313+
5. Proceed because the user's direct request authorizes implementation; leave the labels unchanged
311314

312315
### Issue without a review
313316

0 commit comments

Comments
 (0)