Repository navigation
Commit df7317d
committed
refactor(sdk)!: make wait_ready succeed only on Ready
wait_ready previously also returned Ok for a sandbox that reached
Completed. A caller waiting for a sandbox almost always needs a live one,
and the name suggests that, so a sandbox that completes before becoming
ready is now an error that fails fast, like Stopped, Error and the
suspended phases. This applies to the Rust SDK's OpenShellClient and
WorkspaceScopedClient and to the TypeScript SDK's waitReady, so the SDKs
agree. The Go SDK has moved to ai-openshell/sdk-go and gets the same change
there.
BREAKING CHANGE: Rust wait_ready and TypeScript waitReady return an error instead of the sandbox when it
reaches the Completed phase. Callers that need to wait for a finished
workload should poll the sandbox.
Signed-off-by: Evan Lezar <[email protected]>1 parent b0871a9 commit df7317d
2 files changed
Lines changed: 11 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1325 | 1325 | | |
1326 | 1326 | | |
1327 | 1327 | | |
1328 | | - | |
| 1328 | + | |
1329 | 1329 | | |
1330 | 1330 | | |
1331 | 1331 | | |
| |||
1334 | 1334 | | |
1335 | 1335 | | |
1336 | 1336 | | |
1337 | | - | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
1338 | 1341 | | |
1339 | 1342 | | |
1340 | 1343 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1341 | 1341 | | |
1342 | 1342 | | |
1343 | 1343 | | |
1344 | | - | |
| 1344 | + | |
| 1345 | + | |
1345 | 1346 | | |
1346 | 1347 | | |
1347 | 1348 | | |
| |||
1361 | 1362 | | |
1362 | 1363 | | |
1363 | 1364 | | |
1364 | | - | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
1365 | 1369 | | |
1366 | 1370 | | |
1367 | 1371 | | |
| |||
0 commit comments