Skip to content

Commit c6a92fa

Browse files
committed
fix(sandbox,podman): remove plain-HTTP upstream proxy support
The http_proxy path tunneled plain-HTTP requests through the corporate proxy with CONNECT to port 80 and then sent origin-form requests down the tunnel. Conventional enterprise forward proxies expect plain HTTP as absolute-form requests sent directly over the proxy connection, and commonly refuse CONNECT to port 80, so the setting looked supported but failed against typical deployments. Tunneling also blinds the proxy to the one protocol it could inspect. Narrow the feature to TLS (CONNECT) egress only, which is the conventional and already-correct case: plain-HTTP requests now always dial the destination directly, and only client CONNECT tunnels chain through the corporate proxy. Remove the http_proxy config field, the --sandbox-http-proxy / OPENSHELL_SANDBOX_HTTP_PROXY driver surface, the reserved OPENSHELL_UPSTREAM_HTTP_PROXY variable, and the UpstreamScheme plumbing. The feature never shipped, so this is a clean removal; a stray http_proxy key in gateway.toml still fails loudly through the config's deny_unknown_fields. Removing the plain-HTTP proxy branch also removes its host-gateway special case; the architecture doc now documents the real host-gateway behavior (add driver-injected host aliases to the reserved NO_PROXY list) instead of an invariant the HTTPS path never implemented. Plain-HTTP forwarding through a corporate proxy can return later as absolute-form forwarding behind its own design review. Addresses the plain-HTTP forwarding review item on #2245. Signed-off-by: Philippe Martin <[email protected]>
1 parent 1394b24 commit c6a92fa

11 files changed

Lines changed: 98 additions & 205 deletions

File tree

‎architecture/sandbox.md‎

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -103,21 +103,25 @@ handled by the inference interception path:
103103
External inference endpoints that do not use `inference.local` are treated like
104104
ordinary network traffic and must be allowed by policy.
105105

106-
In proxy-required networks, the supervisor chains the upstream dial through a
107-
corporate forward proxy with HTTP CONNECT instead of connecting directly, once
108-
policy and SSRF checks pass. The proxy configuration is an operator-owned
109-
boundary read from reserved `OPENSHELL_UPSTREAM_HTTPS_PROXY` /
110-
`OPENSHELL_UPSTREAM_HTTP_PROXY` / `OPENSHELL_UPSTREAM_NO_PROXY` variables that
111-
compute drivers write in their required-variable tier; sandbox and template
112-
environment cannot override them. The conventional `HTTPS_PROXY`/`HTTP_PROXY`/
113-
`NO_PROXY` variables a sandbox controls are ignored on this path. Reserved
114-
`NO_PROXY` destinations, loopback, and host-gateway aliases always dial
115-
directly. Only `http://` proxy URLs in `scheme://host:port` form are
116-
supported; a path, query, or fragment is rejected. Local DNS resolution and
117-
SSRF validation still run before the proxied dial; the CONNECT target sent to
118-
the corporate proxy is the requested hostname. The workload child's proxy
119-
variables are unaffected — they are always rewritten to point at the local
120-
policy proxy.
106+
In proxy-required networks, the supervisor chains upstream TLS tunnels through
107+
a corporate forward proxy with HTTP CONNECT instead of connecting directly,
108+
once policy and SSRF checks pass. Only TLS (CONNECT) egress is chained:
109+
plain-HTTP requests always dial the destination directly, because forwarding
110+
plain HTTP through a proxy requires absolute-form request forwarding rather
111+
than CONNECT tunneling and is out of scope. The proxy configuration is an
112+
operator-owned boundary read from reserved `OPENSHELL_UPSTREAM_HTTPS_PROXY` /
113+
`OPENSHELL_UPSTREAM_NO_PROXY` variables that compute drivers write in their
114+
required-variable tier; sandbox and template environment cannot override them.
115+
The conventional `HTTPS_PROXY`/`HTTP_PROXY`/`NO_PROXY` variables a sandbox
116+
controls are ignored on this path. Reserved `NO_PROXY` destinations and
117+
loopback always dial directly; add driver-injected host aliases (e.g.
118+
`host.containers.internal`) to the reserved `NO_PROXY` list when the corporate
119+
proxy cannot reach the container host. Only `http://` proxy URLs in
120+
`scheme://host:port` form are supported; a path, query, or fragment is
121+
rejected. Local DNS resolution and SSRF validation still run before the
122+
proxied dial; the CONNECT target sent to the corporate proxy is the requested
123+
hostname. The workload child's proxy variables are unaffected — they are
124+
always rewritten to point at the local policy proxy.
121125

122126
The configuration is fail-closed: a reserved variable that is present but
123127
invalid — a present-but-empty value, an unsupported or malformed proxy URL, an

‎crates/openshell-core/src/sandbox_env.rs‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,6 @@ pub const SANDBOX_GID: &str = "OPENSHELL_SANDBOX_GID";
126126
/// reserved for pointing the workload child at the local policy proxy.
127127
pub const UPSTREAM_HTTPS_PROXY: &str = "OPENSHELL_UPSTREAM_HTTPS_PROXY";
128128

129-
/// Corporate forward-proxy URL the supervisor uses for plain-HTTP egress.
130-
///
131-
/// Operator-owned counterpart to [`UPSTREAM_HTTPS_PROXY`]; see that constant
132-
/// for the trust-boundary rationale.
133-
pub const UPSTREAM_HTTP_PROXY: &str = "OPENSHELL_UPSTREAM_HTTP_PROXY";
134-
135129
/// Comma-separated `NO_PROXY`-style list of destinations the supervisor dials
136130
/// directly instead of chaining through the corporate proxy.
137131
///

‎crates/openshell-driver-podman/README.md‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -345,13 +345,12 @@ Podman resources after out-of-band container removal or label drift.
345345
| `OPENSHELL_PODMAN_TLS_CA` | `--podman-tls-ca` | unset | Host path to the CA certificate mounted for sandbox mTLS. |
346346
| `OPENSHELL_PODMAN_TLS_CERT` | `--podman-tls-cert` | unset | Host path to the client certificate mounted for sandbox mTLS. |
347347
| `OPENSHELL_PODMAN_TLS_KEY` | `--podman-tls-key` | unset | Host path to the client private key mounted for sandbox mTLS. |
348-
| `OPENSHELL_SANDBOX_HTTPS_PROXY` | `--sandbox-https-proxy` | unset | Corporate forward proxy URL for the supervisor's upstream TLS dials, chained with HTTP CONNECT. Only credential-free `http://` URLs are supported. |
349-
| `OPENSHELL_SANDBOX_HTTP_PROXY` | `--sandbox-http-proxy` | unset | Corporate forward proxy URL for plain HTTP requests. |
348+
| `OPENSHELL_SANDBOX_HTTPS_PROXY` | `--sandbox-https-proxy` | unset | Corporate forward proxy URL for the supervisor's upstream TLS dials, chained with HTTP CONNECT. Only credential-free `http://` URLs are supported. Plain-HTTP requests always dial directly. |
350349
| `OPENSHELL_SANDBOX_NO_PROXY` | `--sandbox-no-proxy` | unset | Comma-separated `NO_PROXY` list (hostnames, domain suffixes, IPs, CIDRs) dialed directly instead of through the corporate proxy. |
351350
| `OPENSHELL_SANDBOX_PROXY_AUTH_FILE` | `--sandbox-proxy-auth-file` | unset | Path to a file containing the proxy credentials as `user:pass`. Staged as a root-only Podman secret so credentials never appear in config or container metadata. |
352351

353-
Through the gateway, the same settings are the `https_proxy`, `http_proxy`,
354-
`no_proxy`, and `proxy_auth_file` keys under `[openshell.drivers.podman]`; see
352+
Through the gateway, the same settings are the `https_proxy`, `no_proxy`, and
353+
`proxy_auth_file` keys under `[openshell.drivers.podman]`; see
355354
`docs/reference/gateway-config.mdx`.
356355

357356
This is an operator-owned egress boundary: the supervisor reads it from reserved

‎crates/openshell-driver-podman/src/config.rs‎

Lines changed: 14 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ pub struct PodmanComputeConfig {
145145
/// required-variable tier so sandbox/template environment cannot override
146146
/// it, and the conventional `HTTPS_PROXY` variables are not used.
147147
pub https_proxy: Option<String>,
148-
/// Corporate forward proxy URL injected as the reserved
149-
/// `OPENSHELL_UPSTREAM_HTTP_PROXY` variable, used for plain HTTP requests.
150-
/// See `https_proxy`.
151-
pub http_proxy: Option<String>,
152148
/// Comma-separated `NO_PROXY` list injected as the reserved
153149
/// `OPENSHELL_UPSTREAM_NO_PROXY` variable (e.g.
154150
/// `*.svc.cluster.local,10.0.0.0/8`). Destinations matching an entry are
@@ -158,7 +154,7 @@ pub struct PodmanComputeConfig {
158154
/// credentials as `user:pass`.
159155
///
160156
/// Credentials must be supplied through this file, never embedded in the
161-
/// proxy URL: an inline `user:pass@` in `https_proxy`/`http_proxy` is
157+
/// proxy URL: an inline `user:pass@` in `https_proxy` is
162158
/// rejected at startup because it would leak into `gateway.toml` and
163159
/// container metadata. The gateway reads this file at sandbox-create time
164160
/// and delivers it to the supervisor through a root-only secret mount.
@@ -231,21 +227,18 @@ impl PodmanComputeConfig {
231227
/// container metadata.
232228
pub fn validate_proxy_config(&self) -> Result<(), crate::client::PodmanApiError> {
233229
use openshell_core::driver_utils::{UpstreamProxyUrlError, parse_upstream_proxy_url};
234-
for (field, value) in [
235-
("https_proxy", &self.https_proxy),
236-
("http_proxy", &self.http_proxy),
237-
] {
238-
let Some(url) = value else { continue };
230+
if let Some(url) = &self.https_proxy {
239231
parse_upstream_proxy_url(url).map_err(|err| {
240232
crate::client::PodmanApiError::InvalidInput(match err {
241233
UpstreamProxyUrlError::Empty => {
242-
format!("{field} must not be empty when set")
234+
"https_proxy must not be empty when set".to_string()
243235
}
244-
UpstreamProxyUrlError::InlineCredentials => format!(
245-
"{field} must not embed credentials in the URL; supply them via \
236+
UpstreamProxyUrlError::InlineCredentials => {
237+
"https_proxy must not embed credentials in the URL; supply them via \
246238
proxy_auth_file so they are not stored in config or container metadata"
247-
),
248-
err => format!("{field} {err}"),
239+
.to_string()
240+
}
241+
err => format!("https_proxy {err}"),
249242
})
250243
})?;
251244
}
@@ -261,9 +254,9 @@ impl PodmanComputeConfig {
261254
// A bypass list only makes sense relative to a proxy boundary. An
262255
// operator who set one believed proxying was in effect, so accepting
263256
// it while all egress dials directly would hide a fail-open state.
264-
if self.https_proxy.is_none() && self.http_proxy.is_none() {
257+
if self.https_proxy.is_none() {
265258
return Err(crate::client::PodmanApiError::InvalidInput(
266-
"no_proxy is set but no https_proxy/http_proxy is configured".to_string(),
259+
"no_proxy is set but no https_proxy is configured".to_string(),
267260
));
268261
}
269262
}
@@ -274,10 +267,9 @@ impl PodmanComputeConfig {
274267
"proxy_auth_file must not be empty when set".to_string(),
275268
));
276269
}
277-
if self.https_proxy.is_none() && self.http_proxy.is_none() {
270+
if self.https_proxy.is_none() {
278271
return Err(crate::client::PodmanApiError::InvalidInput(
279-
"proxy_auth_file is set but no https_proxy/http_proxy is configured"
280-
.to_string(),
272+
"proxy_auth_file is set but no https_proxy is configured".to_string(),
281273
));
282274
}
283275
}
@@ -358,7 +350,6 @@ impl Default for PodmanComputeConfig {
358350
enable_bind_mounts: false,
359351
health_check_interval_secs: DEFAULT_HEALTH_CHECK_INTERVAL_SECS,
360352
https_proxy: None,
361-
http_proxy: None,
362353
no_proxy: None,
363354
proxy_auth_file: None,
364355
}
@@ -389,7 +380,6 @@ impl std::fmt::Debug for PodmanComputeConfig {
389380
)
390381
// Proxy URLs may embed credentials in userinfo; log presence only.
391382
.field("https_proxy", &self.https_proxy.is_some())
392-
.field("http_proxy", &self.http_proxy.is_some())
393383
.field("no_proxy", &self.no_proxy)
394384
.field("proxy_auth_file", &self.proxy_auth_file.is_some())
395385
.finish()
@@ -512,7 +502,6 @@ mod tests {
512502
);
513503
let cfg = PodmanComputeConfig {
514504
https_proxy: Some("http://proxy.corp.com:8080".to_string()),
515-
http_proxy: Some("proxy.corp.com:3128".to_string()),
516505
no_proxy: Some("*.svc.cluster.local".to_string()),
517506
..PodmanComputeConfig::default()
518507
};
@@ -556,11 +545,11 @@ mod tests {
556545
#[test]
557546
fn validate_proxy_config_rejects_empty_value() {
558547
let cfg = PodmanComputeConfig {
559-
http_proxy: Some(" ".to_string()),
548+
https_proxy: Some(" ".to_string()),
560549
..PodmanComputeConfig::default()
561550
};
562551
let err = cfg.validate_proxy_config().unwrap_err();
563-
assert!(err.to_string().contains("http_proxy"), "{err}");
552+
assert!(err.to_string().contains("https_proxy"), "{err}");
564553
}
565554

566555
#[test]

‎crates/openshell-driver-podman/src/container.rs‎

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -421,10 +421,6 @@ fn build_env(
421421
openshell_core::sandbox_env::UPSTREAM_HTTPS_PROXY,
422422
&config.https_proxy,
423423
),
424-
(
425-
openshell_core::sandbox_env::UPSTREAM_HTTP_PROXY,
426-
&config.http_proxy,
427-
),
428424
(
429425
openshell_core::sandbox_env::UPSTREAM_NO_PROXY,
430426
&config.no_proxy,
@@ -1719,14 +1715,11 @@ mod tests {
17191715

17201716
#[test]
17211717
fn container_spec_injects_operator_proxy_env() {
1722-
use openshell_core::sandbox_env::{
1723-
UPSTREAM_HTTP_PROXY, UPSTREAM_HTTPS_PROXY, UPSTREAM_NO_PROXY,
1724-
};
1718+
use openshell_core::sandbox_env::{UPSTREAM_HTTPS_PROXY, UPSTREAM_NO_PROXY};
17251719

17261720
let sandbox = test_sandbox("test-id", "test-name");
17271721
let mut config = test_config();
17281722
config.https_proxy = Some("http://proxy.corp.com:8080".to_string());
1729-
config.http_proxy = Some("http://proxy.corp.com:3128".to_string());
17301723
config.no_proxy = Some("*.svc.cluster.local,10.0.0.0/8".to_string());
17311724

17321725
let spec = build_container_spec(&sandbox, &config);
@@ -1737,11 +1730,6 @@ mod tests {
17371730
Some("http://proxy.corp.com:8080"),
17381731
"reserved upstream HTTPS var should carry the operator proxy URL"
17391732
);
1740-
assert_eq!(
1741-
env_map.get(UPSTREAM_HTTP_PROXY).and_then(|v| v.as_str()),
1742-
Some("http://proxy.corp.com:3128"),
1743-
"reserved upstream HTTP var should carry the operator proxy URL"
1744-
);
17451733
assert_eq!(
17461734
env_map.get(UPSTREAM_NO_PROXY).and_then(|v| v.as_str()),
17471735
Some("*.svc.cluster.local,10.0.0.0/8"),
@@ -1760,15 +1748,13 @@ mod tests {
17601748

17611749
#[test]
17621750
fn container_spec_omits_proxy_env_when_unconfigured() {
1763-
use openshell_core::sandbox_env::{
1764-
UPSTREAM_HTTP_PROXY, UPSTREAM_HTTPS_PROXY, UPSTREAM_NO_PROXY,
1765-
};
1751+
use openshell_core::sandbox_env::{UPSTREAM_HTTPS_PROXY, UPSTREAM_NO_PROXY};
17661752

17671753
let sandbox = test_sandbox("test-id", "test-name");
17681754
let spec = build_container_spec(&sandbox, &test_config());
17691755
let env_map = spec["env"].as_object().expect("env should be an object");
17701756

1771-
for key in [UPSTREAM_HTTPS_PROXY, UPSTREAM_HTTP_PROXY, UPSTREAM_NO_PROXY] {
1757+
for key in [UPSTREAM_HTTPS_PROXY, UPSTREAM_NO_PROXY] {
17721758
assert!(
17731759
!env_map.contains_key(key),
17741760
"{key} should be absent without operator proxy config"

‎crates/openshell-driver-podman/src/main.rs‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,7 @@ struct Args {
110110
#[arg(long, env = "OPENSHELL_SANDBOX_HTTPS_PROXY")]
111111
sandbox_https_proxy: Option<String>,
112112

113-
/// Corporate forward proxy URL for plain HTTP (http:// only). Credentials
114-
/// must not be embedded in the URL; use `--sandbox-proxy-auth-file`.
115-
#[arg(long, env = "OPENSHELL_SANDBOX_HTTP_PROXY")]
116-
sandbox_http_proxy: Option<String>,
117-
118-
/// Comma-separated `NO_PROXY` list injected alongside the proxy URLs.
113+
/// Comma-separated `NO_PROXY` list injected alongside the proxy URL.
119114
#[arg(long, env = "OPENSHELL_SANDBOX_NO_PROXY")]
120115
sandbox_no_proxy: Option<String>,
121116

@@ -159,7 +154,6 @@ async fn main() -> Result<()> {
159154
guest_tls_key: args.podman_tls_key,
160155
sandbox_pids_limit: args.sandbox_pids_limit,
161156
https_proxy: args.sandbox_https_proxy,
162-
http_proxy: args.sandbox_http_proxy,
163157
no_proxy: args.sandbox_no_proxy,
164158
proxy_auth_file: args.sandbox_proxy_auth_file,
165159
..PodmanComputeConfig::default()

‎crates/openshell-supervisor-network/src/proxy.rs‎

Lines changed: 13 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use crate::identity::BinaryIdentityCache;
77
use crate::l7::tls::ProxyTlsState;
88
use crate::opa::{NetworkAction, OpaEngine, PolicyGenerationGuard};
99
use crate::policy_local::{POLICY_LOCAL_HOST, PolicyLocalContext};
10-
use crate::upstream_proxy::{self, UpstreamProxyConfig, UpstreamScheme};
10+
use crate::upstream_proxy::{self, UpstreamProxyConfig};
1111
use miette::{IntoDiagnostic, Result};
1212
use openshell_core::activity::{ActivitySender, try_record_activity};
1313
use openshell_core::denial::DenialEvent;
@@ -738,7 +738,6 @@ async fn handle_tcp_connection(
738738
entrypoint_pid,
739739
policy_local_ctx,
740740
trusted_host_gateway,
741-
upstream_proxy,
742741
secret_resolver,
743742
dynamic_credentials,
744743
denial_tx.as_ref(),
@@ -1213,15 +1212,9 @@ async fn handle_tcp_connection(
12131212
return Ok(());
12141213
}
12151214

1216-
let mut upstream = dial_upstream(
1217-
&upstream_proxy,
1218-
UpstreamScheme::Https,
1219-
&host_lc,
1220-
port,
1221-
&validated_addrs,
1222-
)
1223-
.await
1224-
.into_diagnostic()?;
1215+
let mut upstream = dial_upstream(&upstream_proxy, &host_lc, port, &validated_addrs)
1216+
.await
1217+
.into_diagnostic()?;
12251218

12261219
debug!(
12271220
"handle_tcp_connection dns_resolve_and_tcp_connect: {}ms host={host_lc}",
@@ -2947,28 +2940,28 @@ fn validate_declared_endpoint_resolved_addrs(
29472940
Ok(())
29482941
}
29492942

2950-
/// Dial a validated upstream destination.
2943+
/// Dial a validated upstream destination for a TLS (CONNECT) tunnel.
29512944
///
29522945
/// Connects directly to the SSRF-checked resolved addresses, or chains
29532946
/// through the corporate proxy (HTTP CONNECT) when one is configured for
29542947
/// this destination via the supervisor's reserved upstream proxy variables
29552948
/// and not excluded by the reserved `NO_PROXY` list. Policy evaluation and
29562949
/// SSRF validation must have already succeeded; only the final TCP dial
2957-
/// changes.
2950+
/// changes. Plain-HTTP requests never take this path: they always dial the
2951+
/// destination directly.
29582952
///
29592953
/// The CONNECT target sent to the corporate proxy is the client-requested
29602954
/// hostname, so hostname-filtering proxies and split-horizon DNS at the
29612955
/// proxy keep working.
29622956
async fn dial_upstream(
29632957
upstream_proxy: &Option<UpstreamProxyConfig>,
2964-
scheme: UpstreamScheme,
29652958
host_lc: &str,
29662959
port: u16,
29672960
addrs: &[SocketAddr],
29682961
) -> std::io::Result<TcpStream> {
29692962
if let Some(endpoint) = upstream_proxy
29702963
.as_ref()
2971-
.and_then(|cfg| cfg.proxy_for(scheme, host_lc))
2964+
.and_then(|cfg| cfg.proxy_for(host_lc))
29722965
{
29732966
return upstream_proxy::connect_via(endpoint, host_lc, port).await;
29742967
}
@@ -3614,7 +3607,6 @@ async fn handle_forward_proxy(
36143607
entrypoint_pid: Arc<AtomicU32>,
36153608
policy_local_ctx: Option<Arc<PolicyLocalContext>>,
36163609
trusted_host_gateway: Arc<Option<IpAddr>>,
3617-
upstream_proxy: Arc<Option<UpstreamProxyConfig>>,
36183610
secret_resolver: Option<Arc<SecretResolver>>,
36193611
dynamic_credentials: Option<
36203612
Arc<
@@ -4648,20 +4640,11 @@ async fn handle_forward_proxy(
46484640
return Ok(());
46494641
}
46504642

4651-
// 6. Connect upstream. Host-gateway aliases always dial directly — the
4652-
// corporate proxy cannot reach the driver-injected host gateway.
4653-
let dial_result = if is_host_gateway_alias(&host_lc) {
4654-
TcpStream::connect(addrs.as_slice()).await
4655-
} else {
4656-
dial_upstream(
4657-
&upstream_proxy,
4658-
UpstreamScheme::Http,
4659-
&host_lc,
4660-
port,
4661-
&addrs,
4662-
)
4663-
.await
4664-
};
4643+
// 6. Connect upstream. Plain-HTTP requests always dial the destination
4644+
// directly: only TLS (CONNECT) tunnels chain through the corporate
4645+
// proxy, since plain-HTTP forwarding would need absolute-form requests
4646+
// rather than a CONNECT tunnel.
4647+
let dial_result = TcpStream::connect(addrs.as_slice()).await;
46654648
let mut upstream = match dial_result {
46664649
Ok(s) => s,
46674650
Err(e) => {

0 commit comments

Comments
 (0)