You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c6a92fa
Browse filesBrowse the repository at this point in the historyBrowse files
fix(sandbox,podman): remove plain-HTTP upstream proxy support
The http_proxy path tunneled plain-HTTP requests through the corporate
proxy with CONNECT to port 80 and then sent origin-form requests down
the tunnel. Conventional enterprise forward proxies expect plain HTTP
as absolute-form requests sent directly over the proxy connection, and
commonly refuse CONNECT to port 80, so the setting looked supported but
failed against typical deployments. Tunneling also blinds the proxy to
the one protocol it could inspect.
Narrow the feature to TLS (CONNECT) egress only, which is the
conventional and already-correct case: plain-HTTP requests now always
dial the destination directly, and only client CONNECT tunnels chain
through the corporate proxy. Remove the http_proxy config field, the
--sandbox-http-proxy / OPENSHELL_SANDBOX_HTTP_PROXY driver surface, the
reserved OPENSHELL_UPSTREAM_HTTP_PROXY variable, and the UpstreamScheme
plumbing. The feature never shipped, so this is a clean removal; a
stray http_proxy key in gateway.toml still fails loudly through the
config's deny_unknown_fields.
Removing the plain-HTTP proxy branch also removes its host-gateway
special case; the architecture doc now documents the real host-gateway
behavior (add driver-injected host aliases to the reserved NO_PROXY
list) instead of an invariant the HTTPS path never implemented.
Plain-HTTP forwarding through a corporate proxy can return later as
absolute-form forwarding behind its own design review.
Addresses the plain-HTTP forwarding review item on #2245.
Signed-off-by: Philippe Martin <[email protected]>
Copy file name to clipboardExpand all lines: architecture/sandbox.md
+19-15Lines changed: 19 additions & 15 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -103,21 +103,25 @@ handled by the inference interception path:
103
103
External inference endpoints that do not use `inference.local` are treated like
104
104
ordinary network traffic and must be allowed by policy.
105
105
106
-
In proxy-required networks, the supervisor chains the upstream dial through a
107
-
corporate forward proxy with HTTP CONNECT instead of connecting directly, once
108
-
policy and SSRF checks pass. The proxy configuration is an operator-owned
109
-
boundary read from reserved `OPENSHELL_UPSTREAM_HTTPS_PROXY` /
110
-
`OPENSHELL_UPSTREAM_HTTP_PROXY` / `OPENSHELL_UPSTREAM_NO_PROXY` variables that
111
-
compute drivers write in their required-variable tier; sandbox and template
112
-
environment cannot override them. The conventional `HTTPS_PROXY`/`HTTP_PROXY`/
113
-
`NO_PROXY` variables a sandbox controls are ignored on this path. Reserved
114
-
`NO_PROXY` destinations, loopback, and host-gateway aliases always dial
115
-
directly. Only `http://` proxy URLs in `scheme://host:port` form are
116
-
supported; a path, query, or fragment is rejected. Local DNS resolution and
117
-
SSRF validation still run before the proxied dial; the CONNECT target sent to
118
-
the corporate proxy is the requested hostname. The workload child's proxy
119
-
variables are unaffected — they are always rewritten to point at the local
120
-
policy proxy.
106
+
In proxy-required networks, the supervisor chains upstream TLS tunnels through
107
+
a corporate forward proxy with HTTP CONNECT instead of connecting directly,
108
+
once policy and SSRF checks pass. Only TLS (CONNECT) egress is chained:
109
+
plain-HTTP requests always dial the destination directly, because forwarding
110
+
plain HTTP through a proxy requires absolute-form request forwarding rather
111
+
than CONNECT tunneling and is out of scope. The proxy configuration is an
112
+
operator-owned boundary read from reserved `OPENSHELL_UPSTREAM_HTTPS_PROXY` /
113
+
`OPENSHELL_UPSTREAM_NO_PROXY` variables that compute drivers write in their
114
+
required-variable tier; sandbox and template environment cannot override them.
115
+
The conventional `HTTPS_PROXY`/`HTTP_PROXY`/`NO_PROXY` variables a sandbox
116
+
controls are ignored on this path. Reserved `NO_PROXY` destinations and
`host.containers.internal`) to the reserved `NO_PROXY` list when the corporate
119
+
proxy cannot reach the container host. Only `http://` proxy URLs in
120
+
`scheme://host:port` form are supported; a path, query, or fragment is
121
+
rejected. Local DNS resolution and SSRF validation still run before the
122
+
proxied dial; the CONNECT target sent to the corporate proxy is the requested
123
+
hostname. The workload child's proxy variables are unaffected — they are
124
+
always rewritten to point at the local policy proxy.
121
125
122
126
The configuration is fail-closed: a reserved variable that is present but
123
127
invalid — a present-but-empty value, an unsupported or malformed proxy URL, an
Copy file name to clipboardExpand all lines: crates/openshell-driver-podman/README.md
+3-4Lines changed: 3 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -345,13 +345,12 @@ Podman resources after out-of-band container removal or label drift.
345
345
|`OPENSHELL_PODMAN_TLS_CA`|`--podman-tls-ca`| unset | Host path to the CA certificate mounted for sandbox mTLS. |
346
346
|`OPENSHELL_PODMAN_TLS_CERT`|`--podman-tls-cert`| unset | Host path to the client certificate mounted for sandbox mTLS. |
347
347
|`OPENSHELL_PODMAN_TLS_KEY`|`--podman-tls-key`| unset | Host path to the client private key mounted for sandbox mTLS. |
348
-
|`OPENSHELL_SANDBOX_HTTPS_PROXY`|`--sandbox-https-proxy`| unset | Corporate forward proxy URL for the supervisor's upstream TLS dials, chained with HTTP CONNECT. Only credential-free `http://` URLs are supported. |
|`OPENSHELL_SANDBOX_HTTPS_PROXY`|`--sandbox-https-proxy`| unset | Corporate forward proxy URL for the supervisor's upstream TLS dials, chained with HTTP CONNECT. Only credential-free `http://` URLs are supported. Plain-HTTP requests always dial directly. |
350
349
|`OPENSHELL_SANDBOX_NO_PROXY`|`--sandbox-no-proxy`| unset | Comma-separated `NO_PROXY` list (hostnames, domain suffixes, IPs, CIDRs) dialed directly instead of through the corporate proxy. |
351
350
|`OPENSHELL_SANDBOX_PROXY_AUTH_FILE`|`--sandbox-proxy-auth-file`| unset | Path to a file containing the proxy credentials as `user:pass`. Staged as a root-only Podman secret so credentials never appear in config or container metadata. |
352
351
353
-
Through the gateway, the same settings are the `https_proxy`, `http_proxy`,
354
-
`no_proxy`, and `proxy_auth_file` keys under `[openshell.drivers.podman]`; see
352
+
Through the gateway, the same settings are the `https_proxy`, `no_proxy`, and
353
+
`proxy_auth_file` keys under `[openshell.drivers.podman]`; see
355
354
`docs/reference/gateway-config.mdx`.
356
355
357
356
This is an operator-owned egress boundary: the supervisor reads it from reserved
0 commit comments