Skip to content

Commit c49bcaa

Browse files
politerealismpoliterealism
committed
test(conformance): migrate settings_management to the conformance suite
Port sandbox/global settings precedence, override, and delete-semantics coverage from e2e/rust/tests/settings_management.rs into a new settings-management scenario under tests/suites/conformance/, following the OpenShellRunner/Scenario pattern. Matches the RFC's own "Settings" conformance area (read/change/remove settings through public APIs; global overrides take precedence and prevent conflicting sandbox changes). "ocsf_json_enabled" is a fixed, recognized settings key rather than a name this scenario can scope per run, so it keeps the original's hard-asserted pre-cleanup and best-effort post-cleanup around it instead of per-run tracked resource names. Remove the old per-driver test file (no Cargo.toml or artifacts.nix entries; picked up by Cargo's default test auto-discovery). Verified against an ephemeral Podman gateway. Signed-off-by: politerealism <[email protected]>
1 parent 617b8bc commit c49bcaa

5 files changed

Lines changed: 447 additions & 331 deletions

File tree

‎crates/openshell-conformance/src/lib.rs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ pub use scenarios::{
3030
PROVIDER_AUTO_CREATE_SCENARIO, SANDBOX_LIFECYCLE_SCENARIO,
3131
SANDBOX_TEMPLATE_DUPLICATE_NAME_SCENARIO, SANDBOX_TEMPLATE_GET_AFTER_DELETE_SCENARIO,
3232
SANDBOX_TEMPLATE_LIFECYCLE_SCENARIO, SANDBOX_TEMPLATE_MISSING_TEMPLATE_SCENARIO,
33-
SANDBOX_TEMPLATES_SCENARIO, SMOKE_SCENARIO, WORKSPACE_LIFECYCLE_SCENARIO,
34-
WORKSPACE_TERMINATING_SCENARIO,
33+
SANDBOX_TEMPLATES_SCENARIO, SETTINGS_MANAGEMENT_SCENARIO, SMOKE_SCENARIO,
34+
WORKSPACE_LIFECYCLE_SCENARIO, WORKSPACE_TERMINATING_SCENARIO,
3535
};
3636

3737
/// An installed conformance scenario.
@@ -59,6 +59,7 @@ const SCENARIOS: &[Scenario] = &[
5959
POLICY_LOCAL_SCENARIO,
6060
PROVIDER_AUTO_CREATE_SCENARIO,
6161
SANDBOX_TEMPLATES_SCENARIO,
62+
SETTINGS_MANAGEMENT_SCENARIO,
6263
WORKSPACE_LIFECYCLE_SCENARIO,
6364
WORKSPACE_TERMINATING_SCENARIO,
6465
];

‎crates/openshell-conformance/src/scenarios/mod.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ mod policy_behavior;
88
mod provider_auto_create;
99
mod sandbox_lifecycle;
1010
mod sandbox_templates;
11+
mod settings_management;
1112
mod smoke;
1213
mod workspace_lifecycle;
1314

@@ -25,5 +26,6 @@ pub use sandbox_templates::{
2526
SANDBOX_TEMPLATE_LIFECYCLE_SCENARIO, SANDBOX_TEMPLATE_MISSING_TEMPLATE_SCENARIO,
2627
SANDBOX_TEMPLATES_SCENARIO,
2728
};
29+
pub use settings_management::SETTINGS_MANAGEMENT_SCENARIO;
2830
pub use smoke::SMOKE_SCENARIO;
2931
pub use workspace_lifecycle::{WORKSPACE_LIFECYCLE_SCENARIO, WORKSPACE_TERMINATING_SCENARIO};

0 commit comments

Comments
 (0)