Skip to content

Commit c4492ba

Browse files
committed
Merge remote-tracking branch 'upstream/main' into fix/server-atomic-replay-boundary
2 parents 6d39167 + af02016 commit c4492ba

1,429 files changed

Lines changed: 528650 additions & 93237 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
---
2+
name: apply-triage-action
3+
description: Apply, reject, or defer exactly one issue or CI recommendation from a local triage queue report. Use when the on-duty engineer explicitly supplies an item ID.
4+
metadata:
5+
internal: true
6+
---
7+
8+
# Apply Triage Action
9+
10+
Process exactly one item ID from a queue-review report. Do not accept a natural-language approval without an ID. PRs are informational in v1.
11+
12+
## Locate and validate
13+
14+
1. Read the checkpoint and action records under `.agents/triage-duty/`; reconcile dispositions using the [local-state rules](../review-triage-queue/SKILL.md#local-state).
15+
2. Use the named report, or the latest report containing the ID. Read the recommendation and current disposition. Material changes to a previously selected recommendation require fresh review and selection.
16+
3. Reject missing, superseded, already-final, or ambiguous recommendations without making a write. Never substitute another item.
17+
4. Append every explicit disposition or attempted action to a dated local action record. Record repository, target, source report, ID, timestamp, disposition, reason, confirmed payload, and outcome; update the checkpoint afterward. Keep sensitive content out of the record; use `private reason withheld` for private reasons.
18+
19+
## Reject or defer
20+
21+
For **reject** or **defer**, require the engineer to give a reason. Record the local disposition.
22+
23+
- **Reject** is terminal locally. Do not recommend the item again unless material new evidence changes the case.
24+
- **Defer** is non-terminal. Preserve its original priority and carry it into the next review's carried **Needs your decision** section.
25+
26+
For shareable deferrals, draft a GitHub issue comment with reason, public links, and next step, or link existing waiting context. Use the confirmation rule below; declined posting leaves a local-only deferral. Keep private reasons out of external payloads and committable files. For missing reporter evidence, also propose the awaiting-information assessment state using `triage-issue`; unrelated dependency waits do not change lifecycle labels.
27+
28+
## Apply
29+
30+
Before any external write, re-read the target and determine whether it materially changed. Follow [Label Discovery](../../../CONTRIBUTING.md#label-discovery), retrieving all pages of current definitions before proposing a label change; use [`triage-issue`](../triage-issue/SKILL.md) for assessment states and maintainer authority.
31+
32+
- If the action is already complete or would be a harmless no-op, make no external write and record the reason.
33+
- If new information makes the action unsafe or substantially different, stop and request a fresh review/selection.
34+
35+
You MUST ALWAYS preview the exact payload, item ID, source report, and canonical target, then receive explicit confirmation for each individual external write. Selecting or deferring an item is not confirmation; comments, label changes, and closures require separate confirmations. Revalidate immediately before execution; changed payloads require a new preview and confirmation. Never reuse confirmation for a later invocation.
36+
37+
After confirmation, perform only the approved action and record its outcome and public URL; mark applied only after success.
38+
39+
Supported v1 actions:
40+
41+
- Add the discovered triage-queue label to an open substantive community issue; recheck the [intake eligibility rules](../review-triage-queue/SKILL.md#gather-intake) and exclude duplicates, spam, and security disclosures.
42+
- Create one GitHub issue using [`create-github-issue`](../create-github-issue/SKILL.md).
43+
- Post one public issue comment, including waiting context or a duplicate explanation.
44+
- Change an issue's assessment state to awaiting information.
45+
- Close one issue with an evidenced reason; identify the canonical issue for duplicates.
46+
47+
Never create a public GitHub issue for a security finding. Follow [SECURITY.md](../../../SECURITY.md).

‎.agents/skills/build-from-issue/SKILL.md‎

Lines changed: 19 additions & 741 deletions
Large diffs are not rendered by default.

‎.agents/skills/build-openshell-mxc-windows/SKILL.md‎

Lines changed: 252 additions & 22 deletions
Large diffs are not rendered by default.

‎.agents/skills/build-openshell-mxc-windows/reference.md‎

Lines changed: 33 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Reference: Windows MSVC maintenance lane
22

33
Companion to [SKILL.md](SKILL.md). Use this file for quick lookup while
4-
maintaining the existing build-only Windows MSVC lane.
4+
maintaining the native Windows MSVC and MXC runtime lane on the
5+
[`windows` development and release branch](https://github.com/NVIDIA/OpenShell/tree/windows).
6+
Run the commands below from that branch or a branch based on it, including
7+
when reading this reference on `main`.
58

69
## Lane Files
710

@@ -33,15 +36,35 @@ For host-native full validation, detect architecture first:
3336
$arch = [System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture
3437
if ($arch -eq [System.Runtime.InteropServices.Architecture]::Arm64) {
3538
mise run --skip-tools windows:check:arm64
39+
if ($LASTEXITCODE -ne 0) { throw "windows:check:arm64 failed." }
3640
mise run --skip-tools windows:build:arm64
41+
if ($LASTEXITCODE -ne 0) { throw "windows:build:arm64 failed." }
3742
mise run --skip-tools windows:test:arm64
43+
if ($LASTEXITCODE -ne 0) { throw "windows:test:arm64 failed." }
3844
mise run --skip-tools windows:test:unsupported:arm64
45+
if ($LASTEXITCODE -ne 0) { throw "windows:test:unsupported:arm64 failed." }
46+
mise run --skip-tools windows:test:mxc-real:arm64
47+
if ($LASTEXITCODE -ne 0) { throw "windows:test:mxc-real:arm64 failed." }
3948
mise run --skip-tools windows:artifacts
49+
if ($LASTEXITCODE -ne 0) { throw "windows:artifacts failed." }
50+
mise run --skip-tools windows:e2e:mxc
51+
if ($LASTEXITCODE -ne 0) { throw "MXC E2E validation failed or was incomplete." }
4052
} else {
4153
mise run --skip-tools windows:ci
54+
if ($LASTEXITCODE -ne 0) { throw "windows:ci failed." }
55+
mise run --skip-tools windows:test:mxc-real:x64
56+
if ($LASTEXITCODE -ne 0) { throw "windows:test:mxc-real:x64 failed." }
57+
mise run --skip-tools windows:e2e:mxc
58+
if ($LASTEXITCODE -ne 0) { throw "MXC E2E validation failed or was incomplete." }
4259
}
4360
```
4461

62+
`windows:ci` does not include the real MXC runtime tests or E2E. Run the matching
63+
`windows:test:mxc-real:*` task and `windows:e2e:mxc` explicitly.
64+
These tasks can report `SKIP` when the executor or backend is unavailable;
65+
full validation requires an MXC-capable host. E2E exits nonzero when any
66+
required runtime scenario fails or skips.
67+
4568
The native test tasks reject a target that does not match the host architecture.
4669
Do not report x64 compatibility-under-emulation coverage from an ARM64 run.
4770

@@ -75,7 +98,7 @@ Ninja to `PATH`, while the crypto crates select `clang-cl`. Use a short
7598

7699
## Unsupported Driver Rules
77100

78-
Windows is a build target only. These runtimes remain unsupported:
101+
These Windows runtimes remain unsupported:
79102

80103
- Docker
81104
- Kubernetes
@@ -111,19 +134,20 @@ top-level workspace targets for check/test:
111134
--exclude openshell-driver-vault
112135
--exclude openshell-driver-vm
113136
--exclude openshell-sandbox
114-
--exclude openshell-supervisor
115-
--exclude openshell-supervisor-process
116137
--exclude openshell-vfio
117138
```
118139

119140
The gateway keeps platform configuration and unsupported-operation contracts
120-
without depending on the Docker, Kubernetes, Podman, sandbox runtime,
121-
standalone supervisor, supervisor process runtime, VM, or VFIO crates. The MXC
122-
driver does depend on the cross-platform supervisor network library for its host
123-
egress proxy. The Kubernetes Secrets and Vault libraries still compile as
124-
gateway dependencies; only their standalone Unix-socket binaries and
141+
without depending on the Docker, Kubernetes, Podman, VM, or VFIO runtime crates.
142+
The MXC runtime compiles the supervisor, supervisor-process library, and sandbox
143+
boundary on Windows. The Kubernetes Secrets and Vault libraries still compile
144+
as gateway dependencies; only their standalone Unix-socket binaries and
125145
package-level tests are excluded as top-level targets.
126146

147+
The supervisor and supervisor-process packages now participate as top-level
148+
native check/test targets. Their portable session, attachment, and TCP readiness
149+
coverage does not enable a Windows isolation runtime.
150+
127151
## Common Errors
128152

129153
### Unix imports leak into Windows builds

‎.agents/skills/create-github-issue/SKILL.md‎

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ This project uses YAML form issue templates. When creating issues, match the tem
1919

2020
### Bug Reports
2121

22-
Do not add a type label automatically. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, and **Acceptance Criteria**, followed by bug-specific reproduction steps and environment details. Logs are optional and must be concise and redacted. Apply area or topic labels only when they are clearly known.
22+
Do not add a type label automatically. Confirm that the human operator personally uses OpenShell and directly encountered the problem or needs the feature for a specific use case. If that first-hand attestation or concrete use case is missing, ask for it before creating the issue. Frame the issue entirely in terms of OpenShell. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, and **Acceptance Criteria**, followed by bug-specific reproduction steps using only OpenShell deployments and environment details. Do not install third-party tools to demonstrate reproducibility. Logs are optional and must be concise and redacted. If the issue suggests a change to configuration, CLI, SDK, or other user experience, include a notional example of the proposed interaction for human review. Inspect current repository labels before applying any; use only labels whose meaning is clear.
2323

2424
```bash
2525
gh issue create \
2626
--title "bug: <concise description>" \
2727
--body "$(cat <<'EOF'
2828
## User Story
2929
30-
As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
30+
I use OpenShell for <specific use case>. I directly encountered or need <specific behavior> so that <outcome>.
3131
3232
## Problem Statement
3333
@@ -52,26 +52,28 @@ As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
5252
- OS: <os>
5353
- Runtime, deployment, or integration: <relevant details>
5454
55+
## Suggested UX (if applicable)
56+
57+
<Notional OpenShell CLI, configuration, SDK, or other interaction>
58+
5559
## Logs
5660
57-
```
58-
<optional minimal, redacted output>
59-
```
61+
<Optional minimal, redacted output>
6062
EOF
6163
)"
6264
```
6365

6466
### Feature Requests
6567

66-
Do not add a type label automatically. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, **Proposed Design**, **Acceptance Criteria**, and **Alternatives Considered**. The proposed design should define the user-facing workflow and externally observable behavior without prescribing internal implementation. Agent investigation is optional. Apply area or topic labels only when they are clearly known.
68+
Do not add a type label automatically. Confirm that the human operator personally uses OpenShell and directly encountered the problem or needs the feature for a specific use case. If that first-hand attestation or concrete use case is missing, ask for it before creating the issue. Frame the issue entirely in terms of OpenShell. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, **Proposed Design**, **Acceptance Criteria**, and **Alternatives Considered**. The proposed design should define the user-facing workflow and externally observable behavior without prescribing internal implementation. Agent investigation is optional. If the issue suggests a change to configuration, CLI, SDK, or other user experience, include a notional example of the proposed interaction for human review. Inspect current repository labels before applying any; use only labels whose meaning is clear.
6769

6870
```bash
6971
gh issue create \
7072
--title "feat: <concise description>" \
7173
--body "$(cat <<'EOF'
7274
## User Story
7375
74-
As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
76+
I use OpenShell for <specific use case>. I directly encountered or need <specific behavior> so that <outcome>.
7577
7678
## Problem Statement
7779
@@ -85,13 +87,17 @@ As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
8587
8688
<The desired user-facing workflow and externally observable behavior, without prescribing internal implementation>
8789
90+
## Suggested UX (if applicable)
91+
92+
<Notional OpenShell CLI, configuration, SDK, or other interaction>
93+
8894
## Acceptance Criteria
8995
9096
- [ ] <specific, observable outcome>
9197
9298
## Alternatives Considered
9399
94-
<Other user-facing workflows or behaviors considered and why this approach best satisfies the user story>
100+
<Other OpenShell workflows considered, including relevant middleware, interceptors, providers, or other extension points, and why the proposal better serves the use case. Prefer an applicable extension when it satisfies the use case; running another service alone is not a reason to dismiss it.>
95101
96102
## Agent Investigation
97103
@@ -102,12 +108,16 @@ EOF
102108

103109
### Tasks
104110

105-
For internal tasks that don't fit bug/feature templates:
111+
For internal tasks that do not fit bug/feature templates, still obtain the operator's first-hand OpenShell use case before creating the issue:
106112

107113
```bash
108114
gh issue create \
109115
--title "<type>: <description>" \
110116
--body "$(cat <<'EOF'
117+
## User Story
118+
119+
<I personally use OpenShell for this specific case and directly need this work because...>
120+
111121
## Description
112122
113123
<Clear description of the work>
@@ -125,7 +135,7 @@ EOF
125135

126136
GitHub built-in issue types (`Bug`, `Feature`, `Task`) should come from the matching issue template when possible, or be set manually afterward. Do not try to emulate them through labels.
127137

128-
Creating an issue does not accept it or queue agent work. Agents never apply `state:accepted`, the `roadmap` label, add issues to the roadmap project, or apply `agent:plan-requested` or `agent:implementation-requested`. Community issues proceed through `triage-issue`; a human accepts technically validated work with `state:accepted` or roadmap placement. The request labels queue work for unattended agents. A user may instead direct an agent to a specific issue; the agent warns about missing expected workflow labels and continues with the requested phase without changing them.
138+
Creating an issue does not accept it. Follow Label Discovery in `CONTRIBUTING.md` to retrieve every page of current `state:*` label definitions and resolve unclear meanings, then follow its triage → validation → human acceptance process. Agents may assess facts, but only humans decide whether to accept work or place it on the roadmap. A direct user request authorizes the requested planning or implementation phase without changing issue disposition.
129139

130140
## Useful Options
131141

@@ -150,5 +160,5 @@ Created issue [#123](https://github.com/OWNER/REPO/issues/123)
150160

151161
Use the issue number to:
152162

153-
- Reference in commits: `git commit -m "Fix validation error (fixes #123)"`
154-
- Create a branch following project convention: `<issue-number>-<description>/<username>`
163+
- Reference in signed-off Conventional Commits: `git commit --signoff -m "fix(cli): validate empty requests (fixes #123)"`
164+
- Create a branch following Branch Names in `CONTRIBUTING.md`.

0 commit comments

Comments
 (0)