Skip to content

Commit c2b7bed

Browse files
committed
chore: merge main
Signed-off-by: Eric Curtin <[email protected]>
2 parents 391d48f + 39d95b4 commit c2b7bed

756 files changed

Lines changed: 99412 additions & 23636 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
---
2+
name: apply-triage-action
3+
description: Apply, reject, or defer exactly one issue or CI recommendation from a local triage queue report. Use when the on-duty engineer explicitly supplies an item ID.
4+
metadata:
5+
internal: true
6+
---
7+
8+
# Apply Triage Action
9+
10+
Process exactly one item ID from a queue-review report. Do not accept a natural-language approval without an ID. PRs are informational in v1.
11+
12+
## Locate and validate
13+
14+
1. Read the checkpoint and action records under `.agents/triage-duty/`; reconcile dispositions using the [local-state rules](../review-triage-queue/SKILL.md#local-state).
15+
2. Use the named report, or the latest report containing the ID. Read the recommendation and current disposition. Material changes to a previously selected recommendation require fresh review and selection.
16+
3. Reject missing, superseded, already-final, or ambiguous recommendations without making a write. Never substitute another item.
17+
4. Append every explicit disposition or attempted action to a dated local action record. Record repository, target, source report, ID, timestamp, disposition, reason, confirmed payload, and outcome; update the checkpoint afterward. Keep sensitive content out of the record; use `private reason withheld` for private reasons.
18+
19+
## Reject or defer
20+
21+
For **reject** or **defer**, require the engineer to give a reason. Record the local disposition.
22+
23+
- **Reject** is terminal locally. Do not recommend the item again unless material new evidence changes the case.
24+
- **Defer** is non-terminal. Preserve its original priority and carry it into the next review's carried **Needs your decision** section.
25+
26+
For shareable deferrals, draft a GitHub issue comment with reason, public links, and next step, or link existing waiting context. Use the confirmation rule below; declined posting leaves a local-only deferral. Keep private reasons out of external payloads and committable files. For missing reporter evidence, also propose the awaiting-information assessment state using `triage-issue`; unrelated dependency waits do not change lifecycle labels.
27+
28+
## Apply
29+
30+
Before any external write, re-read the target and determine whether it materially changed. Follow [Label Discovery](../../../CONTRIBUTING.md#label-discovery), retrieving all pages of current definitions before proposing a label change; use [`triage-issue`](../triage-issue/SKILL.md) for assessment states and maintainer authority.
31+
32+
- If the action is already complete or would be a harmless no-op, make no external write and record the reason.
33+
- If new information makes the action unsafe or substantially different, stop and request a fresh review/selection.
34+
35+
You MUST ALWAYS preview the exact payload, item ID, source report, and canonical target, then receive explicit confirmation for each individual external write. Selecting or deferring an item is not confirmation; comments, label changes, and closures require separate confirmations. Revalidate immediately before execution; changed payloads require a new preview and confirmation. Never reuse confirmation for a later invocation.
36+
37+
After confirmation, perform only the approved action and record its outcome and public URL; mark applied only after success.
38+
39+
Supported v1 actions:
40+
41+
- Add the discovered triage-queue label to an open substantive community issue; recheck the [intake eligibility rules](../review-triage-queue/SKILL.md#gather-intake) and exclude duplicates, spam, and security disclosures.
42+
- Create one GitHub issue using [`create-github-issue`](../create-github-issue/SKILL.md).
43+
- Post one public issue comment, including waiting context or a duplicate explanation.
44+
- Change an issue's assessment state to awaiting information.
45+
- Close one issue with an evidenced reason; identify the canonical issue for duplicates.
46+
47+
Never create a public GitHub issue for a security finding. Follow [SECURITY.md](../../../SECURITY.md).

‎.agents/skills/build-from-issue/SKILL.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ Use a single issue comment beginning with `> **🏗️ build-plan**` when a plan
2727
1. Check the current branch and working tree. Preserve unrelated work. Create an issue-specific branch or worktree as needed, following Branch Names in `CONTRIBUTING.md`.
2828
2. Implement the smallest coherent change that fulfills the acceptance criteria. Update relevant skills when behavior or commands change. Keep published documentation minimal: explain exactly what users need, avoid duplication across pages, and omit internal details with no user impact.
2929
3. Add meaningful tests for changed behavior and follow the verification guidance in `CONTRIBUTING.md`. Select format, lint, compile or type checks, and tests for affected components and their dependencies. Run the relevant E2E lane for infrastructure, sandbox, or policy changes. Guidance and template edits need applicable Markdown, YAML, link, and consistency checks. Do not require full Rust, SDK, or repository CI solely because a commit or PR is being created; broaden checks only for a concrete remaining risk or failed check.
30-
4. Review the diff, use a signed-off Conventional Commit, and prepare a PR following `create-github-pr`.
30+
4. Before pushing, apply the contributor access and issue acceptance check in `create-github-pr`. If blocked, preserve local work and report the reason. Review the diff, use a signed-off Conventional Commit, and prepare the PR.
3131

3232
Every PR from this issue-backed workflow must have its own existing issue and use `Closes #<id>` in its Related Issue section. For work needing multiple PRs, split the scope into a closable issue per PR. A high-level issue may track those issues but should not be closed by an incomplete PR. Report the implementation, verification, and any remaining limitation in the PR description, rather than copying earlier issue diagnostics.
3333

3434
Do not apply acceptance or roadmap decisions on behalf of a maintainer. Do not introduce `agent:*` workflow labels.
35+
36+
For first-party security-sensitive crypto, use `openshell-crypto` and extend its facade/backend contracts when needed. Follow the [crypto architecture](../../../crates/openshell-crypto/CRYPTO.md) for compatibility, failure handling, and explicit coverage exceptions.

‎.agents/skills/build-openshell-mxc-windows/SKILL.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,18 @@ Windows MSVC for the supported deliverables:
2121
It intentionally does not make Windows a Docker, Kubernetes, Podman, or VM
2222
runtime host.
2323

24+
The supervisor and supervisor-process libraries participate in native Windows
25+
checks and tests. Their gateway session, boundary attachment, and TCP readiness
26+
are portable; only the optional Unix SSH/readiness socket adapters are gated.
27+
This is compile and control-plane coverage, not Windows isolation qualification.
28+
Preserve readiness gating on authenticated gateway acceptance and reconnection.
29+
The supervisor process-access multiplexer consumes boundary-provided streams;
30+
do not restore local PID, PTY, or process-group operations there. Native process
31+
mechanics belong to the sandbox or isolation backend. Keep the optional Unix
32+
SSH access adapter separate from portable session orchestration.
33+
Shared Sandbox Protocol audit validation defaults to strict Linux evidence;
34+
concrete platform validators must be selected by the implementing backend.
35+
2436
## Current Repository Shape
2537

2638
The Windows build lane is implemented by these tracked files:

‎.agents/skills/build-openshell-mxc-windows/reference.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@ top-level workspace targets for check/test:
111111
--exclude openshell-driver-vault
112112
--exclude openshell-driver-vm
113113
--exclude openshell-sandbox
114-
--exclude openshell-supervisor
115-
--exclude openshell-supervisor-process
116114
--exclude openshell-vfio
117115
```
118116

@@ -124,6 +122,10 @@ egress proxy. The Kubernetes Secrets and Vault libraries still compile as
124122
gateway dependencies; only their standalone Unix-socket binaries and
125123
package-level tests are excluded as top-level targets.
126124

125+
The supervisor and supervisor-process packages now participate as top-level
126+
native check/test targets. Their portable session, attachment, and TCP readiness
127+
coverage does not enable a Windows isolation runtime.
128+
127129
## Common Errors
128130

129131
### Unix imports leak into Windows builds

‎.agents/skills/create-github-pr/SKILL.md‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,26 @@ Create pull requests on GitHub using the `gh` CLI.
1717

1818
## Before Creating a PR
1919

20+
### Verify Contributor Access and Issue Acceptance
21+
22+
Before pushing or creating a PR (including a draft), verify the author's access
23+
to the target repository, not their fork. For the authenticated `gh` user:
24+
25+
```bash
26+
gh repo view OWNER/REPO --json nameWithOwner,viewerPermission
27+
gh issue view ISSUE_NUMBER --repo OWNER/REPO --json number,url,labels
28+
```
29+
30+
Authors with verified `WRITE`, `MAINTAIN`, or `ADMIN` access may proceed without
31+
`state:accepted`; keep the issue link and note the missing label. Everyone else
32+
must link at least one target-repository issue and have `state:accepted` on each.
33+
Otherwise, preserve local work and report which issue needs acceptance. A direct
34+
request, roadmap placement, other labels, or vouch status does not bypass this gate.
35+
36+
When acting for another author, verify their permissions. Resolve failed lookups
37+
before proceeding; retry sandbox network failures outside the sandbox before
38+
reporting an authentication problem. Vouch requirements still apply separately.
39+
2040
### Check Config Documentation
2141

2242
If the branch changes gateway TOML parsing, `[openshell.gateway]` fields,
@@ -156,6 +176,9 @@ PR descriptions must follow the project's [PR template](.github/PULL_REQUEST_TEM
156176
## Changes
157177
<!-- Bullet list of key changes -->
158178

179+
## Release Notes
180+
<!-- Optional: a few short, easy-to-read sentences about the user-facing change -->
181+
159182
## Testing
160183
<!-- What testing was done? -->
161184
- [ ] Checks appropriate to the affected code and behavior pass
@@ -168,6 +191,8 @@ PR descriptions must follow the project's [PR template](.github/PULL_REQUEST_TEM
168191
```
169192

170193
Populate the testing checklist based on what was actually run. Check boxes for steps that were completed.
194+
Keep the Release Notes section concise, with only a few easy-to-read sentences.
195+
Leave it empty when the summary already captures the user-facing change.
171196

172197
## Example PR (Complete)
173198

@@ -189,6 +214,10 @@ Closes #456
189214
- Default page size is 100, max is 1,000
190215
- Structured responses include `next_page_token`
191216
217+
## Release Notes
218+
219+
Sandbox list results can now be paged through with `--page-size` and `--page-token`.
220+
192221
## Testing
193222
194223
- [x] Relevant CLI format, lint, and unit checks pass
@@ -220,6 +249,9 @@ EOF
220249

221250
The command outputs the PR URL and number.
222251

252+
Rerun `PR Issue Acceptance` after linked issue labels change; it does not refresh
253+
automatically on issue-label events.
254+
223255
**Display the URL using markdown link syntax** so it's easily clickable:
224256

225257
```

‎.agents/skills/fix-security-issue/SKILL.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,5 @@ Use this skill after an authorized `review-security-issue` review identifies an
1616
5. Follow `create-github-pr` and use `Closes #<id>` for the reviewed issue. Every PR from this issue-backed remediation workflow must close its own issue; split multi-PR remediations into separate issues in the authorized security workflow. Keep the PR description appropriately scoped to its disclosure venue.
1717

1818
Begin any fix comments with `> **🔧 security-fix-agent**`. Do not change human disposition or introduce `agent:*` workflow labels.
19+
20+
For first-party security-sensitive crypto, use `openshell-crypto` and extend its facade/backend contracts when needed. Follow the [crypto architecture](../../../crates/openshell-crypto/CRYPTO.md) for compatibility, failure handling, and explicit coverage exceptions.

‎.agents/skills/helm-dev-environment/SKILL.md‎

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,27 @@ Override with env vars before running `helm:k3s:create`:
5757
`mcr.microsoft.com/dotnet/aspire-dashboard:latest`)
5858
- `HELM_K3S_COLLECTOR_HEALTH_TIMEOUT` (default: `120` seconds)
5959

60+
### Shared supervisor plumbing
61+
62+
Set `gatewayConfig.openshell.drivers.kubernetes.supervisor_topology`
63+
using a values file (the table key is literally `openshell.drivers.kubernetes`):
64+
65+
```yaml
66+
gatewayConfig:
67+
openshell.drivers.kubernetes:
68+
supervisor_topology: gateway
69+
```
70+
71+
The gateway chart creates a separate, single-replica shared-host placeholder Deployment
72+
in the release namespace, regardless of shared/managed/operator workspace mode.
73+
Use a supervisor image built from this branch: `--mode=shared` is new.
74+
The chart sets `--gateway-endpoint` from the gateway's gRPC endpoint and
75+
`--address` to `0.0.0.0:5501`. Check its rollout and TCP health probes on this
76+
listener (container port `supervisor`, 5501). The outbound gateway connection and
77+
session RPCs are not implemented yet; sandboxes
78+
still use dedicated supervisors. `workspace` is reserved and rejected. Omit the
79+
field to disable it.
80+
6081
### 2. Deploy OpenShell
6182

6283
**Iterative dev** (rebuilds on file changes, recommended during active development):
@@ -81,7 +102,16 @@ The Skaffold flow builds distinct `gateway`, `sandbox`, and `supervisor` images
81102
and deploys the OpenShell Helm chart. The Kubernetes driver creates a
82103
capability-free workload Pod and a directly managed capability-free supervisor
83104
Pod. One namespace-wide NetworkPolicy denies direct egress from every OpenShell
84-
workload Pod. The
105+
workload Pod. New sandbox generations use `runtime-initiated` control: the sandbox
106+
runtime dials its supervisor through `os-supervisor-<id>`. The legacy
107+
`os-boundary-<id>` Service keeps selecting the workload for old gateways during
108+
rolling upgrades. New gateways create both Services and bind the control-mode
109+
annotation to its runtime generation. The driver adds a per-sandbox
110+
`os-control-<id>` NetworkPolicy for that path only. Existing running generations
111+
keep their connection until replaced; stop/start and gateway recovery that
112+
recreates both Pods upgrade legacy generations automatically. Use compatible
113+
gateway, supervisor, and sandbox runtime images together; there is no legacy
114+
rollout flag. The
85115
`pkiInitJob` hook (a pre-install Job that runs `openshell-gateway generate-certs`)
86116
generates gateway and CLI TLS secrets on first install. Supervisor Pods project
87117
only `ca.crt` and authenticate gateway RPCs with sandbox bearer tokens. User

0 commit comments

Comments
 (0)