Skip to content

Commit b3b16f0

Browse files
politerealismpoliterealism
committed
test(conformance): migrate workspace_lifecycle to the conformance suite
Port the workspace and workspace-scoped provider CRUD/isolation/deletion-guard coverage from e2e/rust/tests/workspace_lifecycle.rs into two driver-agnostic scenarios (workspace-lifecycle, workspace-terminating) under tests/suites/conformance/, following the OpenShellRunner/Scenario pattern established for sandbox_lifecycle. Remove the old per-driver test file and its Cargo.toml and tests/artifacts.nix follow-up-exclusion entries. Normalizes miette's line-wrapped diagnostic text before substring-matching error messages; the original test's exact-match assertions were fragile to the terminal width the CLI happened to detect when rendering errors. Verified against an ephemeral Podman gateway. Signed-off-by: politerealism <[email protected]>
1 parent 0bca9fb commit b3b16f0

7 files changed

Lines changed: 407 additions & 285 deletions

File tree

‎crates/openshell-conformance/src/lib.rs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ pub use scenarios::{
2727
FILE_TRANSFER_GIT_FILTERING_SCENARIO, FILE_TRANSFER_PATH_SAFETY_SCENARIO,
2828
FILE_TRANSFER_ROUND_TRIP_SCENARIO, FILE_TRANSFER_SCENARIO, MECHANISTIC_PROPOSAL_SCENARIO,
2929
NEW_HOSTNAME_PROPOSAL_SCENARIO, POLICY_LOCAL_SCENARIO, SANDBOX_LIFECYCLE_SCENARIO,
30-
SMOKE_SCENARIO,
30+
SMOKE_SCENARIO, WORKSPACE_LIFECYCLE_SCENARIO, WORKSPACE_TERMINATING_SCENARIO,
3131
};
3232

3333
/// An installed conformance scenario.
@@ -53,6 +53,8 @@ const SCENARIOS: &[Scenario] = &[
5353
MECHANISTIC_PROPOSAL_SCENARIO,
5454
NEW_HOSTNAME_PROPOSAL_SCENARIO,
5555
POLICY_LOCAL_SCENARIO,
56+
WORKSPACE_LIFECYCLE_SCENARIO,
57+
WORKSPACE_TERMINATING_SCENARIO,
5658
];
5759

5860
/// Returns every scenario compiled into this distribution.

‎crates/openshell-conformance/src/scenarios/mod.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ mod file_transfer;
77
mod policy_behavior;
88
mod sandbox_lifecycle;
99
mod smoke;
10+
mod workspace_lifecycle;
1011

1112
pub use file_transfer::{
1213
FILE_TRANSFER_GIT_FILTERING_SCENARIO, FILE_TRANSFER_PATH_SAFETY_SCENARIO,
@@ -17,3 +18,4 @@ pub use policy_behavior::{
1718
};
1819
pub use sandbox_lifecycle::SANDBOX_LIFECYCLE_SCENARIO;
1920
pub use smoke::SMOKE_SCENARIO;
21+
pub use workspace_lifecycle::{WORKSPACE_LIFECYCLE_SCENARIO, WORKSPACE_TERMINATING_SCENARIO};

0 commit comments

Comments
 (0)