Repository navigation
Commit af95972
committed
fix(server): scope the SSH identity lock per sandbox
SSH host identity provisioning and cleanup took one fleet-wide advisory
key and a process-wide mutex, so create, start, restart and delete ran
that step for one sandbox at a time across the fleet, with each waiting
create holding a lock-pool connection.
The SSH identity guard now takes the legacy key in shared mode and then
an exclusive key derived from the sandbox id, on one data-pool
connection and one data-pool lock slot. The local mutex is keyed by
sandbox id too. Steps for different sandboxes run at once, steps for the
same sandbox still exclude each other on every replica, and gateways
from earlier releases, which hold the legacy key exclusively, keep
excluding new ones during a rolling upgrade.
One 10-second deadline now covers a data-pool lock holder's slot, its
connection and every lock statement, as it already did for mutation
locks, so the second lock statement doesn't extend the wait under
create's mutation guard. A lock that times out returns a lock timeout.
Part of #4307.
Closes #4686
Signed-off-by: Emilien Macchi <[email protected]>1 parent 0149e87 commit af95972
8 files changed
Lines changed: 611 additions & 73 deletions
File tree
- crates/openshell-server/src
- compute
- persistence
- docs/kubernetes
- skills/debug-openshell-cluster
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1373 | 1373 | | |
1374 | 1374 | | |
1375 | 1375 | | |
1376 | | - | |
| 1376 | + | |
1377 | 1377 | | |
1378 | 1378 | | |
1379 | 1379 | | |
| |||
1397 | 1397 | | |
1398 | 1398 | | |
1399 | 1399 | | |
1400 | | - | |
| 1400 | + | |
1401 | 1401 | | |
1402 | 1402 | | |
1403 | 1403 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
412 | 412 | | |
413 | 413 | | |
414 | 414 | | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
415 | 422 | | |
416 | 423 | | |
| 424 | + | |
417 | 425 | | |
418 | 426 | | |
419 | 427 | | |
420 | 428 | | |
421 | 429 | | |
422 | 430 | | |
423 | | - | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
424 | 438 | | |
425 | 439 | | |
426 | 440 | | |
| |||
449 | 463 | | |
450 | 464 | | |
451 | 465 | | |
452 | | - | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
453 | 471 | | |
454 | 472 | | |
455 | 473 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
43 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
44 | 49 | | |
45 | 50 | | |
46 | 51 | | |
| |||
61 | 66 | | |
62 | 67 | | |
63 | 68 | | |
64 | | - | |
65 | | - | |
| 69 | + | |
| 70 | + | |
66 | 71 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
71 | 80 | | |
72 | 81 | | |
73 | 82 | | |
| |||
156 | 165 | | |
157 | 166 | | |
158 | 167 | | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
159 | 178 | | |
160 | 179 | | |
161 | 180 | | |
| |||
276 | 295 | | |
277 | 296 | | |
278 | 297 | | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
279 | 322 | | |
280 | 323 | | |
281 | 324 | | |
| |||
0 commit comments