Skip to content

Commit 9c98b32

Browse files
committed
fix(deps): scope rcgen's x509-parser feature to the supervisor
rcgen 0.13.2 declares its optional x509-parser dependency with the verify feature, which pulls in ring. The workspace enabled rcgen's x509-parser feature for every crate, so the CLI and gateway linked ring alongside aws-lc even though nothing in them verifies signatures with x509-parser. Only SandboxCa::from_pem in openshell-supervisor-network needs CertificateParams::from_ca_cert_pem. Enable the feature there alone. ring no longer appears in the dependency trees of openshell, openshell-gateway or openshell-prover; it remains in openshell-supervisor until rcgen is upgraded. Release builds compile one package at a time, so the feature does not leak into the other binaries. Signed-off-by: politerealism <[email protected]>
1 parent fd95354 commit 9c98b32

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ h2 = "0.4"
4141
tokio-rustls = { version = "0.26", default-features = false, features = ["logging", "tls12", "aws_lc_rs"] }
4242
rustls = { version = "0.23", default-features = false, features = ["std", "logging", "tls12", "aws_lc_rs"] }
4343
rustls-pemfile = "2"
44-
rcgen = { version = "0.13", default-features = false, features = ["crypto", "pem", "aws_lc_rs", "x509-parser"] }
44+
rcgen = { version = "0.13", default-features = false, features = ["crypto", "pem", "aws_lc_rs"] }
4545
webpki-roots = "1"
4646
rustls-native-certs = "0.8"
4747

‎crates/openshell-supervisor-network/Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ hickory-proto = "0.26.1"
3636
ipnet = "2"
3737
miette = { workspace = true }
3838
prost-types = { workspace = true }
39-
rcgen = { workspace = true }
39+
rcgen = { workspace = true, features = ["x509-parser"] }
4040
regorus = { version = "0.9", default-features = false, features = ["std", "arc", "glob", "yaml"] }
4141
reqwest = { workspace = true }
4242
rustls = { workspace = true }

0 commit comments

Comments
 (0)