Skip to content

Commit 991cc18

Browse files
committed
fix: apply recommandations from gator-agent
Signed-off-by: Jeff MAURY <[email protected]>
1 parent 6d3f53f commit 991cc18

3 files changed

Lines changed: 12 additions & 96 deletions

File tree

‎architecture/README.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ that crate's `README.md`.
161161

162162
| Document | Purpose |
163163
|---|---|
164-
| [CLI](cli.md) | CLI architecture, command implementations, and output formatting patterns. |
165164
| [Gateway](gateway.md) | Gateway control plane, auth, APIs, persistence, settings, and relay coordination. |
166165
| [Sandbox](sandbox.md) | Sandbox supervisor, child process isolation, proxy, credentials, inference, connect, and logs. |
167166
| [Security Policy](security-policy.md) | Policy model, enforcement layers, policy updates, policy advisor, and security logging. |

‎architecture/cli.md‎

Lines changed: 0 additions & 83 deletions
This file was deleted.

‎crates/openshell-cli/src/output.rs‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ mod tests {
329329
// Note: This test doesn't capture stdout, but verifies the function returns Ok(true)
330330
let result = print_output_collection("json", &items, test_item_to_json);
331331
assert!(result.is_ok());
332-
assert_eq!(result.unwrap(), true);
332+
assert!(result.unwrap());
333333
}
334334

335335
#[test]
@@ -341,7 +341,7 @@ mod tests {
341341

342342
let result = print_output_collection("yaml", &items, test_item_to_json);
343343
assert!(result.is_ok());
344-
assert_eq!(result.unwrap(), true);
344+
assert!(result.unwrap());
345345
}
346346

347347
#[test]
@@ -353,7 +353,7 @@ mod tests {
353353

354354
let result = print_output_collection("table", &items, test_item_to_json);
355355
assert!(result.is_ok());
356-
assert_eq!(result.unwrap(), false); // Should return false for table
356+
assert!(result.unwrap()); // Should return false for table
357357
}
358358

359359
#[test]
@@ -379,7 +379,7 @@ mod tests {
379379

380380
let result = print_output_collection("json", &items, test_item_to_json);
381381
assert!(result.is_ok());
382-
assert_eq!(result.unwrap(), true);
382+
assert!(result.unwrap());
383383
}
384384

385385
#[test]
@@ -391,7 +391,7 @@ mod tests {
391391

392392
let result = print_output_single("json", &item, test_item_to_json);
393393
assert!(result.is_ok());
394-
assert_eq!(result.unwrap(), true);
394+
assert!(result.unwrap());
395395
}
396396

397397
#[test]
@@ -403,7 +403,7 @@ mod tests {
403403

404404
let result = print_output_single("yaml", &item, test_item_to_json);
405405
assert!(result.is_ok());
406-
assert_eq!(result.unwrap(), true);
406+
assert!(result.unwrap());
407407
}
408408

409409
#[test]
@@ -413,7 +413,7 @@ mod tests {
413413

414414
let result = print_output_direct("json", json_fn, yaml_fn);
415415
assert!(result.is_ok());
416-
assert_eq!(result.unwrap(), true);
416+
assert!(result.unwrap());
417417
}
418418

419419
#[test]
@@ -423,7 +423,7 @@ mod tests {
423423

424424
let result = print_output_direct("yaml", json_fn, yaml_fn);
425425
assert!(result.is_ok());
426-
assert_eq!(result.unwrap(), true);
426+
assert!(result.unwrap());
427427
}
428428

429429
#[test]
@@ -447,7 +447,7 @@ mod tests {
447447
let result =
448448
print_output_collection_to_writer("json", &mut buffer, &items, test_item_to_json);
449449
assert!(result.is_ok());
450-
assert_eq!(result.unwrap(), true);
450+
assert!(result.unwrap());
451451

452452
let output = String::from_utf8(buffer).unwrap();
453453
assert!(output.contains("\"id\": 1"));
@@ -465,7 +465,7 @@ mod tests {
465465
let result =
466466
print_output_collection_to_writer("yaml", &mut buffer, &items, test_item_to_json);
467467
assert!(result.is_ok());
468-
assert_eq!(result.unwrap(), true);
468+
assert!(result.unwrap());
469469

470470
let output = String::from_utf8(buffer).unwrap();
471471
assert!(output.contains("id: 1"));
@@ -482,7 +482,7 @@ mod tests {
482482

483483
let result = print_output_single_to_writer("json", &mut buffer, &item, test_item_to_json);
484484
assert!(result.is_ok());
485-
assert_eq!(result.unwrap(), true);
485+
assert!(result.unwrap());
486486

487487
let output = String::from_utf8(buffer).unwrap();
488488
assert!(output.contains("\"id\": 42"));
@@ -497,7 +497,7 @@ mod tests {
497497

498498
let result = print_output_direct_to_writer("json", &mut buffer, json_fn, yaml_fn);
499499
assert!(result.is_ok());
500-
assert_eq!(result.unwrap(), true);
500+
assert!(result.unwrap());
501501

502502
let output = String::from_utf8(buffer).unwrap();
503503
assert!(output.contains(r#"{"test": true}"#));

0 commit comments

Comments
 (0)