Skip to content

Commit 639fe11

Browse files
committed
fix(sandbox): repair advisor provenance lint failures
1 parent 3e745c5 commit 639fe11

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎crates/openshell-policy/src/lib.rs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,6 @@ struct NetworkEndpointDef {
129129
/// placeholders before forwarding upstream. Defaults to false.
130130
#[serde(default, skip_serializing_if = "std::ops::Not::not")]
131131
request_body_credential_rewrite: bool,
132-
#[serde(default, skip_serializing_if = "std::ops::Not::not")]
133-
advisor_proposed: bool,
134132
#[serde(default, skip_serializing_if = "String::is_empty")]
135133
persisted_queries: String,
136134
#[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
@@ -330,7 +328,9 @@ fn to_proto(raw: PolicyFile) -> SandboxPolicy {
330328
allow_encoded_slash: e.allow_encoded_slash,
331329
websocket_credential_rewrite: e.websocket_credential_rewrite,
332330
request_body_credential_rewrite: e.request_body_credential_rewrite,
333-
advisor_proposed: e.advisor_proposed,
331+
// Advisor provenance is internal runtime state, not
332+
// a user-authored policy schema field.
333+
advisor_proposed: false,
334334
persisted_queries: e.persisted_queries,
335335
graphql_persisted_queries: e
336336
.graphql_persisted_queries
@@ -496,7 +496,6 @@ fn from_proto(policy: &SandboxPolicy) -> PolicyFile {
496496
allow_encoded_slash: e.allow_encoded_slash,
497497
websocket_credential_rewrite: e.websocket_credential_rewrite,
498498
request_body_credential_rewrite: e.request_body_credential_rewrite,
499-
advisor_proposed: e.advisor_proposed,
500499
persisted_queries: e.persisted_queries.clone(),
501500
graphql_persisted_queries: e
502501
.graphql_persisted_queries

‎crates/openshell-providers/src/profiles.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,7 @@ fn endpoint_to_proto(endpoint: &EndpointProfile) -> NetworkEndpoint {
587587
allow_encoded_slash: endpoint.allow_encoded_slash,
588588
websocket_credential_rewrite: endpoint.websocket_credential_rewrite,
589589
request_body_credential_rewrite: endpoint.request_body_credential_rewrite,
590+
advisor_proposed: false,
590591
persisted_queries: endpoint.persisted_queries.clone(),
591592
graphql_persisted_queries: endpoint
592593
.graphql_persisted_queries

0 commit comments

Comments
 (0)