Skip to content

Commit 5ca344e

Browse files
refactor(sandbox): own only workspace root
Signed-off-by: Matthew Grossman <[email protected]>
1 parent 85ebbdf commit 5ca344e

7 files changed

Lines changed: 100 additions & 255 deletions

File tree

‎architecture/compute-runtimes.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,10 @@ primary GID. It does not rewrite the account files.
146146

147147
When either component falls back to the image identity, Docker and Podman
148148
prepare the fixed `/sandbox` workspace for the completed UID/GID before direct
149-
or SSH children start. They create it when absent and recursively transfer
150-
ownership of image-provided contents, while skipping symlinks and nested mount
151-
points. Kubernetes/OpenShift keep their PVC and `fsGroup` behavior, and VM
152-
keeps its guest initialization path.
149+
or SSH children start. They create it when absent and transfer ownership of
150+
only the workspace directory. Image-provided contents and nested mounts retain
151+
their ownership. Kubernetes/OpenShift keep their PVC and `fsGroup` behavior,
152+
and VM keeps its guest initialization path.
153153

154154
Sandbox creation fails before the workload becomes ready when a required image
155155
identity is absent, malformed, unknown, ambiguous, or resolves to UID/GID 0.

‎crates/openshell-driver-docker/README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ is filled with the user's numeric primary GID. Explicit `process.run_as_user`
2828
and `process.run_as_group` values take precedence independently.
2929

3030
When either policy field falls back to OCI `USER`, the supervisor creates the
31-
fixed `/sandbox` workspace if necessary and transfers ownership of its existing
32-
image contents to the completed identity before direct or SSH children start.
33-
It skips symlinks and nested bind or volume mounts so externally owned content
34-
retains its ownership. A read-only workspace root fails sandbox startup.
31+
fixed `/sandbox` workspace if necessary and transfers ownership of only that
32+
directory to the completed identity before direct or SSH children start.
33+
Image-provided contents and nested bind or volume mounts retain their ownership.
34+
A read-only workspace root fails sandbox startup.
3535

3636
Docker containers join an OpenShell-managed bridge network. The driver injects
3737
`host.openshell.internal` and `host.docker.internal` so supervisors have stable

‎crates/openshell-driver-podman/README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ validation; a missing group is filled with the user's numeric primary GID. Expli
1818
independently.
1919

2020
When either policy field falls back to OCI `USER`, the supervisor creates the
21-
fixed `/sandbox` workspace if necessary and transfers ownership of its existing
22-
image contents to the completed identity before direct or SSH children start.
23-
It skips symlinks and nested bind or volume mounts so externally owned content
24-
retains its ownership. A read-only workspace root fails sandbox startup.
21+
fixed `/sandbox` workspace if necessary and transfers ownership of only that
22+
directory to the completed identity before direct or SSH children start.
23+
Image-provided contents and nested bind or volume mounts retain their ownership.
24+
A read-only workspace root fails sandbox startup.
2525

2626
For a rootless networking deep dive, see [NETWORKING.md](NETWORKING.md).
2727

0 commit comments

Comments
 (0)