Skip to content

Commit 566b39d

Browse files
test(conformance): build credential gating on shared test support
Use testkit's policy helpers and install_provider and host-server-support's recorders, and assert on the requests that reached the host server instead of verdicts the sandbox clients print. Signed-off-by: Matthew Grossman <[email protected]>
1 parent f0d5287 commit 566b39d

4 files changed

Lines changed: 200 additions & 302 deletions

File tree

‎tests/suites/conformance/Cargo.lock‎

Lines changed: 13 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎tests/suites/conformance/Cargo.toml‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,10 @@ path = "src/main.rs"
2121
test = false
2222

2323
[dependencies]
24-
base64 = "0.22"
25-
openshell-policy = { path = "../../../crates/openshell-policy" }
24+
host-server-support = { path = "../../support/host-server" }
2625
openshell-testkit = { path = "../../testkit/testkit" }
2726
serde_json = "1"
28-
sha1 = "0.10"
2927
tempfile = "3"
30-
tokio = { version = "1", features = ["io-util", "net", "rt", "time"] }
28+
tokio = { version = "1", features = ["time"] }
3129

3230
[workspace]

‎tests/suites/conformance/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ tmachine environment on CI. The other suites are ports of the old
2323
tests, so a test environment needs it installed
2424
(`tests/tmachine/ansible/playbooks/test-tools.yaml` does that for the tmachine
2525
environments). `credential-gating`, ported from NVIDIA/OpenShell#5264, starts
26-
servers on the machine that runs the tests and reaches them from sandboxes
26+
servers (`tests/support/host-server`) on the machine that runs the tests and reaches them from sandboxes
2727
created from `testkit::python_image()` through `host.openshell.internal`, so
2828
it fails against a gateway whose sandboxes can't reach that machine, such as
2929
a remote Kubernetes cluster.

0 commit comments

Comments
 (0)