Skip to content

Commit 5023061

Browse files
akramelezardrew
authored
refactor(runtime): retire Community image dependencies (#3386)
* feat(sandbox): default to official Alpine sandbox image default_sandbox_image() now returns docker.io/library/alpine:3.22, a generic version-qualified official image, so a fresh install no longer depends on the community sandbox image catalog. All compute drivers (docker, podman, kubernetes, vm) inherit this fallback. Part of #3116. Signed-off-by: Akram Signed-off-by: Akram <[email protected]> * feat(deploy): default deployment configs to the official Alpine sandbox image Update the shared gateway default_image, Helm chart values, the standalone Kubernetes manifest, and the dev gateway task scripts to use docker.io/library/alpine:3.22 instead of the community base image, consistent with default_sandbox_image(). GPU e2e image-build base is left unchanged (CUDA needs a glibc base). Part of #3116. Signed-off-by: Akram Signed-off-by: Akram <[email protected]> * feat(driver): default to numeric non-root identity for USER-less images With the default sandbox image now Alpine, images that declare no OCI USER must start instead of being rejected. When the image declares no USER and the policy requests none, the Podman and Docker drivers now supply a numeric non-root identity (DEFAULT_SANDBOX_UID/GID = 1000) instead of rejecting, matching the numeric-identity behavior of the Kubernetes and VM drivers. The supervisor's resolved-identity path runs the sandbox as a synthesized non-root account without the account existing in the image. Images that declare a USER keep the OCI resolution path unchanged. Part of #3116. Signed-off-by: Akram <[email protected]> Signed-off-by: Evan Lezar <[email protected]> * test(conformance): use Alpine workload image Signed-off-by: Evan Lezar <[email protected]> * refactor(policy): drop community image /app path from default policy The restrictive default policy granted read-only access to /app, a directory that only existed in the community base image. A generic Alpine default has no /app, so remove it. Landlock best-effort already ignores absent paths; this just stops advertising a community-specific layout in the default. Part of #3116. Signed-off-by: Akram Signed-off-by: Akram <[email protected]> * docs(config): document Alpine default images Signed-off-by: Evan Lezar <[email protected]> * fix(podman): report early sandbox termination Signed-off-by: Evan Lezar <[email protected]> * fix(podman): initialize rootless workspace ownership Signed-off-by: Evan Lezar <[email protected]> * fix(sandbox): qualify NVIDIA Ubuntu default Signed-off-by: Drew Newberry <[email protected]> * fix(podman): initialize rootful default workspace Signed-off-by: Drew Newberry <[email protected]> * feat(sftp): add native sandbox adapter Signed-off-by: Drew Newberry <[email protected]> * fix(sftp): gate runtime helper support to Linux Signed-off-by: Drew Newberry <[email protected]> * fix(sftp): support standard OpenSSH file operations Signed-off-by: Drew Newberry <[email protected]> * fix(sftp): harden rename and special file handling Signed-off-by: Drew Newberry <[email protected]> * refactor(runtime): remove community image dependencies Signed-off-by: Drew Newberry <[email protected]> * test(e2e): build provider readiness tool fixture Signed-off-by: Drew Newberry <[email protected]> * fix(e2e): use a dedicated Noble fixture for Docker tests Signed-off-by: Evan Lezar <[email protected]> --------- Signed-off-by: Akram Signed-off-by: Akram <[email protected]> Signed-off-by: Evan Lezar <[email protected]> Signed-off-by: Drew Newberry <[email protected]> Co-authored-by: Evan Lezar <[email protected]> Co-authored-by: Drew Newberry <[email protected]>
1 parent 24706c1 commit 5023061

129 files changed

Lines changed: 2383 additions & 898 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/helm-dev-environment/SKILL.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Also applies the upstream agent-sandbox CRDs/controller (pinned via `AGENT_SANDB
3434
in `tasks/scripts/helm-k3s-local.sh`, fetched from `github.com/kubernetes-sigs/agent-sandbox`
3535
releases), enables its OTLP tracing on v0.5 and later, installs an OTLP trace
3636
collector and UI in the `observability` namespace,
37-
and preloads the default community sandbox image into k3d so the first sandbox create
37+
and preloads the default sandbox image into k3d so the first sandbox create
3838
does not wait on a large registry pull. Traefik is disabled at cluster creation time.
3939

4040
**Multi-worktree support:** the cluster name is derived from the last component of the
@@ -52,7 +52,7 @@ Port mappings created at cluster time (cannot be changed without recreating):
5252
Override with env vars before running `helm:k3s:create`:
5353
- `HELM_K3S_LB_HOST_PORT` (default: `8080`)
5454
- `HELM_K3S_PRELOAD_SANDBOX_IMAGE` (default:
55-
`ghcr.io/nvidia/openshell-community/sandboxes/base:latest`; set to an empty value to skip)
55+
`nvcr.io/nvidia/base/ubuntu:24.04`; set to an empty value to skip)
5656
- `HELM_K3S_COLLECTOR_IMAGE` (default:
5757
`mcr.microsoft.com/dotnet/aspire-dashboard:latest`)
5858
- `HELM_K3S_COLLECTOR_HEALTH_TIMEOUT` (default: `120` seconds)

‎.agents/skills/update-docs/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ For each relevant commit, determine which doc page(s) it affects. Use this mappi
6363
| `python/` (SDK changes) | `docs/reference/` or `docs/get-started/quickstart.mdx` |
6464
| `proto/` (API changes) | `docs/reference/` |
6565
| `deploy/` (Dockerfile, Helm) | `docs/sandboxes/manage-gateways.mdx`, `docs/about/architecture.mdx` |
66-
| Community sandbox definitions | `docs/sandboxes/community-sandboxes.mdx` |
66+
| Sandbox image behavior | `docs/sandboxes/manage-sandboxes.mdx` |
6767

6868
If a commit does not map to any existing page but introduces a user-visible concept, flag it as needing a new page.
6969

‎.github/actions/setup-e2e-kind/action.yml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,16 @@ runs:
8080
docker image save --platform linux/amd64 --output "$archive" "$image"
8181
kind load image-archive "$archive" --name "$CLUSTER_NAME"
8282
done
83+
84+
- name: Preload default sandbox image into kind
85+
shell: bash
86+
env:
87+
CLUSTER_NAME: ${{ inputs.cluster-name }}
88+
SANDBOX_IMAGE: nvcr.io/nvidia/base/ubuntu:24.04
89+
run: |
90+
set -euo pipefail
91+
archive="${RUNNER_TEMP:-/tmp}/openshell-default-sandbox-linux-amd64.tar"
92+
docker pull --platform linux/amd64 "$SANDBOX_IMAGE"
93+
docker image inspect "$SANDBOX_IMAGE" --format 'default sandbox image: {{join .RepoDigests ", "}}'
94+
docker image save --platform linux/amd64 --output "$archive" "$SANDBOX_IMAGE"
95+
kind load image-archive "$archive" --name "$CLUSTER_NAME"

‎.github/actions/setup-e2e-podman/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,5 +122,5 @@ runs:
122122
podman run --rm \
123123
--cap-add=SETPCAP \
124124
--volume "$probe:/openshell-capbset-probe:ro" \
125-
docker.io/library/alpine:3.22 \
125+
nvcr.io/nvidia/base/ubuntu:24.04 \
126126
/openshell-capbset-probe

0 commit comments

Comments
 (0)