You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4d66150
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: .agents/skills/build-from-issue/SKILL.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -34,3 +34,5 @@ Every PR from this issue-backed workflow must have its own existing issue and us
34
34
Do not apply acceptance or roadmap decisions on behalf of a maintainer. Do not introduce `agent:*` workflow labels.
35
35
36
36
For first-party security-sensitive crypto, use `openshell-crypto` and extend its facade/backend contracts when needed. Follow the [crypto architecture](../../../crates/openshell-crypto/CRYPTO.md) for compatibility, failure handling, and explicit coverage exceptions.
37
+
38
+
When changing crypto dependencies, run `mise run rust:deny:policy`, including its dependency-boundary regression fixtures. Review any `deny.toml` wrapper change against the documented exception scope; an existing allowance does not authorize new security-sensitive operations outside the facade.
Copy file name to clipboardExpand all lines: .agents/skills/fix-security-issue/SKILL.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -18,3 +18,5 @@ Use this skill after an authorized `review-security-issue` review identifies an
18
18
Begin any fix comments with `> **🔧 security-fix-agent**`. Do not change human disposition or introduce `agent:*` workflow labels.
19
19
20
20
For first-party security-sensitive crypto, use `openshell-crypto` and extend its facade/backend contracts when needed. Follow the [crypto architecture](../../../crates/openshell-crypto/CRYPTO.md) for compatibility, failure handling, and explicit coverage exceptions.
21
+
22
+
When changing crypto dependencies, run `mise run rust:deny:policy`, including its dependency-boundary regression fixtures. Review any `deny.toml` wrapper change against the documented exception scope; an existing allowance does not authorize new security-sensitive operations outside the facade.
Copy file name to clipboardExpand all lines: .agents/skills/helm-dev-environment/SKILL.md
+38-1Lines changed: 38 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -269,7 +269,10 @@ trace-context annotation. The same command exposes OTLP/gRPC on
269
269
`http://127.0.0.1:4317`and, when deployed, the Kubernetes gateway on
270
270
`http://127.0.0.1:8090`. The local `gateway:docker`, `gateway:podman`, and
271
271
`gateway:vm`tasks detect the collector listener at startup and enable trace
272
-
export only while it is reachable.
272
+
export, OCSF log export, and the agent trace relay only while it is reachable.
273
+
Spans an agent exports from inside a sandbox arrive through the supervisor's
274
+
relay with `openshell.telemetry.source=agent` and share `openshell.sandbox.id`
275
+
with that sandbox's supervisor spans.
273
276
274
277
The Skaffold profile for HA reverse-proxy development is available from
275
278
`deploy/helm/openshell/`:
@@ -418,6 +421,30 @@ above) instead of relying only on `OPENSHELL_GATEWAY_ENDPOINT`; some tests call
418
421
### Kubernetes E2E Notes
419
422
420
423
Use `mise run e2e:kubernetes` for the standard Helm-backed Kubernetes suite.
424
+
Set `OPENSHELL_E2E_KUBE_TEST=kubernetes_image_update` to scope the Rust suite to
425
+
combined image, command, environment, and metadata updates with retained sandbox,
426
+
SSH, and PVC identities. The next start verifies the new argv and environment. This target is
427
+
included in both existing Agent Sandbox API-version lanes; unlike the Python
428
+
Docker suite, it exercises the driver that supports image updates.
429
+
430
+
Image updates default to disabled outside test fixtures. The e2e wrapper opts
431
+
in only for a fresh gateway fixture that it owns; set
432
+
`OPENSHELL_E2E_KUBE_IMAGE_UPDATES=0`to prevent that opt-in. Do not propagate
433
+
activation to an existing shared gateway or enable it during a mixed-version
434
+
rollout. For manual testing, follow the retirement and activation checklist in
Copy file name to clipboardExpand all lines: .agents/skills/launch-openshell-gator/SKILL.md
+17-1Lines changed: 17 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -82,6 +82,22 @@ If this fails, run the local Codex login flow outside the gator launch. If Codex
82
82
83
83
The launcher passes the non-secret host account ID as literal `CODEX_ACCOUNT_ID` for Codex's local workspace routing. The harness must not use the opaque `CODEX_AUTH_ACCOUNT_ID` credential placeholder for that comparison. Access tokens remain placeholders, and refresh material remains gateway-only.
84
84
85
+
The image contains task-independent tooling and a prompt template, not the run's PR assignment or test authorization. The launcher supplies those instructions at runtime through `OPENSHELL_AGENT_TASK` in the canonical process command. The supervisor captures the assembled prompt in memory and supplies it on stdin for every cycle. Task text is non-secret and may appear in runtime command metadata; never put credentials in the task. Task-only changes reuse the same tooling build inputs, although the launcher still builds/tags an image per invocation.
86
+
87
+
For Kubernetes gateways, select image delivery explicitly: `--k3d-cluster NAME`
88
+
builds with Docker and imports into a running local cluster with the matching
89
+
current kube context; `--publish-image REGISTRY/REPOSITORY:TAG` builds and pushes,
90
+
then launches by resolved digest; `--image REGISTRY/REPOSITORY@sha256:DIGEST`
91
+
reuses trusted compatible tooling without local image tools. Do not infer
92
+
locality from a loopback endpoint. The k3d selection asserts which cluster
93
+
serves the gateway; imported images require `if_not_present` or `never` pull
94
+
policy. Registry builds use the builder's platform and existing registry auth;
95
+
nodes need their own pull access. `--build-only` builds/delivers without
96
+
gateway mutations, provider credential reads, or a sandbox launch. Reused
97
+
images must match the local manifest's agent ID and payload version and support
98
+
the runtime task contract; legacy baked-task images fail startup. See
99
+
`scripts/agents/gator/README.md` for examples and option compatibility.
100
+
85
101
### Step 5: Verify Gateway Is Registered And Alive
86
102
87
103
Use the target gateway from the operator request or current session context. Do not assume a gateway name. If the operator did not specify one, list registered gateways and ask before launching when the correct target is ambiguous.
"Review and monitor PR #${pr_number} through the gator-gate workflow. Scope this invocation only to PR #${pr_number}."
164
180
```
165
181
166
-
The launcher queries the gateway's selected compute driver, builds the gator image in the matching Docker or Podman image store, stages the immutable payload, imports provider profiles, configures provider credentials and refresh, and starts the agent supervisor as the sandbox's canonical main process. The detached main process survives loss of the host CLI connection and reconnects to a restarted gateway. Unless `--keep` is set, the sandbox is marked ephemeral so the gateway deletes it after the canonical main process exits and its terminal result is finalized. `CONTAINER_ENGINE`, when set, must match the gateway driver.
182
+
The launcher queries the gateway's selected compute driver and prepares the image through the selected build/import/publish or prebuilt path before importing provider profiles, configuring provider credentials and refresh, and starting the agent supervisor as the sandbox's canonical main process. The detached main process survives loss of the host CLI connection and reconnects to a restarted gateway. Unless `--keep` is set, the sandbox is marked ephemeral so the gateway deletes it after the canonical main process exits and its terminal result is finalized. `CONTAINER_ENGINE`, when set, must match Docker/Podman gateways or Docker for k3d imports; registry builds for Kubernetes may use either local engine.
167
183
168
184
The launcher streams image-build and provisioning output until the detached workload is ready, then exits. Use `openshell logs <sandbox-name>` or the TUI for runtime output.
| Transient infrastructure failure in a pre-release, including a registry push | After approval, `gh run rerun <run-id> --failed`. `Release` won't select the run until all of it passes. |
235
220
| Pre-release run ends in `startup_failure`| The workflow file is invalid at that commit. Fix it in a new `-pre.N` (Monday step 3). |
236
221
| Code defect or `Cargo Deny` advisory | Rerunning won't help. Fix it in a new `-pre.N` (Monday step 3). |
237
-
|`Release` fails after selection | After approval, rerun only the failed jobs that haven't published. |
222
+
|`Release` fails after selection | After approval, rerun only the failed jobs that haven't published. If the run's artifacts expired or its jobs were skipped, dispatch `Release` again with `-f tag=vX.Y.Z`; it publishes only what is missing. |
Copy file name to clipboardExpand all lines: .agents/skills/review-github-pr/SKILL.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -153,7 +153,7 @@ Read through the full diff (and the PR description if available). Produce a summ
153
153
suggested change.
154
154
- Do not fabricate concerns or claim a behavioral regression without evidence
155
155
for both the prior and proposed behavior.
156
-
-**Cryptographic boundaries**: For changed first-party security-sensitive crypto, verify use of `openshell-crypto`, backend dispatch, failure propagation without fallback, and protocol/storage compatibility. Missing operations belong in the facade/backend contracts. Check dependency-owned and non-security exceptions against the repository's [crypto architecture](../../../crates/openshell-crypto/CRYPTO.md); protocol/parsing types alone are not bypasses. Report undocumented bypasses or scope expansion under **Potential Concerns**.
156
+
-**Cryptographic boundaries**: For changed first-party security-sensitive crypto, verify use of `openshell-crypto`, backend dispatch, failure propagation without fallback, and protocol/storage compatibility. Missing operations belong in the facade/backend contracts. Check dependency-owned and other explicit exceptions against the repository's [crypto architecture](../../../crates/openshell-crypto/CRYPTO.md); protocol/parsing types alone are not bypasses. Check `mise run rust:deny:policy` results and review changes to `deny.toml` wrappers; package-level allowances do not authorize new bypasses within those packages. Report undocumented bypasses or scope expansion under **Potential Concerns**.
157
157
-**Agent infrastructure**: When the PR changes behavior, commands, or development workflows, use the `sync-agent-infra` maintenance map to check that related skills were updated. When it adds, removes, or renames skills or crates; changes workflow relationships or skill coverage; modifies issue or PR templates; or changes agent cross-references, apply the full consistency checklist. Report missing companion updates or drift under **Potential Concerns**.
Copy file name to clipboardExpand all lines: .agents/skills/test-release-canary/SKILL.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -95,7 +95,7 @@ Note `install.sh` is pulled from `raw.githubusercontent.com/NVIDIA/OpenShell/${h
95
95
96
96
## Testing artifacts from a specific SHA
97
97
98
-
`Release Dev` publishes two chart versions for every dev build (see `.github/actions/release-helm-oci/action.yml:89-102`):
98
+
`Release Dev` publishes two chart versions for every dev build (see the push steps in `.github/actions/release-helm-oci/action.yml`):
99
99
100
100
- `oci://ghcr.io/nvidia/openshell/helm-chart:0.0.0-dev`— floating, overwritten on every main push.
101
101
- `oci://ghcr.io/nvidia/openshell/helm-chart:0.0.0-dev.<sha>`— immutable, `appVersion` set to the same SHA so it pulls the matching `gateway`, `sandbox`, and `supervisor` images.
Copy file name to clipboardExpand all lines: .agents/skills/watch-github-actions/SKILL.md
+13-6Lines changed: 13 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -125,7 +125,9 @@ gh run list --json databaseId,status,headBranch,url --jq '.[] | {id: .databaseId
125
125
126
126
## View Job Logs
127
127
128
-
For tmachine Kubernetes conformance failures, inspect the `tmachine-diagnostics-*` artifact. The K3s report includes Agent Sandbox controller state, leader leases, events, and current and previous controller logs. The conformance playbook checks reconciliation after guest boot with a temporary scheduling-gated Sandbox probe before running tests. Distinguish a failed controller probe from a failed conformance scenario; gateway connectivity and controller Deployment availability do not prove reconciliation works.
128
+
For tmachine Kubernetes conformance failures, inspect the `e2e-results-conformance-sandbox-ubuntu-k3s-*` artifact. Its `diagnostics/` holds the K3s report with Agent Sandbox controller state, leader leases, events, and current and previous controller logs. The k3s installers check reconciliation after guest boot with a temporary scheduling-gated Sandbox probe, so a failed probe fails provisioning before any test runs. Distinguish a failed controller probe from a failed conformance scenario; gateway connectivity and controller Deployment availability do not prove reconciliation works.
129
+
130
+
For the `e2e-suites` lane (`.github/workflows/e2e-suites.yml`), the last lines of the job log give the runner's result: PASS, FAIL (exit 1) after the end of the nextest log (which names the failed tests), or ERROR (exit 2) with the step that broke. FAIL and ERROR also appear as annotations on the run's summary page. Then inspect the `e2e-results-<family>-<package>-<environment>-<installer>` artifact, which holds `junit.xml`, `nextest.log` and, after a failure, the guest's `diagnostics/`.
129
131
130
132
`Pre-release` temporarily omits Codex Security from its `Security Scan` job.
131
133
`Release` uses the passing prerelease qualification result. Other scanners and
@@ -162,15 +164,20 @@ not substitute the current `main` tip or the event's older PR base SHA. Merge
162
164
groups and manual runs use their explicit baseline. Findings are reported by
163
165
`Reject new high or critical findings`; distinguish those from scanner failures.
164
166
167
+
For `Cargo Deny`, the metadata-only commands clear Rust compiler wrappers after
168
+
entering mise; they do not require sccache. For OpenSSL backend and dynamic-linkage
169
+
checks, use `nix develop .#crypto` from outside the default shell. The release
170
+
toolchains in the default shell expose an unprefixed system AWS-LC that conflicts
171
+
with OpenSSL. The crypto shell uses native OpenSSL and Cargo's symbol-prefixed
172
+
AWS-LC build for dual-backend tests.
173
+
165
174
For `Protobuf Compatibility`, check the logged train and comparison baseline.
166
175
Branch Checks compares the prospective merge tree with its target; release qualification
167
176
compares the tagged candidate with the previous stable release. Both use
168
177
the shared `check-protobuf-compatibility` action with `nix run .#check-protobuf-compatibility -- <ref>`.
169
178
During `0.x`, a minor train permits compatibility findings
170
179
as warnings; a patch train or no active train rejects them. Compare the current
171
180
train's version with the latest stable release; commit messages are irrelevant.
172
-
For the patch-train `v0.1.6-pre.N` exception, inspect the run summary and the
173
-
qualification JSON's `exceptions` array; see `release-captain` for disposition.
174
181
Compilation, baseline, and tool errors remain fatal. The `protobuf_compatibility` suite participates in
175
182
the `release-tag-v1` qualification profile. Pre-release calls the reusable
176
183
`release-qualification.yml` workflow after building, in parallel with publication. Release
@@ -190,7 +197,7 @@ qualification; stable publication is blocked, while published pre-release
190
197
artifacts remain available. The Pre-release failure notification includes the
191
198
run link. Both callers share `release-build.yml` and `release-publish.yml`.
192
199
Qualification evidence remains in Actions; publishing a copy to OCI storage is best effort.
193
-
Snap Store uploads happen only for stable releases after qualification passes.
200
+
Pre-release uploads snaps to `latest/beta`; stable releases upload to `latest/stable`.
194
201
195
202
For a release notes preview, dispatch `release.yml` with `notes-only=true` and
196
203
`tag=<stable-tag>`. The generator resolves the previous reachable stable tag;
@@ -207,8 +214,8 @@ and qualification, and keeps the notes only in the `release-notes` artifact.
207
214
This job is advisory: a notes failure emits a warning without failing the
208
215
prerelease run or blocking promotion. Stable publication reuses the promoted
209
216
prerelease's `release-notes` artifact, retagged, and generates notes only when
210
-
that preview is unavailable. The `Select Qualified Prerelease` summary says
211
-
which happened.
217
+
that preview is unavailable. The Release workflow's `Release Notes` job summary
218
+
says which happened, and Publish waits for that job.
212
219
213
220
For `Codex Compatibility Review`, inspect its job summary and the
214
221
`compatibility-review-run-<run-id>-attempt-<attempt>` artifact. Confirm the
0 commit comments