Skip to content

Commit 244a281

Browse files
committed
Merge branch 'main' into codex/1456-gateway-glibc-228
2 parents 09e66a9 + 234e69d commit 244a281

33 files changed

Lines changed: 1405 additions & 144 deletions

File tree

‎.github/ISSUE_TEMPLATE/feature_request.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ body:
77
value: |
88
## Design-First Feature Proposals
99
10-
OpenShell feature requests must include a design proposal — describe the system behavior you want, not just the outcome. If your agent explored the codebase to assess feasibility (e.g., using the `create-spike` skill), include its findings.
10+
OpenShell feature requests must include a design proposal — describe the system behavior you want, not just the outcome. New features start here, not as RFC pull requests. If maintainers decide an RFC is necessary, they will request one from this issue and assign the RFC number.
11+
12+
If your agent explored the codebase to assess feasibility (e.g., using the `create-spike` skill), include its findings.
1113
1214
- type: textarea
1315
id: problem

‎AGENTS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ These pipelines connect skills into end-to-end workflows. Individual skill files
6262

6363
- **Bug reports** must include an agent diagnostic section — proof that the reporter's agent investigated the issue before filing. See the issue template.
6464
- **Feature requests** must include a design proposal, not just a "please build this" request. See the issue template.
65+
- **New features** must start as GitHub issues using the feature request template. Open an RFC only after an issue exists; maintainers decide when one is needed and assign RFC numbers from the issue.
6566
- **PRs** must follow the PR template structure: Summary, Related Issue, Changes, Testing, Checklist.
6667
- **PRs from unvouched external contributors** are automatically closed. See the Vouch System section above.
6768
- **Security vulnerabilities** must NOT be filed as GitHub issues. Follow [SECURITY.md](SECURITY.md).

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ These are the primary `mise` tasks for day-to-day development:
225225

226226
## RFCs
227227

228-
For cross-cutting architectural decisions, API contract changes, or process proposals that need broad consensus, use the RFC process. RFCs live in `rfc/` — copy the template, fill it in, and open a PR for discussion. See [rfc/README.md](rfc/README.md) for the full lifecycle and guidelines on when to write an RFC versus a spike issue or architecture doc.
228+
New features always start as GitHub issues using the feature request template. For cross-cutting architectural decisions, API contract changes, or process proposals that need broad consensus, maintainers may ask for an RFC from the issue and assign an RFC number there. RFCs live in `rfc/`. See [rfc/README.md](rfc/README.md) for the full lifecycle and guidelines.
229229

230230
## Documentation
231231

‎Cargo.lock‎

Lines changed: 78 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎README.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ All implementation work is human-gated — agents propose plans, humans approve,
237237
- [GitHub Sandbox Tutorial](https://docs.nvidia.com/openshell/latest/tutorials/github-sandbox) — end-to-end scoped GitHub repo access
238238
- [Architecture](https://github.com/NVIDIA/OpenShell/tree/main/architecture) — detailed architecture docs and design decisions
239239
- [Roadmap](https://github.com/orgs/NVIDIA/projects/233) — planned work and project priorities
240+
- [RFC Board](https://github.com/orgs/NVIDIA/projects/233/views/6) — RFC proposals tracked on the OpenShell Roadmap with the `rfc` label
240241
- [Support Matrix](https://docs.nvidia.com/openshell/latest/reference/support-matrix) — platforms, versions, and kernel requirements
241242
- [Brev Launchable](https://brev.nvidia.com/launchable/deploy/now?launchableID=env-3Ap3tL55zq4a8kew1AuW0FpSLsg) — try OpenShell on cloud compute without local setup
242243
- [Agent Instructions](AGENTS.md) — system prompt and workflow documentation for agent contributors

‎architecture/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ that crate's `README.md`.
169169

170170
## `rfc/` vs `architecture/`
171171

172-
For broad design proposals, use `rfc/`. Once an RFC is adopted, appropriate details should be written back to architecture docs.
172+
Broad design proposals start as GitHub issues. If maintainers decide a proposal needs broad consensus, they assign an RFC number from the issue and the RFC lives in `rfc/`. Once an RFC is adopted, appropriate details should be written back to architecture docs.
173173

174174
`architecture/` serves as the canonical reference for OpenShell's design and architecture.
175175

176-
`rfc` serves to help facilitate discussion and ensure features are appropriately designed. These are useful for understanding the context in which certain architecture designs were made.
176+
`rfc` serves to help facilitate discussion and ensure the few changes that need that level of review are appropriately designed. These are useful for understanding the context in which certain architecture designs were made.

‎architecture/gateway.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ Cluster inference routes store only `provider_name`, `model_id`, and optional
265265
timeout. The gateway resolves endpoint URLs, protocols, credentials, auth
266266
style, and route-shaping metadata from the provider record when supervisors call
267267
`GetInferenceBundle`. Supported provider types for cluster inference are
268-
`openai`, `anthropic`, `nvidia`, and `google-vertex-ai`.
268+
`openai`, `anthropic`, `nvidia`, `deepinfra`, and `google-vertex-ai`.
269269

270270
The bundle carries enough information for sandbox-local routers to construct
271271
upstream URLs without re-deriving provider-specific routing logic. Each resolved

‎crates/openshell-core/src/inference.rs‎

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,17 @@ static NVIDIA_PROFILE: InferenceProviderProfile = InferenceProviderProfile {
155155
passthrough_headers: &["x-model-id"],
156156
};
157157

158+
static DEEPINFRA_PROFILE: InferenceProviderProfile = InferenceProviderProfile {
159+
provider_type: "deepinfra",
160+
default_base_url: "https://api.deepinfra.com/v1/openai",
161+
protocols: OPENAI_PROTOCOLS,
162+
credential_key_names: &["DEEPINFRA_API_KEY"],
163+
base_url_config_keys: &["DEEPINFRA_BASE_URL"],
164+
auth: AuthHeader::Bearer,
165+
default_headers: &[],
166+
passthrough_headers: &["x-model-id"],
167+
};
168+
158169
/// Canonicalize an inference provider type string to a well-known identifier.
159170
///
160171
/// Returns `Some(canonical_name)` for recognized inference providers,
@@ -167,6 +178,7 @@ pub fn normalize_inference_provider_type(input: &str) -> Option<&'static str> {
167178
"openai" => Some("openai"),
168179
"anthropic" => Some("anthropic"),
169180
"nvidia" => Some("nvidia"),
181+
"deepinfra" => Some("deepinfra"),
170182
"google-vertex-ai" | "vertex" | "vertex-ai" | "google-vertex" | "gcp-vertex" => {
171183
Some("google-vertex-ai")
172184
}
@@ -183,6 +195,7 @@ pub fn profile_for(provider_type: &str) -> Option<&'static InferenceProviderProf
183195
"openai" => Some(&OPENAI_PROFILE),
184196
"anthropic" => Some(&ANTHROPIC_PROFILE),
185197
"nvidia" => Some(&NVIDIA_PROFILE),
198+
"deepinfra" => Some(&DEEPINFRA_PROFILE),
186199
"google-vertex-ai" => Some(&VERTEX_AI_PROFILE),
187200
_ => None,
188201
}
@@ -303,12 +316,24 @@ mod tests {
303316
assert!(profile_for("openai").is_some());
304317
assert!(profile_for("anthropic").is_some());
305318
assert!(profile_for("nvidia").is_some());
319+
assert!(profile_for("deepinfra").is_some());
306320
assert!(profile_for("OpenAI").is_some()); // case insensitive
307321
}
308322

323+
#[test]
324+
fn profile_for_deepinfra() {
325+
let profile = profile_for("deepinfra").expect("deepinfra profile should exist");
326+
assert_eq!(profile.provider_type, "deepinfra");
327+
assert_eq!(
328+
profile.default_base_url,
329+
"https://api.deepinfra.com/v1/openai"
330+
);
331+
assert_eq!(profile.auth, AuthHeader::Bearer);
332+
}
333+
309334
#[test]
310335
fn openai_compatible_profiles_include_embeddings() {
311-
for provider_type in ["openai", "nvidia"] {
336+
for provider_type in ["openai", "nvidia", "deepinfra"] {
312337
let profile = profile_for(provider_type).expect("provider profile should exist");
313338
assert!(
314339
profile.protocols.contains(&"openai_embeddings"),

‎crates/openshell-core/src/telemetry.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ pub enum ProviderProfile {
205205
Claude,
206206
Codex,
207207
Copilot,
208+
Deepinfra,
208209
Github,
209210
Gitlab,
210211
Nvidia,
@@ -222,6 +223,7 @@ impl ProviderProfile {
222223
Self::Claude => "claude",
223224
Self::Codex => "codex",
224225
Self::Copilot => "copilot",
226+
Self::Deepinfra => "deepinfra",
225227
Self::Github => "github",
226228
Self::Gitlab => "gitlab",
227229
Self::Nvidia => "nvidia",
@@ -239,6 +241,7 @@ impl ProviderProfile {
239241
"claude" | "claude-code" => Self::Claude,
240242
"codex" => Self::Codex,
241243
"copilot" => Self::Copilot,
244+
"deepinfra" => Self::Deepinfra,
242245
"github" | "gh" => Self::Github,
243246
"gitlab" | "glab" => Self::Gitlab,
244247
"nvidia" => Self::Nvidia,

‎crates/openshell-providers/src/lib.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ impl ProviderRegistry {
116116
registry.register(providers::openai::SPEC);
117117
registry.register(providers::anthropic::SPEC);
118118
registry.register(providers::nvidia::SPEC);
119+
registry.register(providers::deepinfra::SPEC);
119120
registry.register(providers::gitlab::SPEC);
120121
registry.register(providers::github::SPEC);
121122
registry.register(providers::outlook::OutlookProvider);

0 commit comments

Comments
 (0)