Skip to content

Commit 16fbc4d

Browse files
committed
fix(providers): reconcile import-only profiles with main
Signed-off-by: John Myers <[email protected]>
1 parent b67fba9 commit 16fbc4d

4 files changed

Lines changed: 12 additions & 6 deletions

File tree

‎crates/openshell-cli/tests/provider_commands_integration.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2173,7 +2173,7 @@ async fn provider_profile_permission_denial_preserves_safe_workspace_guidance()
21732173
seed_readiness_provider(&server).await;
21742174
for (profile, failed_lookup, expected_lookups) in [
21752175
("openai", "openai", vec!["openai"]),
2176-
("gh", "github", vec!["gh", "github"]),
2176+
("github", "github", vec!["github"]),
21772177
] {
21782178
server
21792179
.state
@@ -2260,12 +2260,12 @@ async fn provider_profile_permission_denial_preserves_safe_workspace_guidance()
22602260
}
22612261

22622262
#[tokio::test]
2263-
async fn provider_readiness_update_redacts_exact_and_alias_profile_lookup_errors() {
2263+
async fn provider_readiness_update_redacts_exact_profile_lookup_errors() {
22642264
let server = run_server().await;
22652265
seed_readiness_provider(&server).await;
22662266
for (profile, failed_lookup, expected_lookups) in [
22672267
("openai", "openai", vec!["openai"]),
2268-
("gh", "github", vec!["gh", "github"]),
2268+
("github", "github", vec!["github"]),
22692269
] {
22702270
server
22712271
.state

‎crates/openshell-server/src/grpc/provider.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14967,6 +14967,7 @@ mod tests {
1496714967
let response = handle_import_provider_profiles(
1496814968
&state,
1496914969
authed_request(ImportProviderProfilesRequest {
14970+
request_id: String::new(),
1497014971
profiles: vec![ProviderProfileImportItem {
1497114972
profile: Some(github),
1497214973
source: "providers/github.yaml".to_string(),

‎crates/openshell-server/src/grpc/sandbox.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4399,6 +4399,7 @@ mod tests {
43994399
let err = handle_create_sandbox(
44004400
&state,
44014401
authed_request(CreateSandboxRequest {
4402+
request_id: String::new(),
44024403
name: "orphan-sandbox".to_string(),
44034404
spec: Some(SandboxSpec {
44044405
providers: vec!["orphan".to_string()],
@@ -4441,6 +4442,7 @@ mod tests {
44414442
let err = handle_attach_sandbox_provider(
44424443
&state,
44434444
authed_request(AttachSandboxProviderRequest {
4445+
request_id: String::new(),
44444446
sandbox_name: "work".to_string(),
44454447
provider_name: "orphan".to_string(),
44464448
expected_resource_version: 0,

‎skills/openshell-cli/SKILL.md‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,14 @@ attachment and delete its sandbox after the service exits.
9090

9191
When supplying `--name`, use a portable DNS-1123 label: at most 63 lowercase alphanumeric or `-` characters, beginning and ending with an alphanumeric character. The Kubernetes driver rejects uppercase letters, underscores, dots, and other names that cannot become Kubernetes resource labels.
9292

93-
**Shortcut for known tools**: When the trailing command is a recognized tool, the CLI auto-creates the required provider from local credentials:
93+
Provider attachment is explicit. Name each provider with `--provider`; the
94+
trailing command does not select or attach one. If the named provider does not
95+
exist but a profile with that ID is available, the CLI can create it from local
96+
credentials:
9497

9598
```bash
96-
openshell sandbox create -- claude # Auto-creates claude provider
97-
openshell sandbox create -- codex # Auto-creates codex provider
99+
openshell sandbox create --provider claude-code -- claude
100+
openshell sandbox create --provider codex -- codex
98101
```
99102

100103
The agent will be prompted interactively if credentials are missing.

0 commit comments

Comments
 (0)