Skip to content

fix: support XDG-compliant Colima Docker socket path - #42

Merged
ericksoa merged 1 commit into
NVIDIA:mainfrom
martinmose:fix/colima-xdg-socket-path
Mar 16, 2026
Merged

ericksoa merged 1 commit into
NVIDIA:mainfrom
martinmose:fix/colima-xdg-socket-path

Conversation

@martinmose

Copy link
Copy Markdown
Contributor

Summary

  • Adds support for the XDG-compliant Colima socket path (~/.config/colima/default/docker.sock) in addition to the legacy path (~/.colima/default/docker.sock)
  • Updates socket detection logic consistently across onboard.js, runner.js, fix-coredns.sh, and setup.sh
  • Both paths are checked with the legacy path preferred for backward compatibility

Motivation

Newer Colima versions following the XDG Base Directory Specification place the Docker socket at ~/.config/colima/default/docker.sock instead of ~/.colima/default/docker.sock. This caused NemoClaw to fail to detect the Colima Docker socket on systems using the XDG layout.

Changes

File Change
bin/lib/onboard.js Check both socket paths when patching CoreDNS
bin/lib/runner.js Check both socket paths for DOCKER_HOST auto-detection
scripts/fix-coredns.sh Loop over both socket paths in shell script
scripts/setup.sh Loop over both socket paths for Docker host resolution

Colima versions using XDG base directories place the Docker socket at
~/.config/colima/default/docker.sock instead of the legacy
~/.colima/default/docker.sock. Update all socket detection logic to
check both paths, preferring the legacy path for backward compatibility.

@ericksoa ericksoa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean, consistent fix across all 4 files. Legacy path correctly takes priority for backward compatibility

@ericksoa
ericksoa merged commit 39dc36d into NVIDIA:main Mar 16, 2026
jessesanford pushed a commit to jessesanford/NemoClaw that referenced this pull request Mar 24, 2026
fix: support XDG-compliant Colima Docker socket path
mafueee pushed a commit to mafueee/NemoClaw that referenced this pull request Mar 28, 2026
…d revise error messages (NVIDIA#79)

Closes NVIDIA#42

- Change non-CONNECT proxy response from 405 to 403 to align with
  how CONNECT denials are surfaced
- Add structured deny logging for non-CONNECT requests with hostname
  extraction from absolute-form URIs
- Revise 7 user-facing error messages across proxy.rs and
  dev-sandbox-policy.rego to follow consistent principle: generic
  policy-deny messages for non-inference requests, descriptive messages
  for recognized inference endpoints
- Update E2E test assertion to match new error message
- Update architecture docs to reflect new behavior

Co-authored-by: John Myers <[email protected]>
@wscurran wscurran added the bug-fix PR fixes a bug or regression label Jun 8, 2026
zeekay pushed a commit to Dream-AI-4444/NemoClaw that referenced this pull request Sep 9, 2026
fix: support XDG-compliant Colima Docker socket path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix PR fixes a bug or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants