You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e7e8b67
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(e2e): centralize workflow plan output (#6970)
## Summary
Moves E2E plan validation, GitHub output emission, and execution-plan
summary rendering from the matrix-generation workflow shell into the
typed planner. Controller-dispatch identity validation intentionally
stays in the trusted inline workflow shell.
## Related Issue
Fixes#6955
## Changes
- Add `--ci-output` to the E2E workflow planner so it validates
selectors, inference mode, plan schema, and Hermes selection before
writing the four GitHub outputs and the equivalent job summary.
- Reduce the matrix-generation workflow step to a single planner
invocation while the workflow-boundary tests keep asserting the wiring.
- Keep controller-dispatch identity validation in the inline workflow
shell. The `generate-matrix` job checks out the untrusted PR commit
before the gate runs, so resolving the gate from a repo file would
execute PR-controlled code with `GITHUB_TOKEN` and could bypass its own
identity checks.
- Harden planner schema validation: reject `.`/`..` segments in
test-matrix file paths, and enforce id uniqueness across `matrix` and
`testMatrix` combined.
- Cover the `--ci-output` CLI handoff with a subprocess regression
driving the real CLI through `JOBS`/`TARGETS`, plus a mixed-selector
case that exits nonzero without writing outputs.
- Drop the report-to-pr planner-schema test and its fake-`npx` helper.
It stubbed planner stdout so the workflow shell could validate it with
`jq`; the planner now validates its own output, and the equivalent cases
live in `workflow-plan.test.ts`.
## Type of Change
- [x] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)
## Quality Gates
- [x] Tests added or updated for changed behavior
- [ ] Existing tests cover changed behavior — justification:
- [ ] Tests not applicable — justification:
- [ ] Docs updated for user-facing behavior changes
- [x] Docs not applicable — justification: internal GitHub Actions
workflow and E2E planner refactor; no user-facing behavior changed.
- [x] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [ ] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification:
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue: `E2E / PR Gate` — fork
PRs cannot dispatch credentialed E2E, so the gate times out waiting for
the trusted verdict; needs a maintainer dispatch or an approved skip.
## Verification
- [x] PR description includes a `Signed-off-by:` line and every commit
appears as `Verified` in GitHub
- [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or
`npm run check:diff` passed when hooks were skipped or unavailable
- [x] Targeted behavior tests pass for the current change set, or tests
are marked not applicable above — `npx vitest run --project e2e-support
test/e2e/support/workflow-plan.test.ts
test/e2e/support/e2e-workflow.test.ts
test/e2e/support/e2e-report-to-pr-workflow-boundary.test.ts` (84
passed); `npm run typecheck:cli` passed.
- [ ] Applicable broad gate passed — `npm test` for broad
runtime/test-harness changes; `npm run check` for repo-wide
validation/coverage changes — command/result:
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only)
- [ ] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)
---
Signed-off-by: harjoth <[email protected]>
Signed-off-by: harjoth <[email protected]>
Signed-off-by: Julie Yaunches <[email protected]>
Co-authored-by: Julie Yaunches <[email protected]>
0 commit comments