Repository navigation
Commit c81cb4f
committed
fix(sandbox): replace CIDR in NO_PROXY with explicit gateway IP; add ::1 test
- Replace 10.200.0.0/16 (CIDR) with 10.200.0.1 (explicit gateway IP).
Node.js undici EnvHttpProxyAgent matches NO_PROXY entries as exact
hostname strings or domain suffixes, not CIDR ranges. The CIDR entry
was silently ignored, routing all virtual-network IPs through the
proxy when they should be bypassed.
- Add test guard: extractProxyVars() now throws if the sed extraction
returns an empty block, surfacing script-format regressions as clear
failures instead of silent empty-env errors.
- Add ::1 (IPv6 loopback) assertion to the loopback exclusion test to
match the NO_PROXY entry already present in the script.
All 17 tests pass.
Addresses CodeRabbit review comments on PR #704.1 parent 623d878 commit c81cb4f
2 files changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
| 154 | + | |
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
122 | 128 | | |
123 | 129 | | |
124 | 130 | | |
| |||
169 | 175 | | |
170 | 176 | | |
171 | 177 | | |
| 178 | + | |
172 | 179 | | |
173 | 180 | | |
174 | 181 | | |
175 | | - | |
| 182 | + | |
176 | 183 | | |
177 | | - | |
| 184 | + | |
178 | 185 | | |
179 | 186 | | |
180 | 187 | | |
0 commit comments