Skip to content

Commit 921903a

Browse files
authored
Merge branch 'main' into fix/node-version-consistency
2 parents a5d67c9 + ca92680 commit 921903a

4 files changed

Lines changed: 53 additions & 4 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# .github/CODEOWNERS
2+
#
3+
# Auto-assigns reviewers to PRs. Each line maps a path pattern to one or more
4+
# GitHub teams. Last matching pattern wins. GitHub round-robins review requests
5+
# within each team to spread the load.
6+
#
7+
# Docs: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
8+
9+
# ── Fallback: maintainers review anything not matched below ──
10+
* @NVIDIA/nemoclaw-maintainer
11+
12+
# ── CLI plugin (Node/TS) ──
13+
/nemoclaw/ @NVIDIA/nemoclaw-maintainer
14+
/nemoclaw/src/onboard/ @NVIDIA/nemoclaw-engineer
15+
16+
# ── Blueprint & sandbox policy (Python) ──
17+
/nemoclaw-blueprint/ @NVIDIA/nemoclaw-maintainer
18+
/nemoclaw-blueprint/policies/ @NVIDIA/nemoclaw-security
19+
20+
# ── Shell scripts & installers ──
21+
/bin/ @NVIDIA/nemoclaw-maintainer
22+
/scripts/ @NVIDIA/nemoclaw-maintainer
23+
/install.sh @NVIDIA/nemoclaw-maintainer
24+
/uninstall.sh @NVIDIA/nemoclaw-maintainer
25+
26+
# ── Container ──
27+
/Dockerfile @NVIDIA/nemoclaw-security @NVIDIA/nemoclaw-maintainer
28+
29+
# ── Docs ──
30+
/docs/ @NVIDIA/nemoclaw-engineer
31+
/spark-install.md @NVIDIA/nemoclaw-engineer
32+
33+
# ── Tests ──
34+
/test/ @NVIDIA/nemoclaw-engineer
35+
36+
# ── CI / GitHub config ──
37+
/.github/ @NVIDIA/nemoclaw-maintainer
38+
/ci/ @NVIDIA/nemoclaw-maintainer

‎Dockerfile‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
2020
git=1:2.39.5-0+deb12u3 \
2121
ca-certificates=20230311+deb12u1 \
2222
iproute2=6.1.0-3 \
23+
iptables=1.8.9-2 \
2324
&& rm -rf /var/lib/apt/lists/*
2425

2526
# gosu for privilege separation (gateway vs sandbox user).

‎install.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ run_onboard() {
531531
fi
532532
}
533533

534-
# 6. Post-install message
534+
# 6. Post-install message (printed last — after onboarding — so PATH hints stay visible)
535535
# ---------------------------------------------------------------------------
536536
post_install_message() {
537537
# Only show shell reload instructions when Node was installed via a
@@ -600,7 +600,6 @@ main() {
600600
# install_or_upgrade_ollama
601601
install_nemoclaw
602602
verify_nemoclaw
603-
post_install_message
604603

605604
step 3 "Onboarding"
606605
if command_exists nemoclaw; then
@@ -610,6 +609,7 @@ main() {
610609
fi
611610

612611
print_done
612+
post_install_message
613613
}
614614

615615
main "$@"

‎test/e2e-gateway-isolation.sh‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,19 @@ else
159159
fail "symlink targets wrong:$FAILED_LINKS"
160160
fi
161161

162-
# ── Test 10: Sandbox user cannot kill gateway-user processes ─────
162+
# ── Test 10: iptables is installed (required for network policy enforcement) ──
163163

164-
info "10. Sandbox user cannot kill gateway-user processes"
164+
info "10. iptables is installed"
165+
OUT=$(run_as_root "iptables --version 2>&1")
166+
if echo "$OUT" | grep -q "iptables v"; then
167+
pass "iptables installed: $OUT"
168+
else
169+
fail "iptables not found — sandbox network policies will not be enforced: $OUT"
170+
fi
171+
172+
# ── Test 11: Sandbox user cannot kill gateway-user processes ─────
173+
174+
info "11. Sandbox user cannot kill gateway-user processes"
165175
# Start a dummy process as gateway, try to kill it as sandbox
166176
OUT=$(docker run --rm --entrypoint "" "$IMAGE" bash -c '
167177
gosu gateway sleep 60 &

0 commit comments

Comments
 (0)