You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 276fe0f
Browse filesBrowse the repository at this point in the historyBrowse files
## Outcome
Defines the fail-closed portable agent image contract for Hermes as the
first consumer and connects it to the existing provider-profile and
workload-source owners. An exact image can declare its tokenized agent
command without /usr/local/bin/nemoclaw-start. This slice keeps
activation disabled and does not qualify a provider.
## Reason
NemoClaw currently couples portable workload selection to
NemoClaw-managed image and startup assumptions. The accepted design
needs one contract boundary owned by the existing AgentDefinition,
RuntimeProviderWorkloadProfile, and workload-source path before Docker
or Podman can be qualified.
The [maintainer
decision](#11079 (comment))
records the Hermes-first scope, ownership, support status, compatibility
policy, evidence matrix, and OpenShell dependency boundary.
### Related issues
Refs #11079
Relates to NVIDIA/OpenShell#2761
## Changes
- Add a bounded, credential-free version 1 contract for an exact image
digest, tokenized startup arguments, non-root runtime identity,
OpenShell-owned workspace ownership, owner-only private state,
configuration location, and health behavior.
- Bind the declaration to the repository-owned Hermes command, version,
configuration, state, credential-name, and health semantics.
- Add portable capability advertisement to
RuntimeProviderWorkloadProfile and validate it during provider
registration.
- Project the selected provider capabilities through the existing
runtime boundary and select a valid exact portable image through the
existing workload-source resolver.
- Leave Docker, Podman, Kubernetes, and MXC without a portable
capability advertisement until each provider completes qualification.
- Reject every portable source before sandbox mutation in current
orchestration because supported activation is a later slice.
- Reject accessor-backed arrays without reading them and cover every
provider guarantee with focused rejection tests.
Stack position: 1 of 4.
Base: main.
Dependency order:
1. This contract, provider negotiation, and inert workload-selection PR.
2. Docker qualification with a non-NemoClaw Hermes fixture.
3. Native rootless Podman qualification with the same contract semantics
and Docker unavailable.
4. Qualified Hermes activation after the evidence and any required
OpenShell dependency are accepted.
## Verification
- npx vitest run --project cli with the five affected contract,
provider, source, runtime, and orchestration test files — 145 tests
passed.
- npm run typecheck:cli — passed.
- npm run checks:repository — passed.
- npm run validate:pr — passed against the PR base.
- GitHub commit verification — all five commits are verified.
- Reviewed the diff for secrets, API keys, and credential values; none
are present.
## Review notes
Current-base sensitive-path review context: NVIDIA/NemoClaw commit
`eaa5f00939679293a22ff8dd23e477eba4e88259` changes 12 files, all matched
by the canonical `src/lib/onboard/**` pattern. No independently readable
pre-publication review record exists for this exact candidate.
Post-publication review methods were
[CodeRabbit](#11130 (comment))
and all nine [PR Review Advisor
specialists](https://github.com/NVIDIA/NemoClaw/actions/runs/34059682968);
the outcome was no actionable comment or specialist finding, and
CodeRabbit rated merge risk Minimal. Required human review remains
outstanding.
The parser treats the declaration as untrusted input, rejects accessors
and non-JSON structures, applies byte, node, and depth limits, and does
not include rejected values in diagnostics. The provider registry is the
sole capability owner. No checked-in provider advertises portable
support, and orchestration rejects the source before mutation.
OpenShell v0.0.111 introduced the exact persisted canonical main-process
path in NVIDIA/OpenShell#2726. OCI ENTRYPOINT and CMD derivation remain
outside this contract. Provider qualification remains blocked until an
immutable OpenShell release contains the stop/start race fix from
NVIDIA/OpenShell#3132 (a6b757d35f98); the latest stable v0.0.116
predates that fix. Automatic crash restart from NVIDIA/OpenShell#2798 is
not part of the accepted qualification slice.
---
Signed-off-by: Apurv Kumaria <[email protected]>
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Added portable agent runtime contracts and portable-image workload
selection.
- Runtime providers can declare supported portable platforms and startup
capabilities.
- Added validation for images, agents, credentials, filesystem settings,
health checks, and provider compatibility.
- Workload capabilities now expose portable runtime support when
available on the current platform.
- **Bug Fixes**
- Portable-image workloads are rejected when activation is unavailable
or provider requirements are unmet.
- Added safeguards against conflicting Dockerfile and portable-image
configuration.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Signed-off-by: Apurv Kumaria <[email protected]>
0 commit comments