Skip to content

Commit 1fa10d3

Browse files
committed
fix: reject tgApi promise on Telegram ok:false responses
tgApi always resolved regardless of Telegram's ok field, so the Markdown retry fallback in reply() never fired on API errors like parse failures — only on network errors. Now rejects on ok:false, enabling the plain-text retry path. Addresses cv review feedback on #617.
1 parent 8143bfd commit 1fa10d3

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

‎scripts/adapters/messaging/telegram.js‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ module.exports = function createAdapter(config) {
3131
let buf = "";
3232
res.on("data", (c) => (buf += c));
3333
res.on("end", () => {
34-
try { resolve(JSON.parse(buf)); } catch { resolve({ ok: false, error: buf }); }
34+
try {
35+
const json = JSON.parse(buf);
36+
if (json.ok) resolve(json); else reject(new Error(json.description || "Telegram API error"));
37+
} catch { reject(new Error(`Unparseable Telegram response: ${buf.slice(0, 200)}`)); }
3538
});
3639
},
3740
);
@@ -46,9 +49,11 @@ module.exports = function createAdapter(config) {
4649
name: "telegram",
4750

4851
async start(onMessage) {
49-
const me = await tgApi("getMe", {});
50-
if (!me.ok) {
51-
throw new Error(`Failed to connect to Telegram: ${JSON.stringify(me)}`);
52+
let me;
53+
try {
54+
me = await tgApi("getMe", {});
55+
} catch (err) {
56+
throw new Error(`Failed to connect to Telegram: ${err.message}`);
5257
}
5358

5459
const botName = `@${me.result.username}`;

0 commit comments

Comments
 (0)