Skip to content

Adding timezone info to request header #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhongxuanwang-nv merged 3 commits into from
Sep 3, 2025
Merged

Adding timezone info to request header #38

zhongxuanwang-nv merged 3 commits into from
Sep 3, 2025

Conversation

@zhongxuanwang-nv
Copy link
Member

@zhongxuanwang-nv zhongxuanwang-nv commented Aug 16, 2025 •
edited by coderabbitai bot
Loading

Description

Added a new header option that includes the requester's device's timezone, in IANA format. This resonates with PR #660 for the NAT main repo.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • New Features
    • Chat responses are now timezone-aware. Your local timezone is automatically used to improve time-related answers (e.g., scheduling, dates, “today/tomorrow” references). If it can’t be detected, UTC is used. This works transparently with no settings changes required, and all other chat behavior remains unchanged.

@zhongxuanwang-nv zhongxuanwang-nv self-assigned this Aug 16, 2025
@zhongxuanwang-nv zhongxuanwang-nv added enhancement non-breaking Non-breaking change javascript Pull requests that update javascript code improvement Improvement to existing functionality labels Aug 16, 2025
@zhongxuanwang-nv zhongxuanwang-nv mentioned this pull request Aug 16, 2025
Merged
@zhongxuanwang-nv
Merge branch 'main' into main
a89144d 
Signed-off-by: Zhongxuan (Daniel) Wang <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Sep 3, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Added an X-Timezone header to the outbound request in pages/api/chat.ts, using Intl.DateTimeFormat().resolvedOptions().timeZone with a fallback to 'Etc/UTC'. No other request structure or exported/public signatures changed.

Changes

Cohort / File(s) Summary of Changes
API routing: chat completion request
pages/api/chat.ts		 Injects X-Timezone header into the outbound request; value from Intl.DateTimeFormat().resolvedOptions().timeZone with fallback to 'Etc/UTC'. No additional logic or error handling added.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant A as API Route (pages/api/chat.ts)
    participant S as Chat Completion Service

    C->>A: POST /api/chat (request)
    note over A: Determine timezone via Intl.DateTimeFormat().resolvedOptions().timeZone<br/>Fallback: 'Etc/UTC'
    A->>S: Forward request with headers<br/>... X-Timezone: <timezone>
    S-->>A: Response
    A-->>C: Response
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge a header, light as a breeze,
X-Timezone tucked in with effortless ease.
From sunlit burrows to midnight blue,
I stamp the time as rabbits do.
Hop, hop—requests now know the sky,
UTC waits if clouds drift by. 🐇🕰️

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3927806 and a89144d.

📒 Files selected for processing (1)
  • pages/api/chat.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zhongxuanwang-nv zhongxuanwang-nv merged commit fc982f6 into NVIDIA:main Sep 3, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willkill07 willkill07 willkill07 approved these changes

Assignees

@zhongxuanwang-nv zhongxuanwang-nv

Labels

improvement Improvement to existing functionality javascript Pull requests that update javascript code non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhongxuanwang-nv @willkill07