Skip to content

Conversation

@willkill07
Copy link
Member

@willkill07 willkill07 commented Oct 13, 2025

Description

  • Prefer the minimal set of dependencies required for Arize Phoenix.
  • Explicitly document when phoenix serve is required.
  • Add a file-based OTel example configuration.

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • New Features

    • Added file-based tracing option with a ready-to-use configuration for exporting OpenTelemetry traces to JSONL.
    • Expanded observability support with guidance for multiple monitoring platforms.
  • Documentation

    • Updated workflows and examples to include explicit Phoenix installation and startup steps, plus an accessibility note.
    • Revised getting started guides and notebooks to reflect the new setup flow.
    • Added a detailed section on file-based tracing and how to view exported traces.
    • Enhanced feature overviews and tables; removed outdated uninstall/reinstall debugging steps.

@willkill07 willkill07 requested review from a team as code owners October 13, 2025 18:01
@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

Walkthrough

Documentation and example updates introduce explicit Phoenix installation steps and file-based tracing. Dependencies shift to arize-phoenix-otel and arize-phoenix-client, with openinference-instrumentation added. Code changes include inlining Phoenix client construction in px_query and switching to dangerously_using_project in the Phoenix mixin. A new OTEL file tracing config is added.

Changes

Cohort / File(s) Change summary
Docs: Phoenix setup flow updates
docs/source/workflows/observe/observe-workflow-with-phoenix.md, examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml, examples/notebooks/4_observability_evaluation_and_profiling.ipynb
Added explicit Phoenix installation step; adjusted wording/order for accessibility and server start; removed uninstall/reinstall debug notes; updated comments/instructions accordingly.
Examples README and configs: Observability + file export
examples/observability/simple_calculator_observability/README.md, examples/observability/simple_calculator_observability/configs/config-otel-file.yml
Added file-based OTEL tracing workflow and config; expanded platform integrations; updated getting started sequence; listed new config in table; detailed commands and features.
Dependencies: Phoenix client/otel and consolidated extras
examples/advanced_agents/profiler_agent/pyproject.toml, examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml, packages/nvidia_nat_phoenix/pyproject.toml
Added arize-phoenix-client~=1.21.0; consolidated to nvidia-nat[langchain,phoenix]~=1.3; replaced arize-phoenix~=11.28 with arize-phoenix-otel~=0.13.1; added openinference-instrumentation.
Profiler agent: Phoenix client usage refactor
examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
Removed get_px_client; px_query now constructs phoenix.client.Client inline; updated calls to px_client.spans.get_spans_dataframe; renamed unused parameter to _builder.
Phoenix mixin: Project scoping change
packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
Replaced using_project(...) with dangerously_using_project(...); updated imports accordingly; no other logic changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant Tool as px_query
  participant PX as Phoenix Client
  Caller->>Tool: px_query(config, _builder)
  Tool->>PX: new Client(base_url=config.phoenix_url)
  alt last_n provided
    Tool->>PX: spans.get_spans_dataframe(last_n=...)
  else time range provided
    Tool->>PX: spans.get_spans_dataframe(start=..., end=...)
  end
  PX-->>Tool: DataFrame
  Tool-->>Caller: DataFrame or error
  note over Tool,PX: Client creation is now inline in px_query
Loading
sequenceDiagram
  autonumber
  participant App as App using PhoenixMixin
  participant Ctx as dangerously_using_project(project)
  participant Exporter as Phoenix Exporter
  App->>Ctx: enter context
  Ctx->>Exporter: scoped export operations
  Exporter-->>Ctx: completed
  Ctx-->>App: exit context
  note over Ctx: using dangerously_using_project instead of using_project
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly conveys the primary intent to reduce Phoenix dependencies in an imperative mood and follows the conventional commit “feat:” prefix style. It is concise, descriptive, and stays well under the 72-character recommendation.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@willkill07 willkill07 added feature request New feature or request breaking Breaking change labels Oct 13, 2025
@willkill07 willkill07 force-pushed the wkk_reduce-phoenix-dependencies branch from c402ab6 to acf0bc0 Compare October 13, 2025 18:03
@willkill07 willkill07 self-assigned this Oct 13, 2025
@coderabbitai coderabbitai bot added the improvement Improvement to existing functionality label Oct 13, 2025
@willkill07 willkill07 removed the feature request New feature or request label Oct 13, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (1)

98-100: Consider moving the import to module level.

While inline imports are acceptable, importing Client at the module level (after line 15) would be more consistent with Python conventions and slightly improve performance by avoiding repeated imports on each function call.

Apply this diff to move the import to module level:

 from datetime import datetime
 
+from phoenix.client import Client
 from pydantic import BaseModel

Then remove the inline import:

 async def px_query(config: PxQueryConfig, _builder: Builder):
     """Query the Phoenix server for a dataframe of LLM traces"""
-    from phoenix.client import Client
-
     px_client = Client(base_url=config.phoenix_url)
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff471c8 and acf0bc0.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • docs/source/workflows/observe/observe-workflow-with-phoenix.md (1 hunks)
  • examples/advanced_agents/profiler_agent/README.md (2 hunks)
  • examples/advanced_agents/profiler_agent/pyproject.toml (1 hunks)
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (3 hunks)
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml (1 hunks)
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml (1 hunks)
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb (2 hunks)
  • examples/observability/simple_calculator_observability/README.md (2 hunks)
  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml (1 hunks)
  • packages/nvidia_nat_phoenix/pyproject.toml (1 hunks)
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py (2 hunks)
🧰 Additional context used
📓 Path-based instructions (14)
**/*.{py,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

**/*.{py,yaml,yml}: Configure response_seq as a list of strings; values cycle per call, and [] yields an empty string.
Configure delay_ms to inject per-call artificial latency in milliseconds for nat_test_llm.

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
**/*.py

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

**/*.py: Programmatic use: create TestLLMConfig(response_seq=[...], delay_ms=...), add with builder.add_llm("", cfg).
When retrieving the test LLM wrapper, use builder.get_llm(name, wrapper_type=LLMFrameworkEnum.) and call the framework’s method (e.g., ainvoke, achat, call).

**/*.py: In code comments/identifiers use NAT abbreviations as specified: nat for API namespace/CLI, nvidia-nat for package name, NAT for env var prefixes; do not use these abbreviations in documentation
Follow PEP 20 and PEP 8; run yapf with column_limit=120; use 4-space indentation; end files with a single trailing newline
Run ruff check --fix as linter (not formatter) using pyproject.toml config; fix warnings unless explicitly ignored
Respect naming: snake_case for functions/variables, PascalCase for classes, UPPER_CASE for constants
Treat pyright warnings as errors during development
Exception handling: use bare raise to re-raise; log with logger.error() when re-raising to avoid duplicate stack traces; use logger.exception() when catching without re-raising
Provide Google-style docstrings for every public module, class, function, and CLI command; first line concise and ending with a period; surround code entities with backticks
Validate and sanitize all user input, especially in web or CLI interfaces
Prefer httpx with SSL verification enabled by default and follow OWASP Top-10 recommendations
Use async/await for I/O-bound work; profile CPU-heavy paths with cProfile or mprof before optimizing; cache expensive computations with functools.lru_cache or external cache; leverage NumPy vectorized operations when beneficial

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
packages/*/src/**/*.py

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Importable Python code inside packages must live under packages//src/

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
{src/**/*.py,packages/*/src/**/*.py}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

All public APIs must have Python 3.11+ type hints on parameters and return values; prefer typing/collections.abc abstractions; use typing.Annotated when useful

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
  • examples/advanced_agents/profiler_agent/pyproject.toml
  • examples/observability/simple_calculator_observability/README.md
  • examples/advanced_agents/profiler_agent/README.md
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb
  • packages/nvidia_nat_phoenix/pyproject.toml
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
packages/**/*

⚙️ CodeRabbit configuration file

packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain a pyproject.toml file. - The pyproject.toml file should declare a dependency on nvidia-nat or another package with a name starting
with nvidia-nat-. This dependency should be declared using ~=<version>, and the version should be a two
digit version (ex: ~=1.0).

  • Not all packages contain Python code, if they do they should also contain their own set of tests, in a
    tests/ directory at the same level as the pyproject.toml file.

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
  • packages/nvidia_nat_phoenix/pyproject.toml
**/*.{yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

In workflow/config YAML, set llms.._type: nat_test_llm to stub responses.

Files:

  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
**/configs/**

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Configuration files consumed by code must be stored next to that code in a configs/ folder

Files:

  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
examples/**/*

⚙️ CodeRabbit configuration file

examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.

  • If an example contains Python code, it should be placed in a subdirectory named src/ and should
    contain a pyproject.toml file. Optionally, it might also contain scripts in a scripts/ directory.
  • If an example contains YAML files, they should be placed in a subdirectory named configs/. - If an example contains sample data files, they should be placed in a subdirectory named data/, and should
    be checked into git-lfs.

Files:

  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
  • examples/advanced_agents/profiler_agent/pyproject.toml
  • examples/observability/simple_calculator_observability/README.md
  • examples/advanced_agents/profiler_agent/README.md
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
docs/source/**/*.md

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

docs/source/**/*.md: Use the official naming throughout documentation: first use “NVIDIA NeMo Agent toolkit”, subsequent “NeMo Agent toolkit”; never use deprecated names (Agent Intelligence toolkit, aiqtoolkit, AgentIQ, AIQ/aiq)
Documentation sources are Markdown files under docs/source; images belong in docs/source/_static
Keep docs in sync with code; documentation pipeline must pass Sphinx and link checks; avoid TODOs/FIXMEs/placeholders; avoid offensive/outdated terms; ensure spelling correctness
Do not use words listed in ci/vale/styles/config/vocabularies/nat/reject.txt; accepted terms in accept.txt are allowed

Files:

  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
docs/source/**/*

⚙️ CodeRabbit configuration file

This directory contains the source code for the documentation. All documentation should be written in Markdown format. Any image files should be placed in the docs/source/_static directory.

Files:

  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
**/README.@(md|ipynb)

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Ensure READMEs follow the naming convention; avoid deprecated names; use “NeMo Agent Toolkit” (capital T) in headings

Files:

  • examples/observability/simple_calculator_observability/README.md
  • examples/advanced_agents/profiler_agent/README.md
packages/*/pyproject.toml

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

packages/*/pyproject.toml: Each package must contain a pyproject.toml
In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Use ~= version constraints (e.g., ~=1.0) for dependencies

Files:

  • packages/nvidia_nat_phoenix/pyproject.toml
{packages/*/pyproject.toml,uv.lock}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Add new dependencies to both pyproject.toml (alphabetically) and uv.lock via uv pip install --sync

Files:

  • packages/nvidia_nat_phoenix/pyproject.toml
🧠 Learnings (1)
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to packages/*/pyproject.toml : In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-

Applied to files:

  • examples/advanced_agents/profiler_agent/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
🧬 Code graph analysis (1)
examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (1)
src/nat/builder/builder.py (1)
  • Builder (68-290)
🪛 markdownlint-cli2 (0.18.1)
docs/source/workflows/observe/observe-workflow-with-phoenix.md

25-25: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: CI Pipeline / Check
🔇 Additional comments (10)
docs/source/workflows/observe/observe-workflow-with-phoenix.md (1)

25-37: LGTM! Clear separation of installation steps.

The updated documentation now clearly distinguishes between:

  1. Installing the Phoenix subpackage (for NAT integration)
  2. Installing the Phoenix server (for the UI)

This separation improves clarity and helps users understand what's needed for each component.

examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml (1)

13-13: LGTM! Clean dependency consolidation.

The change consolidates dependencies by using the phoenix extra from nvidia-nat instead of declaring a direct dependency on arize-phoenix. This:

  • Simplifies dependency management
  • Ensures version compatibility
  • Aligns with the PR's goal of reducing dependencies
examples/notebooks/4_observability_evaluation_and_profiling.ipynb (1)

1204-1219: LGTM! Explicit Phoenix server installation step.

The addition of explicit Phoenix server installation instructions improves the notebook's completeness and aligns with the updated documentation pattern across the PR. The step-by-step approach helps users understand the distinct components needed.

examples/observability/simple_calculator_observability/configs/config-otel-file.yml (1)

17-29: LGTM! Well-designed file-based tracing configuration.

The file-based OTEL configuration provides a lightweight alternative to Phoenix for local development:

  • JSONL format is appropriate for streaming traces
  • mode: append allows accumulating traces across runs
  • enable_rolling: false simplifies debugging during development

This configuration aligns well with the PR's goal of providing minimal-dependency tracing options.

examples/observability/simple_calculator_observability/README.md (1)

79-99: LGTM! Excellent addition of file-based tracing option.

The new file-based tracing section provides:

  • Clear instructions for local development without external services
  • Good explanation of the JSONL format and its benefits
  • Well-defined use cases (debugging, offline analysis, custom tooling, archiving)

This gives developers a lightweight option for tracing without requiring Phoenix server setup.

packages/nvidia_nat_phoenix/pyproject.toml (1)

24-24: Verify OTEL package compatibility Confirmed arize-phoenix-otel~=0.13.1 exists on PyPI with dependencies openinference-instrumentation>=0.1.38, openinference-semantic-conventions>=0.1.17, opentelemetry-exporter-otlp, opentelemetry-proto>=1.12.0, opentelemetry-sdk, opentelemetry-semantic-conventions, typing-extensions<5,>=4.5, and wrapt. Ensure these new dependencies don't conflict with existing requirements and that uv.lock is updated accordingly.

examples/advanced_agents/profiler_agent/pyproject.toml (1)

19-19: Verify Phoenix client integration
The import of phoenix.client.Client in examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py:98 confirms direct usage; ensure the arize-phoenix-client~=1.21.0 constraint aligns with any other Phoenix dependencies and that the client is instantiated and configured correctly for its intended interactions.

examples/advanced_agents/profiler_agent/README.md (1)

39-39: LGTM!

The addition of "Natural Language Interface" as a key feature accurately describes the agent's capabilities.

examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (2)

96-96: LGTM!

Prefixing the unused builder parameter with an underscore follows Python convention for indicating intentionally unused parameters.


134-134: No changes required—API compatibility confirmed. spans.get_spans_dataframe() is supported in arize-phoenix-client v1.21.0.

@willkill07 willkill07 force-pushed the wkk_reduce-phoenix-dependencies branch from acf0bc0 to 66b6bb9 Compare October 13, 2025 18:20
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
examples/observability/simple_calculator_observability/README.md (1)

20-24: Fix casing for “NeMo Agent Toolkit”.

Line 20 spells the product name as “NeMo Agent toolkit”; per our documentation guidelines it must appear as “NeMo Agent Toolkit” (capital T). Please update the casing accordingly.

♻️ Duplicate comments (1)
packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py (1)

72-72: Address the previous review comment about documenting dangerously_using_project.

The prior review requested an inline comment above this line explaining:

  • Why a temporary project override is needed
  • The risks (data leakage, misrouting, analytics misattribution, billing/quota surprises)
  • When to use the standard using_project instead

This documentation has not been added yet.

🧹 Nitpick comments (1)
examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (1)

96-96: Consider removing the unused _builder parameter.

The _builder parameter is not used in the function. If it's required by the registration framework, add a comment explaining why it must be present despite being unused.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acf0bc0 and 66b6bb9.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (10)
  • docs/source/workflows/observe/observe-workflow-with-phoenix.md (1 hunks)
  • examples/advanced_agents/profiler_agent/pyproject.toml (1 hunks)
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (3 hunks)
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml (1 hunks)
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml (1 hunks)
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb (2 hunks)
  • examples/observability/simple_calculator_observability/README.md (2 hunks)
  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml (1 hunks)
  • packages/nvidia_nat_phoenix/pyproject.toml (1 hunks)
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml
  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb
🧰 Additional context used
📓 Path-based instructions (12)
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • examples/advanced_agents/profiler_agent/pyproject.toml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
  • packages/nvidia_nat_phoenix/pyproject.toml
  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
  • examples/observability/simple_calculator_observability/README.md
examples/**/*

⚙️ CodeRabbit configuration file

examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.

  • If an example contains Python code, it should be placed in a subdirectory named src/ and should
    contain a pyproject.toml file. Optionally, it might also contain scripts in a scripts/ directory.
  • If an example contains YAML files, they should be placed in a subdirectory named configs/. - If an example contains sample data files, they should be placed in a subdirectory named data/, and should
    be checked into git-lfs.

Files:

  • examples/advanced_agents/profiler_agent/pyproject.toml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • examples/observability/simple_calculator_observability/README.md
**/*.{py,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

**/*.{py,yaml,yml}: Configure response_seq as a list of strings; values cycle per call, and [] yields an empty string.
Configure delay_ms to inject per-call artificial latency in milliseconds for nat_test_llm.

Files:

  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
**/*.py

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

**/*.py: Programmatic use: create TestLLMConfig(response_seq=[...], delay_ms=...), add with builder.add_llm("", cfg).
When retrieving the test LLM wrapper, use builder.get_llm(name, wrapper_type=LLMFrameworkEnum.) and call the framework’s method (e.g., ainvoke, achat, call).

**/*.py: In code comments/identifiers use NAT abbreviations as specified: nat for API namespace/CLI, nvidia-nat for package name, NAT for env var prefixes; do not use these abbreviations in documentation
Follow PEP 20 and PEP 8; run yapf with column_limit=120; use 4-space indentation; end files with a single trailing newline
Run ruff check --fix as linter (not formatter) using pyproject.toml config; fix warnings unless explicitly ignored
Respect naming: snake_case for functions/variables, PascalCase for classes, UPPER_CASE for constants
Treat pyright warnings as errors during development
Exception handling: use bare raise to re-raise; log with logger.error() when re-raising to avoid duplicate stack traces; use logger.exception() when catching without re-raising
Provide Google-style docstrings for every public module, class, function, and CLI command; first line concise and ending with a period; surround code entities with backticks
Validate and sanitize all user input, especially in web or CLI interfaces
Prefer httpx with SSL verification enabled by default and follow OWASP Top-10 recommendations
Use async/await for I/O-bound work; profile CPU-heavy paths with cProfile or mprof before optimizing; cache expensive computations with functools.lru_cache or external cache; leverage NumPy vectorized operations when beneficial

Files:

  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
packages/*/src/**/*.py

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Importable Python code inside packages must live under packages//src/

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
{src/**/*.py,packages/*/src/**/*.py}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

All public APIs must have Python 3.11+ type hints on parameters and return values; prefer typing/collections.abc abstractions; use typing.Annotated when useful

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
packages/**/*

⚙️ CodeRabbit configuration file

packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain a pyproject.toml file. - The pyproject.toml file should declare a dependency on nvidia-nat or another package with a name starting
with nvidia-nat-. This dependency should be declared using ~=<version>, and the version should be a two
digit version (ex: ~=1.0).

  • Not all packages contain Python code, if they do they should also contain their own set of tests, in a
    tests/ directory at the same level as the pyproject.toml file.

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
  • packages/nvidia_nat_phoenix/pyproject.toml
packages/*/pyproject.toml

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

packages/*/pyproject.toml: Each package must contain a pyproject.toml
In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Use ~= version constraints (e.g., ~=1.0) for dependencies

Files:

  • packages/nvidia_nat_phoenix/pyproject.toml
{packages/*/pyproject.toml,uv.lock}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Add new dependencies to both pyproject.toml (alphabetically) and uv.lock via uv pip install --sync

Files:

  • packages/nvidia_nat_phoenix/pyproject.toml
docs/source/**/*.md

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

docs/source/**/*.md: Use the official naming throughout documentation: first use “NVIDIA NeMo Agent toolkit”, subsequent “NeMo Agent toolkit”; never use deprecated names (Agent Intelligence toolkit, aiqtoolkit, AgentIQ, AIQ/aiq)
Documentation sources are Markdown files under docs/source; images belong in docs/source/_static
Keep docs in sync with code; documentation pipeline must pass Sphinx and link checks; avoid TODOs/FIXMEs/placeholders; avoid offensive/outdated terms; ensure spelling correctness
Do not use words listed in ci/vale/styles/config/vocabularies/nat/reject.txt; accepted terms in accept.txt are allowed

Files:

  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
docs/source/**/*

⚙️ CodeRabbit configuration file

This directory contains the source code for the documentation. All documentation should be written in Markdown format. Any image files should be placed in the docs/source/_static directory.

Files:

  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
**/README.@(md|ipynb)

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Ensure READMEs follow the naming convention; avoid deprecated names; use “NeMo Agent Toolkit” (capital T) in headings

Files:

  • examples/observability/simple_calculator_observability/README.md
🧠 Learnings (1)
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to packages/*/pyproject.toml : In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-

Applied to files:

  • examples/advanced_agents/profiler_agent/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
🧬 Code graph analysis (1)
examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (1)
src/nat/builder/builder.py (1)
  • Builder (68-290)
🪛 markdownlint-cli2 (0.18.1)
docs/source/workflows/observe/observe-workflow-with-phoenix.md

25-25: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)

🔇 Additional comments (1)
examples/advanced_agents/profiler_agent/pyproject.toml (1)

19-19: Sort dependencies alphabetically.

The arize-phoenix-client dependency should appear before nvidia-nat to maintain alphabetical ordering as specified in the coding guidelines.

Apply this diff to fix the ordering:

   # Keep sorted!!!
+  "arize-phoenix-client~=1.21.0",
   "nvidia-nat[langchain,profiling,telemetry]~=1.3",
-  "arize-phoenix-client~=1.21.0",
   "pydantic", # version determined by nvidia-nat

Based on coding guidelines.

Likely an incorrect or invalid review comment.

@willkill07 willkill07 changed the title feat: Reduce phoenix dependencies feat: reduce phoenix dependencies Oct 13, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66b6bb9 and 58036a0.

📒 Files selected for processing (22)
  • packages/nvidia_nat_adk/pyproject.toml (1 hunks)
  • packages/nvidia_nat_agno/pyproject.toml (1 hunks)
  • packages/nvidia_nat_all/pyproject.toml (1 hunks)
  • packages/nvidia_nat_crewai/pyproject.toml (1 hunks)
  • packages/nvidia_nat_data_flywheel/pyproject.toml (1 hunks)
  • packages/nvidia_nat_ingestion/pyproject.toml (1 hunks)
  • packages/nvidia_nat_langchain/pyproject.toml (1 hunks)
  • packages/nvidia_nat_llama_index/pyproject.toml (1 hunks)
  • packages/nvidia_nat_mcp/pyproject.toml (1 hunks)
  • packages/nvidia_nat_mem0ai/pyproject.toml (1 hunks)
  • packages/nvidia_nat_mysql/pyproject.toml (1 hunks)
  • packages/nvidia_nat_opentelemetry/pyproject.toml (1 hunks)
  • packages/nvidia_nat_phoenix/pyproject.toml (2 hunks)
  • packages/nvidia_nat_profiling/pyproject.toml (1 hunks)
  • packages/nvidia_nat_ragaai/pyproject.toml (1 hunks)
  • packages/nvidia_nat_redis/pyproject.toml (1 hunks)
  • packages/nvidia_nat_s3/pyproject.toml (1 hunks)
  • packages/nvidia_nat_semantic_kernel/pyproject.toml (1 hunks)
  • packages/nvidia_nat_test/pyproject.toml (1 hunks)
  • packages/nvidia_nat_weave/pyproject.toml (1 hunks)
  • packages/nvidia_nat_zep_cloud/pyproject.toml (1 hunks)
  • pyproject.toml (1 hunks)
✅ Files skipped from review due to trivial changes (12)
  • packages/nvidia_nat_agno/pyproject.toml
  • packages/nvidia_nat_mcp/pyproject.toml
  • packages/nvidia_nat_redis/pyproject.toml
  • packages/nvidia_nat_test/pyproject.toml
  • packages/nvidia_nat_mysql/pyproject.toml
  • packages/nvidia_nat_ingestion/pyproject.toml
  • pyproject.toml
  • packages/nvidia_nat_ragaai/pyproject.toml
  • packages/nvidia_nat_adk/pyproject.toml
  • packages/nvidia_nat_langchain/pyproject.toml
  • packages/nvidia_nat_opentelemetry/pyproject.toml
  • packages/nvidia_nat_crewai/pyproject.toml
🧰 Additional context used
📓 Path-based instructions (4)
packages/*/pyproject.toml

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

packages/*/pyproject.toml: Each package must contain a pyproject.toml
In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Use ~= version constraints (e.g., ~=1.0) for dependencies

Files:

  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
{packages/*/pyproject.toml,uv.lock}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Add new dependencies to both pyproject.toml (alphabetically) and uv.lock via uv pip install --sync

Files:

  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
packages/**/*

⚙️ CodeRabbit configuration file

packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain a pyproject.toml file. - The pyproject.toml file should declare a dependency on nvidia-nat or another package with a name starting
with nvidia-nat-. This dependency should be declared using ~=<version>, and the version should be a two
digit version (ex: ~=1.0).

  • Not all packages contain Python code, if they do they should also contain their own set of tests, in a
    tests/ directory at the same level as the pyproject.toml file.

Files:

  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
🧠 Learnings (1)
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to packages/*/pyproject.toml : In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-

Applied to files:

  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: CI Pipeline / Check

@willkill07 willkill07 force-pushed the wkk_reduce-phoenix-dependencies branch from 58036a0 to 5bf4034 Compare October 14, 2025 13:15
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (2)
docs/source/workflows/observe/observe-workflow-with-phoenix.md (1)

25-25: Fix heading level to properly increment from h1.

The heading uses h3 (###) but should use h2 (##) to properly increment from the h1 heading at line 18. This violates the MD001 markdown rule for heading increments.

examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (1)

98-100: Move import to module level.

The from phoenix.client import Client import should be at the module level (top of file) rather than inside the function. Inline imports are generally discouraged per PEP 8 unless there's a specific reason (e.g., circular imports, optional dependencies).

Based on coding guidelines (PEP 8).

🧹 Nitpick comments (2)
examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml (2)

17-18: Scope the note to when Phoenix tracing is enabled

Clarify that phoenix serve is only needed if the Phoenix tracing block is enabled. Suggested tweak:

-# Uncomment the following to enable tracing.
-# Install `arize-phoenix` and run `phoenix serve` before launching
+# Uncomment the following to enable Phoenix tracing.
+# If enabling it, first `pip install arize-phoenix` and start `phoenix serve` in a separate terminal before launching.

50-70: Provide a commented nat_test_llm stub for CI/local testing

Per config guidelines, consider adding an optional, commented stub LLM to avoid real calls during tests. Example to append under llms (commented by default), plus a note on how to toggle:

# nat_test_llm:
#   _type: nat_test_llm
#   # Responses cycle per call; [] yields empty string
#   response_seq:
#     - "42"
#     - "OK"
#   # Optional artificial latency in ms
#   delay_ms: 0

You can then set workflow.llm_name: nat_test_llm when stubbing. This keeps the example runnable while supporting CI.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58036a0 and 5bf4034.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (10)
  • docs/source/workflows/observe/observe-workflow-with-phoenix.md (1 hunks)
  • examples/advanced_agents/profiler_agent/pyproject.toml (1 hunks)
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (3 hunks)
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml (1 hunks)
  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml (1 hunks)
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb (2 hunks)
  • examples/observability/simple_calculator_observability/README.md (2 hunks)
  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml (1 hunks)
  • packages/nvidia_nat_phoenix/pyproject.toml (1 hunks)
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • examples/observability/simple_calculator_observability/configs/config-otel-file.yml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • examples/advanced_agents/profiler_agent/pyproject.toml
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

In workflow/config YAML, set llms.._type: nat_test_llm to stub responses.

Files:

  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
**/*.{py,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

**/*.{py,yaml,yml}: Configure response_seq as a list of strings; values cycle per call, and [] yields an empty string.
Configure delay_ms to inject per-call artificial latency in milliseconds for nat_test_llm.

Files:

  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
**/configs/**

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Configuration files consumed by code must be stored next to that code in a configs/ folder

Files:

  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • examples/observability/simple_calculator_observability/README.md
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb
  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
examples/**/*

⚙️ CodeRabbit configuration file

examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.

  • If an example contains Python code, it should be placed in a subdirectory named src/ and should
    contain a pyproject.toml file. Optionally, it might also contain scripts in a scripts/ directory.
  • If an example contains YAML files, they should be placed in a subdirectory named configs/. - If an example contains sample data files, they should be placed in a subdirectory named data/, and should
    be checked into git-lfs.

Files:

  • examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml
  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • examples/observability/simple_calculator_observability/README.md
  • examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml
  • examples/notebooks/4_observability_evaluation_and_profiling.ipynb
**/*.py

📄 CodeRabbit inference engine (.cursor/rules/nat-test-llm.mdc)

**/*.py: Programmatic use: create TestLLMConfig(response_seq=[...], delay_ms=...), add with builder.add_llm("", cfg).
When retrieving the test LLM wrapper, use builder.get_llm(name, wrapper_type=LLMFrameworkEnum.) and call the framework’s method (e.g., ainvoke, achat, call).

**/*.py: In code comments/identifiers use NAT abbreviations as specified: nat for API namespace/CLI, nvidia-nat for package name, NAT for env var prefixes; do not use these abbreviations in documentation
Follow PEP 20 and PEP 8; run yapf with column_limit=120; use 4-space indentation; end files with a single trailing newline
Run ruff check --fix as linter (not formatter) using pyproject.toml config; fix warnings unless explicitly ignored
Respect naming: snake_case for functions/variables, PascalCase for classes, UPPER_CASE for constants
Treat pyright warnings as errors during development
Exception handling: use bare raise to re-raise; log with logger.error() when re-raising to avoid duplicate stack traces; use logger.exception() when catching without re-raising
Provide Google-style docstrings for every public module, class, function, and CLI command; first line concise and ending with a period; surround code entities with backticks
Validate and sanitize all user input, especially in web or CLI interfaces
Prefer httpx with SSL verification enabled by default and follow OWASP Top-10 recommendations
Use async/await for I/O-bound work; profile CPU-heavy paths with cProfile or mprof before optimizing; cache expensive computations with functools.lru_cache or external cache; leverage NumPy vectorized operations when beneficial

Files:

  • examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py
  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
**/README.@(md|ipynb)

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Ensure READMEs follow the naming convention; avoid deprecated names; use “NeMo Agent Toolkit” (capital T) in headings

Files:

  • examples/observability/simple_calculator_observability/README.md
packages/*/src/**/*.py

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Importable Python code inside packages must live under packages//src/

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
{src/**/*.py,packages/*/src/**/*.py}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

All public APIs must have Python 3.11+ type hints on parameters and return values; prefer typing/collections.abc abstractions; use typing.Annotated when useful

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
packages/**/*

⚙️ CodeRabbit configuration file

packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain a pyproject.toml file. - The pyproject.toml file should declare a dependency on nvidia-nat or another package with a name starting
with nvidia-nat-. This dependency should be declared using ~=<version>, and the version should be a two
digit version (ex: ~=1.0).

  • Not all packages contain Python code, if they do they should also contain their own set of tests, in a
    tests/ directory at the same level as the pyproject.toml file.

Files:

  • packages/nvidia_nat_phoenix/src/nat/plugins/phoenix/mixin/phoenix_mixin.py
docs/source/**/*.md

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

docs/source/**/*.md: Use the official naming throughout documentation: first use “NVIDIA NeMo Agent toolkit”, subsequent “NeMo Agent toolkit”; never use deprecated names (Agent Intelligence toolkit, aiqtoolkit, AgentIQ, AIQ/aiq)
Documentation sources are Markdown files under docs/source; images belong in docs/source/_static
Keep docs in sync with code; documentation pipeline must pass Sphinx and link checks; avoid TODOs/FIXMEs/placeholders; avoid offensive/outdated terms; ensure spelling correctness
Do not use words listed in ci/vale/styles/config/vocabularies/nat/reject.txt; accepted terms in accept.txt are allowed

Files:

  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
docs/source/**/*

⚙️ CodeRabbit configuration file

This directory contains the source code for the documentation. All documentation should be written in Markdown format. Any image files should be placed in the docs/source/_static directory.

Files:

  • docs/source/workflows/observe/observe-workflow-with-phoenix.md
🧬 Code graph analysis (1)
examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/px_query.py (1)
src/nat/builder/builder.py (1)
  • Builder (68-290)
🪛 LanguageTool
examples/observability/simple_calculator_observability/README.md

[grammar] ~95-~95: There might be a mistake here.
Context: ...ng a complete trace. This is useful for: - Quick debugging during development - Off...

(QB_NEW_EN)


[grammar] ~96-~96: There might be a mistake here.
Context: ...or: - Quick debugging during development - Offline analysis of workflow execution -...

(QB_NEW_EN)


[grammar] ~97-~97: There might be a mistake here.
Context: ...- Offline analysis of workflow execution - Integration with custom analysis tools -...

(QB_NEW_EN)


[grammar] ~98-~98: There might be a mistake here.
Context: ...- Integration with custom analysis tools - Archiving traces for later review ### P...

(QB_NEW_EN)


[grammar] ~221-~221: There might be a mistake here.
Context: ... tracing for development and debugging | | config-langfuse.yml | Langfuse | Pro...

(QB_NEW_EN)

🪛 markdownlint-cli2 (0.18.1)
docs/source/workflows/observe/observe-workflow-with-phoenix.md

25-25: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)

🔇 Additional comments (4)
examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml (1)

13-13: LGTM! Clean dependency consolidation.

The consolidation of Phoenix dependencies into the main package extras (nvidia-nat[langchain,phoenix]) is a clean improvement that simplifies dependency management and aligns with the PR's objective of reducing direct Phoenix dependencies.

examples/notebooks/4_observability_evaluation_and_profiling.ipynb (1)

1204-1219: LGTM! Clear Phoenix installation flow.

The addition of explicit Phoenix installation steps and the updated narrative flow ("First... Then... Finally...") provides clear, sequential instructions that align with the updated documentation and improve the user experience.

examples/observability/simple_calculator_observability/README.md (1)

60-99: LGTM! Excellent documentation improvements.

The reordered installation flow (install Phoenix first, then start) is more logical, and the new File-Based Tracing section provides a valuable lightweight option for local development. The documentation is comprehensive and well-structured, covering both development and production scenarios effectively.

examples/getting_started/simple_calculator/src/nat_simple_calculator/configs/config-reasoning.yml (1)

61-64: No change needed for model_name gpt-3.5-turbo remains available as of October 2025; example is up to date.

@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 119d6ea into NVIDIA:release/1.3 Oct 14, 2025
17 checks passed
@willkill07 willkill07 deleted the wkk_reduce-phoenix-dependencies branch October 23, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change improvement Improvement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants