Skip to content

Fix bug where --workers flag was being ignored #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdemoret-nv merged 1 commit into from
Apr 4, 2025
Merged

Fix bug where --workers flag was being ignored #88

mdemoret-nv merged 1 commit into from
Apr 4, 2025

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 4, 2025

Description

  • aiq serve was ignoring the --workers flag.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 4, 2025
@dagardner-nv dagardner-nv self-assigned this Apr 4, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner April 4, 2025 23:00
@mdemoret-nv mdemoret-nv merged commit 34f5e09 into NVIDIA:develop Apr 4, 2025
10 checks passed
@dagardner-nv dagardner-nv deleted the david-serve-workers branch April 4, 2025 23:14
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 5, 2025
@dagardner-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
81c1adb 
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: Eric Evans <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 5, 2025
@dagardner-nv @ericevans-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
213d6aa 
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: Eric Evans <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 5, 2025
@dagardner-nv @ericevans-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
94bd8db 
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: Eric Evans <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 14, 2025
@dagardner-nv @ericevans-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
e8b21c2 
Signed-off-by: David Gardner <[email protected]>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request Apr 21, 2025
@dagardner-nv @yczhang-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
b17ab49 
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@dagardner-nv @yczhang-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
1eca70a 
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@dagardner-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
d942ee6 
Signed-off-by: David Gardner <[email protected]>
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@dagardner-nv
Fix bug where --workers flag was being ignored (NVIDIA#88)
618b486 
Signed-off-by: David Gardner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dagardner-nv @mdemoret-nv