Adopt ruff in CI #694

dagardner-nv · 2025-08-21T18:09:03Z

Replace isort, flake8 and pylint with ruff check
Retain yapf for formatting. The reason is that ruff format is explicitly focused on being a drop-in replacement for Black, offering very few configuration options ref: https://docs.astral.sh/ruff/formatter/#configuration
Update code to pass ruff check. Note previously not all of our code was passing with Pylint, so retaining Pylint would have likely required many of the same changes.

By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will not be accepted.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: David Gardner <[email protected]>

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

Signed-off-by: David Gardner <[email protected]>

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

Signed-off-by: David Gardner <[email protected]>

…LEASE REVERT Signed-off-by: David Gardner <[email protected]>

Signed-off-by: David Gardner <[email protected]>

Ruff format offers very few formatting options, this is by design: https://docs.astral.sh/ruff/formatter/#configuration Specifically they chose compatibility with Black rather than YAPF This reverts commit 99d3668. Signed-off-by: David Gardner <[email protected]>

Signed-off-by: David Gardner <[email protected]>

…MERGE! PLEASE REVERT" This reverts commit 140c5dc. Signed-off-by: David Gardner <[email protected]>

Signed-off-by: David Gardner <[email protected]>

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

Signed-off-by: David Gardner <[email protected]>

ci/scripts/path_checks.py

pyproject.toml

Copilot

Pull Request Overview

This PR adopts ruff as the primary linting tool, replacing isort, flake8, and pylint in the CI/CD pipeline. The change modernizes the codebase's linting approach while retaining yapf for formatting due to ruff format's limited configuration options compared to yapf.

Replace multiple linting tools (isort, flake8, pylint) with a single ruff configuration
Update codebase to pass ruff checks by removing pylint-specific disable comments and fixing import order
Modernize pyproject.toml configuration with simplified ruff settings

Reviewed Changes

Copilot reviewed 218 out of 219 changed files in this pull request and generated 4 comments.

File	Description
pyproject.toml	Replaces pylint/flake8/isort configuration with streamlined ruff settings
Multiple test/source files	Removes pylint disable comments and fixes import ordering per ruff rules
nat.code-workspace	Updates VS Code workspace to use ruff instead of multiple linting extensions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/nat/tool/code_execution/utils.py

src/nat/profiler/inference_optimization/token_uniqueness.py

src/nat/profiler/inference_optimization/bottleneck_analysis/simple_stack_analysis.py

examples/advanced_agents/profiler_agent/src/nat_profiler_agent/tool/token_usage.py

Signed-off-by: David Gardner <[email protected]>

…mple_stack_analysis.py Co-authored-by: Copilot <[email protected]> Signed-off-by: David Gardner <[email protected]>

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

coderabbitai · 2025-08-22T20:20:09Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

107 files out of 214 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dagardner-nv · 2025-08-22T20:20:14Z

@coderabbitai review

coderabbitai · 2025-08-22T20:20:21Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

dagardner-nv · 2025-08-22T20:32:02Z

/merge

dagardner-nv added 25 commits August 14, 2025 13:20

Add dependency for ruff

a9af704

Signed-off-by: David Gardner <[email protected]>

Remove unused imports

c3db4f8

Signed-off-by: David Gardner <[email protected]>

Add long-line testing

737cf38

Signed-off-by: David Gardner <[email protected]>

Use is when comparing types

95a9535

Signed-off-by: David Gardner <[email protected]>

Merge branch 'develop' of github.com:NVIDIA/NeMo-Agent-Toolkit into d…

ff23df9

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

Use is when comparing types

d7d172f

Signed-off-by: David Gardner <[email protected]>

Use is when comparing types

22fed2a

Signed-off-by: David Gardner <[email protected]>

Use is when comparing types

ac5dba1

Signed-off-by: David Gardner <[email protected]>

Use is when comparing types

8d33a80

Signed-off-by: David Gardner <[email protected]>

Use is when comparing types

bf3bd82

Signed-off-by: David Gardner <[email protected]>

Use is when comparing types

d64d430

Signed-off-by: David Gardner <[email protected]>

Add ruff to pre-commit

2acc761

Signed-off-by: David Gardner <[email protected]>

WIP

f8f5511

Signed-off-by: David Gardner <[email protected]>

Merge branch 'develop' of github.com:NVIDIA/NeMo-Agent-Toolkit into d…

b784fab

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

Merge branch 'develop' of github.com:NVIDIA/NeMo-Agent-Toolkit into d…

7d7e563

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

Remove #noqa comment inside of prompt string

aef187c

Signed-off-by: David Gardner <[email protected]>

Remove the C901 check

dcf1b03

Signed-off-by: David Gardner <[email protected]>

Shorten long lines in notebooks

7ec6242

Signed-off-by: David Gardner <[email protected]>

Remove flake8 as ruff performs the same checks

3969953

Signed-off-by: David Gardner <[email protected]>

Temporarily disable the link checker because its slow DO NOT MERGE! P…

140c5dc

…LEASE REVERT Signed-off-by: David Gardner <[email protected]>

Enable ruff format

99d3668

Signed-off-by: David Gardner <[email protected]>

Remove unused commented out lines

4d2bfcb

Signed-off-by: David Gardner <[email protected]>

Remove dependency on flake8

7558e0f

Signed-off-by: David Gardner <[email protected]>

Add --fix flag

e38c518

Signed-off-by: David Gardner <[email protected]>

dagardner-nv self-assigned this Aug 21, 2025

dagardner-nv added improvement Improvement to existing functionality skip-ci Optionally Skip CI for this PR non-breaking Non-breaking change labels Aug 21, 2025

Add the D rules from flake8

d990800

Signed-off-by: David Gardner <[email protected]>

dagardner-nv added 9 commits August 22, 2025 08:46

Remove the need to use the global statement

b453d00

Signed-off-by: David Gardner <[email protected]>

Collapse compound max calls

45dd210

Signed-off-by: David Gardner <[email protected]>

Remove old pylint comments

6793a1f

Signed-off-by: David Gardner <[email protected]>

Lint fixes

591de97

Signed-off-by: David Gardner <[email protected]>

Remove flake8 args

41104de

Signed-off-by: David Gardner <[email protected]>

Revert "Temporarily disable the link checker because its slow DO NOT …

dc26503

…MERGE! PLEASE REVERT" This reverts commit 140c5dc. Signed-off-by: David Gardner <[email protected]>

Remove flake8, isort and pylint from cursor rules

d5b4f35

Signed-off-by: David Gardner <[email protected]>

Remove isort and pylint settings

588bbc7

Signed-off-by: David Gardner <[email protected]>

Lint fixes

60cac60

Signed-off-by: David Gardner <[email protected]>

dagardner-nv marked this pull request as ready for review August 22, 2025 16:58

dagardner-nv added 3 commits August 22, 2025 09:58

Merge branch 'develop' of github.com:NVIDIA/NeMo-Agent-Toolkit into d…

6480e7a

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

ruff doesn't support E131, and it isn't needed here

e9785fc

Signed-off-by: David Gardner <[email protected]>

Revert unintended changes

04ab308

Signed-off-by: David Gardner <[email protected]>

willkill07 reviewed Aug 22, 2025

View reviewed changes

ci/scripts/path_checks.py Outdated Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

dagardner-nv requested a review from Copilot August 22, 2025 17:10

Copilot AI reviewed Aug 22, 2025

View reviewed changes

dagardner-nv and others added 5 commits August 22, 2025 10:38

Restore unintentional changes

a50e3f3

Signed-off-by: David Gardner <[email protected]>

Revert unintended changes

28dd7d0

Signed-off-by: David Gardner <[email protected]>

Remove out of date comments

9dad55f

Signed-off-by: David Gardner <[email protected]>

Remove old pylint comment

3ebaec5

Signed-off-by: David Gardner <[email protected]>

Update src/nat/profiler/inference_optimization/bottleneck_analysis/si…

c4a95e0

…mple_stack_analysis.py Co-authored-by: Copilot <[email protected]> Signed-off-by: David Gardner <[email protected]>

dagardner-nv requested a review from willkill07 August 22, 2025 17:49

willkill07 approved these changes Aug 22, 2025

View reviewed changes

Merge branch 'develop' of github.com:NVIDIA/NeMo-Agent-Toolkit into d…

40773c5

…avid-ci-ruff Signed-off-by: David Gardner <[email protected]>

rapids-bot bot merged commit 5aca747 into NVIDIA:develop Aug 22, 2025
13 checks passed

dagardner-nv deleted the david-ci-ruff branch August 22, 2025 20:32

Adopt ruff in CI #694

Adopt ruff in CI #694

Uh oh!

Conversation

dagardner-nv commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

By Submitting this PR I confirm:

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

dagardner-nv commented Aug 22, 2025

Uh oh!

coderabbitai bot commented Aug 22, 2025

Uh oh!

dagardner-nv commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dagardner-nv commented Aug 21, 2025 •

edited

Loading

coderabbitai bot commented Aug 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)