Skip to content

Conversation

@zhongxuanwang-nv
Copy link
Member

@zhongxuanwang-nv zhongxuanwang-nv commented Aug 16, 2025

Description

  • Added timezone support for the datetime_tools, so now it will automatically extract the x-timezone from the headers from context, which will be used to format the current time.

    • If the x-timezone is not present in the headers, default UTC time is used.
    • The documentations should also be clear now.
  • Fixed a small issue in NeMo-Agent-Toolkit/src/nat/builder/user_interaction_manager.py. Before the timestamp is in UTC (as seen by the Z suffix in the timestamp), but the timestamp is in the local timezone, which is most likely not in UTC timezone.

  • Made a tiny change for the NeMo-Agent-Toolkit-UI repository. So now the front-end also stores the timezone in IANA format in its header to be sent to the backend.

FAQs

Q: why did you use UTC time by default?

  • A: UTC is industry standard's default timezone.

Q: why did you use IANA format for timezone?

  • A: IANA time zone (like "America/New_York" or "Etc/UTC") provides a standardized identifier that encodes daylight-saving rules and ensures consistent behavior across platforms and regions, and also widely accepted in industry.

Demo

Screenshot 2025-08-16 at 1 46 57 PM

Closes #445

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@zhongxuanwang-nv zhongxuanwang-nv self-assigned this Aug 16, 2025
@zhongxuanwang-nv zhongxuanwang-nv marked this pull request as draft August 16, 2025 19:07
@zhongxuanwang-nv zhongxuanwang-nv added non-breaking Non-breaking change feature request New feature or request bug Something isn't working and removed feature request New feature or request bug Something isn't working labels Aug 16, 2025
@zhongxuanwang-nv zhongxuanwang-nv marked this pull request as ready for review August 16, 2025 19:52
Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! Just some high level feedback but it's a nice fix.

Signed-off-by: Daniel Wang <[email protected]>
@zhongxuanwang-nv zhongxuanwang-nv merged commit e3a3d3b into NVIDIA:develop Aug 21, 2025
12 checks passed
saglave pushed a commit to snps-scm13/SNPS-NeMo-Agent-Toolkit that referenced this pull request Sep 2, 2025
…ling (NVIDIA#660)

<!-- Note: The pull request title will be included in the CHANGELOG. -->
<!-- Provide a standalone description of changes in this PR. -->

- Added timezone support for the `datetime_tools`, so now it will
automatically extract the `x-timezone` from the headers from context,
which will be used to format the current time.
- If the `x-timezone` is not present in the headers, the fallback behavior is checked
    - The documentations should also be clear now.

- Fixed a small issue in
`NeMo-Agent-Toolkit/src/nat/builder/user_interaction_manager.py`. Before
the timestamp is in UTC (as seen by the `Z` suffix in the timestamp),
but the timestamp is in the local timezone, which is most likely not in
UTC timezone.

- Made a tiny change for the `NeMo-Agent-Toolkit-UI` repository. So now
the front-end also stores the timezone in its header to
be sent to the backend.
- The change:
[https://github.com/NVIDIA/NeMo-Agent-Toolkit-UI/pull/38](https://github.com/NVIDIA/NeMo-Agent-Toolkit-UI/pull/38)

Closes NVIDIA#445

- I am familiar with the [Contributing
Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This
certifies that the contribution is your original work, or you have
rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will
not be accepted.
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.

---------

Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Sangharsh Aglave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Timezone Support to Client Requests and Normalize Response Time Handling

2 participants