-
Notifications
You must be signed in to change notification settings - Fork 481
Timezone Support for datetime Tool and Normalize Response Time Handling
#660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
willkill07
reviewed
Aug 18, 2025
Member
willkill07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good! Just some high level feedback but it's a nice fix.
willkill07
reviewed
Aug 18, 2025
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
willkill07
reviewed
Aug 19, 2025
Signed-off-by: Daniel Wang <[email protected]>
willkill07
approved these changes
Aug 21, 2025
saglave
pushed a commit
to snps-scm13/SNPS-NeMo-Agent-Toolkit
that referenced
this pull request
Sep 2, 2025
…ling (NVIDIA#660) <!-- Note: The pull request title will be included in the CHANGELOG. --> <!-- Provide a standalone description of changes in this PR. --> - Added timezone support for the `datetime_tools`, so now it will automatically extract the `x-timezone` from the headers from context, which will be used to format the current time. - If the `x-timezone` is not present in the headers, the fallback behavior is checked - The documentations should also be clear now. - Fixed a small issue in `NeMo-Agent-Toolkit/src/nat/builder/user_interaction_manager.py`. Before the timestamp is in UTC (as seen by the `Z` suffix in the timestamp), but the timestamp is in the local timezone, which is most likely not in UTC timezone. - Made a tiny change for the `NeMo-Agent-Toolkit-UI` repository. So now the front-end also stores the timezone in its header to be sent to the backend. - The change: [https://github.com/NVIDIA/NeMo-Agent-Toolkit-UI/pull/38](https://github.com/NVIDIA/NeMo-Agent-Toolkit-UI/pull/38) Closes NVIDIA#445 - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. --------- Signed-off-by: Daniel Wang <[email protected]> Signed-off-by: Sangharsh Aglave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added timezone support for the
datetime_tools, so now it will automatically extract thex-timezonefrom the headers from context, which will be used to format the current time.x-timezoneis not present in the headers, default UTC time is used.Fixed a small issue in
NeMo-Agent-Toolkit/src/nat/builder/user_interaction_manager.py. Before the timestamp is in UTC (as seen by theZsuffix in the timestamp), but the timestamp is in the local timezone, which is most likely not in UTC timezone.Made a tiny change for the
NeMo-Agent-Toolkit-UIrepository. So now the front-end also stores the timezone in IANA format in its header to be sent to the backend.FAQs
Q: why did you use UTC time by default?
Q: why did you use IANA format for timezone?
Demo
Closes #445
By Submitting this PR I confirm: