Add features nat workflow create a versioned dependency and data and symlinks folder
#639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
zhongxuanwang-nv
added
feature request
willkill07
reviewed
Aug 14, 2025
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
willkill07
requested changes
Aug 14, 2025
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Signed-off-by: Daniel Wang <[email protected]>
Member
Author
|
/ok to test |
willkill07
approved these changes
Aug 15, 2025
Member
willkill07
left a comment
willkill07
left a comment
There was a problem hiding this comment.
One small nit but otherwise LGTM!
Signed-off-by: Daniel Wang <[email protected]>
saglave
pushed a commit
to snps-scm13/SNPS-NeMo-Agent-Toolkit
that referenced
this pull request
Sep 2, 2025
…and symlinks folder (NVIDIA#639) ## Description <!-- Note: The pull request title will be included in the CHANGELOG. --> <!-- Provide a standalone description of changes in this PR. --> <!-- Reference any issues closed by this PR with "closes NVIDIA#1234". All PRs should have an issue they close--> This PR enhanced the command line workflow creation process by implementing dynamic NAT dependency generation with proper version constraints and adding data directory support with symlinks. Closes NVIDIA#559 Closes NVIDIA#560 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. --------- Signed-off-by: Daniel Wang <[email protected]> Signed-off-by: Sangharsh Aglave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhanced the command line workflow creation process by implementing dynamic NAT dependency generation with proper version constraints and adding data directory support with symlinks.
Closes #559
Closes #560
By Submitting this PR I confirm: