Update OpenAIModelConfig to support stream_usage option
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d adding stream_usage option for metadata in streaming responses. Signed-off-by: Michael Demoret <[email protected]>
…m_usage` in the config Signed-off-by: Michael Demoret <[email protected]>
…sage-openai Signed-off-by: Michael Demoret <[email protected]>
yczhang-nv
approved these changes
Jun 2, 2025
Collaborator
Author
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
When using any of our agents and the OpenAI provider, token metrics are not reported to telemetry providers because the option `stream_usage` defaults to False in the OpenChatModel object. This sets the default to be `True`, but leaves the option for users to override it as false with extra parameters. Overhead should be minimal. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#328
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
When using any of our agents and the OpenAI provider, token metrics are not reported to telemetry providers because the option `stream_usage` defaults to False in the OpenChatModel object. This sets the default to be `True`, but leaves the option for users to override it as false with extra parameters. Overhead should be minimal. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using any of our agents and the OpenAI provider, token metrics are not reported to telemetry providers because the option
stream_usagedefaults to False in the OpenChatModel object.This sets the default to be
True, but leaves the option for users to override it as false with extra parameters.Overhead should be minimal.
By Submitting this PR I confirm: