-
Notifications
You must be signed in to change notification settings - Fork 487
Fix plugin dependencies #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugin dependencies #208
Conversation
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…-deps-s-197 Signed-off-by: David Gardner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dependency specification for aiqtoolkit across multiple package and example pyproject.toml files and adds a new script to automate version updates during releases.
- Updated aiqtoolkit dependency from an open version to a strict version specifier (~=1.1) for consistency.
- Added a ci/release/update_toml_dep.py script for parsing and updating pyproject.toml files.
Reviewed Changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/aiqtoolkit_weave/pyproject.toml | Updated aiqtoolkit dependency version. |
| packages/aiqtoolkit_test/pyproject.toml | Updated aiqtoolkit dependency version. |
| packages/aiqtoolkit_semantic_kernel/pyproject.toml | Updated aiqtoolkit dependency version. |
| packages/aiqtoolkit_mem0ai/pyproject.toml | Updated aiqtoolkit dependency version. |
| packages/aiqtoolkit_llama_index/pyproject.toml | Updated aiqtoolkit dependency version. |
| packages/aiqtoolkit_langchain/pyproject.toml | Updated aiqtoolkit dependency version. |
| packages/aiqtoolkit_crewai/pyproject.toml | Updated aiqtoolkit dependency version. |
| packages/aiqtoolkit_agno/pyproject.toml | Updated aiqtoolkit dependency version. |
| examples/swe_bench/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/simple_calculator/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/simple/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/por_to_jiratickets/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/plot_charts/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/email_phishing_analyzer/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/documentation_guides/workflows/text_file_ingest/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/automated_description_generation/pyproject.toml | Updated aiqtoolkit dependency version for langchain plugin. |
| examples/agno_personal_finance/pyproject.toml | Updated aiqtoolkit dependency version for agno plugin. |
| ci/release/update_toml_dep.py | Added a new script to update aiqtoolkit version in TOML files. |
Files not reviewed (2)
- ci/release/update-version.sh: Language not supported
- ci/scripts/gitlab/build_wheel.sh: Language not supported
Comments suppressed due to low confidence (1)
ci/release/update_toml_dep.py:48
- The variable 'depdendencies' appears misspelled; consider renaming it to 'dependencies' for clarity.
depdendencies: tomlkit.items.Array = toml_project['dependencies']
Co-authored-by: Copilot <[email protected]> Signed-off-by: David Gardner <[email protected]>
|
/merge |
* All examples, plugins and transitional packages now declare a version dependency on `aiqtoolkit` * Adds an `ci/release/update-version.sh` script to automate the updating of versions at release time. * Add a `ci/release/update_toml_dep.py` (called by `ci/release/update-version.sh`) to parse and update individual `pyproject.toml` files. * Add a new dev dependency on `tomlkit` (this was already present in the env as a transitive dep). * Ensure that nightly builds declare explicit dependencies on the nightly version number Closes NVIDIA#197 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#208 Signed-off-by: Yuchen Zhang <[email protected]>
* All examples, plugins and transitional packages now declare a version dependency on `aiqtoolkit` * Adds an `ci/release/update-version.sh` script to automate the updating of versions at release time. * Add a `ci/release/update_toml_dep.py` (called by `ci/release/update-version.sh`) to parse and update individual `pyproject.toml` files. * Add a new dev dependency on `tomlkit` (this was already present in the env as a transitive dep). * Ensure that nightly builds declare explicit dependencies on the nightly version number Closes NVIDIA#197 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#208 Signed-off-by: Yuchen Zhang <[email protected]>
* All examples, plugins and transitional packages now declare a version dependency on `aiqtoolkit` * Adds an `ci/release/update-version.sh` script to automate the updating of versions at release time. * Add a `ci/release/update_toml_dep.py` (called by `ci/release/update-version.sh`) to parse and update individual `pyproject.toml` files. * Add a new dev dependency on `tomlkit` (this was already present in the env as a transitive dep). * Ensure that nightly builds declare explicit dependencies on the nightly version number Closes NVIDIA#197 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#208 Signed-off-by: Eric Evans <[email protected]>
* All examples, plugins and transitional packages now declare a version dependency on `aiqtoolkit` * Adds an `ci/release/update-version.sh` script to automate the updating of versions at release time. * Add a `ci/release/update_toml_dep.py` (called by `ci/release/update-version.sh`) to parse and update individual `pyproject.toml` files. * Add a new dev dependency on `tomlkit` (this was already present in the env as a transitive dep). * Ensure that nightly builds declare explicit dependencies on the nightly version number Closes NVIDIA#197 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#208 Signed-off-by: Eric Evans <[email protected]>
* All examples, plugins and transitional packages now declare a version dependency on `aiqtoolkit` * Adds an `ci/release/update-version.sh` script to automate the updating of versions at release time. * Add a `ci/release/update_toml_dep.py` (called by `ci/release/update-version.sh`) to parse and update individual `pyproject.toml` files. * Add a new dev dependency on `tomlkit` (this was already present in the env as a transitive dep). * Ensure that nightly builds declare explicit dependencies on the nightly version number Closes NVIDIA#197 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#208
* All examples, plugins and transitional packages now declare a version dependency on `aiqtoolkit` * Adds an `ci/release/update-version.sh` script to automate the updating of versions at release time. * Add a `ci/release/update_toml_dep.py` (called by `ci/release/update-version.sh`) to parse and update individual `pyproject.toml` files. * Add a new dev dependency on `tomlkit` (this was already present in the env as a transitive dep). * Ensure that nightly builds declare explicit dependencies on the nightly version number Closes NVIDIA#197 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#208
Description
aiqtoolkitci/release/update-version.shscript to automate the updating of versions at release time.ci/release/update_toml_dep.py(called byci/release/update-version.sh) to parse and update individualpyproject.tomlfiles.tomlkit(this was already present in the env as a transitive dep).Closes #197
By Submitting this PR I confirm: