Skip to content

UI submodule rename #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 8 commits into from
Apr 30, 2025
Merged

UI submodule rename #168

rapids-bot merged 8 commits into from
Apr 30, 2025

Conversation

@AnuradhaKaruppiah
Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah commented Apr 30, 2025 •
edited
Loading

Description

Commands run:

git rm --cached external/agentiq-opensource-ui
git submodule add https://github.com/NVIDIA/AIQToolkit-UI.git external/aiqtoolkit-opensource-ui
git commit <>

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@AnuradhaKaruppiah
Rename generate/stream/full to generate/full
d8e2915 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Add fitter_steps query paramenter to suppress unnecessary steps
cb297ce 
Also add a special filter "none" to suppress all steps

Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Update README with filter samples
69288cd 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Drop unnecessary suppress_steps filter
1bbabcf 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Update the example to use simple_calculator
e6f1e12 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Rename generate_streaming_response_raw[] to generate_streaming_respon…
f53d710 
…se_full[]

Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Fix submodule add for aiqtoolkit-opensource-ui
e979db1 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah AnuradhaKaruppiah added improvement Improvement to existing functionality non-breaking Non-breaking change labels Apr 30, 2025
Copilot AI reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@mdemoret-nv
Copy link
Collaborator

mdemoret-nv commented Apr 30, 2025

/merge

@rapids-bot rapids-bot bot merged commit 3cc9c7b into NVIDIA:develop Apr 30, 2025
10 checks passed
This was referenced Apr 30, 2025
Closed
Closed
@AnuradhaKaruppiah AnuradhaKaruppiah deleted the ui-submodule-rename branch May 6, 2025 00:48
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@AnuradhaKaruppiah @yczhang-nv
UI submodule rename (NVIDIA#168)
7ab8c10 
Commands run:
```
git rm --cached external/agentiq-opensource-ui
git submodule add https://github.com/NVIDIA/AIQToolkit-UI.git external/aiqtoolkit-opensource-ui
git commit <>
```

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)

URL: NVIDIA#168
Signed-off-by: Yuchen Zhang <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@AnuradhaKaruppiah @ericevans-nv
UI submodule rename (NVIDIA#168)
c4b6f10 
Commands run:
```
git rm --cached external/agentiq-opensource-ui
git submodule add https://github.com/NVIDIA/AIQToolkit-UI.git external/aiqtoolkit-opensource-ui
git commit <>
```

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)

URL: NVIDIA#168
Signed-off-by: Eric Evans <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@AnuradhaKaruppiah @ericevans-nv
UI submodule rename (NVIDIA#168)
ba45aff 
Commands run:
```
git rm --cached external/agentiq-opensource-ui
git submodule add https://github.com/NVIDIA/AIQToolkit-UI.git external/aiqtoolkit-opensource-ui
git commit <>
```

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)

URL: NVIDIA#168
Signed-off-by: Eric Evans <[email protected]>
AnuradhaKaruppiah added a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@AnuradhaKaruppiah
UI submodule rename (NVIDIA#168)
7d96c0b 
Commands run:
```
git rm --cached external/agentiq-opensource-ui
git submodule add https://github.com/NVIDIA/AIQToolkit-UI.git external/aiqtoolkit-opensource-ui
git commit <>
```

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)

URL: NVIDIA#168
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@AnuradhaKaruppiah
UI submodule rename (NVIDIA#168)
a0034c4 
Commands run:
```
git rm --cached external/agentiq-opensource-ui
git submodule add https://github.com/NVIDIA/AIQToolkit-UI.git external/aiqtoolkit-opensource-ui
git commit <>
```

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Eric Evans II (https://github.com/ericevans-nv)

URL: NVIDIA#168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ericevans-nv ericevans-nv ericevans-nv approved these changes

Assignees

No one assigned

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AnuradhaKaruppiah @mdemoret-nv @ericevans-nv