Skip to content

Add an example that shows simple_calculator running with a MCP service. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 5 commits into from
Apr 21, 2025
Merged

Add an example that shows simple_calculator running with a MCP service. #131

rapids-bot merged 5 commits into from
Apr 21, 2025

Conversation

@AnuradhaKaruppiah
Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah commented Apr 14, 2025 •
edited
Loading

This pull request adds an example configuration and documentation to demonstrate running the simple_calculator workflow with an MCP service.

  1. Adds a new MCP client configuration file (config-mcp-client.yml) for the simple_calculator workflow.
  2. Updates the simple_calculator README with instructions on how to run the workflow using MCP services.
  3. Adds an MCP server README with detailed setup and deployment instructions via Docker.

Description

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@AnuradhaKaruppiah AnuradhaKaruppiah added improvement Improvement to existing functionality non-breaking Non-breaking change labels Apr 14, 2025
@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from a team as a code owner April 14, 2025 22:01
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds an example configuration and documentation to demonstrate running the simple_calculator workflow with an MCP service.

  • Adds a new MCP client configuration file (config-mcp-client.yml) for the simple_calculator workflow.
  • Updates the simple_calculator README with instructions on how to run the workflow using MCP services.
  • Adds an MCP server README with detailed setup and deployment instructions via Docker.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
examples/simple_calculator/src/aiq_simple_calculator/configs/config-mcp-client.yml Introduces MCP client settings and defines functions, LLMs, and workflow settings for integration with MCP.
examples/simple_calculator/README.md Provides documentation on using MCP services to run the simple_calculator workflow.
examples/mcp_server/README.md Offers comprehensive instructions for setting up and running the MCP server with Docker.
Files not reviewed (1)
  • examples/mcp_server/Dockerfile: Language not supported
Comments suppressed due to low confidence (1)

examples/simple_calculator/src/aiq_simple_calculator/configs/config-mcp-client.yml:25

  • [nitpick] The naming convention for the 'calculator_divide' function differs from the other functions which use a direct name match. If this discrepancy is not intentional, consider aligning it to maintain consistency.
    _type: aiq_simple_calculator/calculator_divide

@AnuradhaKaruppiah
Fix vale warnings
d4a0f10 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah AnuradhaKaruppiah self-assigned this Apr 14, 2025
@AnuradhaKaruppiah
Copy link
Contributor Author

AnuradhaKaruppiah commented Apr 21, 2025

/merge

@rapids-bot rapids-bot bot merged commit fc7bb96 into NVIDIA:develop Apr 21, 2025
10 checks passed
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 23, 2025
@AnuradhaKaruppiah @ericevans-nv
Add an example that shows simple_calculator running with a MCP servic…
2bacee9 
…e. (NVIDIA#131)

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Matthew Penn (https://github.com/mpenn)

URL: NVIDIA#131
Signed-off-by: Eric Evans <[email protected]>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 23, 2025
@AnuradhaKaruppiah @ericevans-nv
Add an example that shows simple_calculator running with a MCP servic…
ec19845 
…e. (NVIDIA#131)

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Matthew Penn (https://github.com/mpenn)

URL: NVIDIA#131
Signed-off-by: Eric Evans <[email protected]>
@AnuradhaKaruppiah AnuradhaKaruppiah deleted the mcp-updates branch May 6, 2025 00:48
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@AnuradhaKaruppiah @yczhang-nv
Add an example that shows simple_calculator running with a MCP servic…
f5d7103 
…e. (NVIDIA#131)

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Matthew Penn (https://github.com/mpenn)

URL: NVIDIA#131
Signed-off-by: Yuchen Zhang <[email protected]>
AnuradhaKaruppiah added a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@AnuradhaKaruppiah
Add an example that shows simple_calculator running with a MCP servic…
5adb687 
…e. (NVIDIA#131)

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Matthew Penn (https://github.com/mpenn)

URL: NVIDIA#131
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@AnuradhaKaruppiah
Add an example that shows simple_calculator running with a MCP servic…
8c7a337 
…e. (NVIDIA#131)

Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Matthew Penn (https://github.com/mpenn)

URL: NVIDIA#131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mpenn mpenn mpenn approved these changes

Assignees

@AnuradhaKaruppiah AnuradhaKaruppiah

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnuradhaKaruppiah @mpenn