Fix a bug in our pytest plugin causing test coverage to be under-reported #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…e reports to be artificially low Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
willkill07
approved these changes
Apr 9, 2025
mdemoret-nv
approved these changes
Apr 9, 2025
Contributor
Author
|
/merge |
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Apr 14, 2025
…rted (NVIDIA#105) * Importing code from `aiq`, and specifically `aiq.runtime.loader` caused the coverage tool to under-report our coverage. I suspect the issue is that either our plugin was being loaded before the coverage plugin, or the coverage plugin explicitly attempts to ignore modules loaded by other plugins. * Added a few more tests * Update to pytest-cov 6.1 * Replace deprecated pydantic validator in `src/aiq/tool/github_tools/get_github_issue.py` Closes NVIDIA#102 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#105
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
Apr 21, 2025
…rted (NVIDIA#105) * Importing code from `aiq`, and specifically `aiq.runtime.loader` caused the coverage tool to under-report our coverage. I suspect the issue is that either our plugin was being loaded before the coverage plugin, or the coverage plugin explicitly attempts to ignore modules loaded by other plugins. * Added a few more tests * Update to pytest-cov 6.1 * Replace deprecated pydantic validator in `src/aiq/tool/github_tools/get_github_issue.py` Closes NVIDIA#102 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#105 Signed-off-by: Yuchen Zhang <[email protected]>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 8, 2025
…rted (NVIDIA#105) * Importing code from `aiq`, and specifically `aiq.runtime.loader` caused the coverage tool to under-report our coverage. I suspect the issue is that either our plugin was being loaded before the coverage plugin, or the coverage plugin explicitly attempts to ignore modules loaded by other plugins. * Added a few more tests * Update to pytest-cov 6.1 * Replace deprecated pydantic validator in `src/aiq/tool/github_tools/get_github_issue.py` Closes NVIDIA#102 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#105 Signed-off-by: Yuchen Zhang <[email protected]>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
…rted (NVIDIA#105) * Importing code from `aiq`, and specifically `aiq.runtime.loader` caused the coverage tool to under-report our coverage. I suspect the issue is that either our plugin was being loaded before the coverage plugin, or the coverage plugin explicitly attempts to ignore modules loaded by other plugins. * Added a few more tests * Update to pytest-cov 6.1 * Replace deprecated pydantic validator in `src/aiq/tool/github_tools/get_github_issue.py` Closes NVIDIA#102 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#105
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
…rted (NVIDIA#105) * Importing code from `aiq`, and specifically `aiq.runtime.loader` caused the coverage tool to under-report our coverage. I suspect the issue is that either our plugin was being loaded before the coverage plugin, or the coverage plugin explicitly attempts to ignore modules loaded by other plugins. * Added a few more tests * Update to pytest-cov 6.1 * Replace deprecated pydantic validator in `src/aiq/tool/github_tools/get_github_issue.py` Closes NVIDIA#102 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aiq, and specificallyaiq.runtime.loadercaused the coverage tool to under-report our coverage. I suspect the issue is that either our plugin was being loaded before the coverage plugin, or the coverage plugin explicitly attempts to ignore modules loaded by other plugins.src/aiq/tool/github_tools/get_github_issue.pyCloses #102
By Submitting this PR I confirm: